Skip to content

[no qa][Payment due @nkdengineer] Write and clear the HybridWeb experience cookie when switching to Classic and signing out - #106411

Merged
AndrewGable merged 17 commits into
Expensify:mainfrom
software-mansion-labs:jakubstec/hybridweb-experience-cookie
Nov 13, 2026
Merged

AndrewGable merged 17 commits into
Expensify:mainfrom
software-mansion-labs:jakubstec/hybridweb-experience-cookie

Conversation

@jakubstec

@jakubstec jakubstec commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Explanation of Change

Context. expensify.com is going to serve both products from one address. A router in front of it picks New Expensify or Expensify Classic based on a cookie named experience, set to new or classic. The Classic backend sets this cookie whenever it serves a Classic page. Switching to Classic and signing out only call the API from New Expensify, and those requests omit cookies, so the browser also ignores any cookie in the response. The backend can't set the cookie for these two actions, so New Expensify writes it itself.

What changes

  • Switching to Classic sets experience=classic right before Classic opens.
  • Signing out deletes the cookie.
  • Classic opens only after the server has saved the switch. If Classic opened earlier, it would still treat the user as a New Expensify user and send them back.
  • While the save is pending, the pressed switch button shows a spinner and the other survey button is disabled. If it fails, the user stays in New Expensify, sees an error and can try again.
  • The exit survey, Troubleshoot and the Settings shortcut now share two hooks. useSwitchToClassic saves the switch and then opens Classic. useOpenClassic sets the cookie and opens Classic.
  • The cookie is only written for accounts in the hybridWeb beta, and never in Supportal or Copilot sessions or when an agent starts one, so an agent's own cookie stays intact.

On new.expensify.com this code intentionally does nothing, because the cookie only matters when New Expensify and Classic share expensify.com, so there the only change is that Classic opens after the switch is saved.

Follow-ups, not in this PR

  • Serving New Expensify from expensify.com.
  • A check after sign-in that repairs a cookie that disagrees with the saved preference. For example, closing the tab while the switch is saving can leave the cookie on new while the server already saved Classic. The router must stay off for the beta until this check ships.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/700250

Tests

Prerequisites

  • A local Expensidev VM running Web-Expensify on this branch: jakubstec/experience-cookie-hooks (Sync the experience cookie on PHP navigations).
  • A test account in the hybridWeb beta. Locally every account has the all beta, which doesn't include the explicit-only hybridWeb, so in the VM set private static array $toggledBetas = [self::BETA_HYBRID_WEB]; in Web-Expensify/lib/BetaManager.php and sign in again. Revert it for step 11.
  • The account's tryNewDot NVP must have nudgeMigration, or Settings doesn't show "Switch to Expensify Classic", and classicRedirect.dismissed: false, or the exit survey is skipped. To reset it, run from Expensidev/ with your account ID:
    printf '%s\n' 'Query' "query: UPDATE nameValuePairs SET value='{\"classicRedirect\":{\"dismissed\":false},\"nudgeMigration\":{\"timestamp\":\"2026-10-01T00:00:00.000Z\"}}' WHERE accountID=<accountID> AND name='tryNewDot';" 'format: json' '' | vagrant ssh -- -T '(cat; sleep 3) | nc -q 1 127.0.0.1 4444'
  • The app served from the shared host:
    1. In /etc/hosts, change the existing expensify.com.dev entry, which points to the VM, to 127.0.0.1. Restore it after testing.
    2. Run mkcert -cert-file config/rsbuild/certificate.pem -key-file config/rsbuild/key.pem dev.new.expensify.com expensify.com.dev localhost 127.0.0.1.
    3. In .env, set NEW_EXPENSIFY_URL=https://expensify.com.dev:8082/, EXPENSIFY_URL=https://www.expensify.com.dev/ and USE_WEB_PROXY=false.
    4. Run npm run web-server -- --host expensify.com.dev.

Classic pages also write the cookie from the server. To see what New Expensify wrote, turn on "Preserve log" in DevTools > Network and check the Cookie header of the request that opens Classic (/inbox).

  1. Sign in with the beta account. In Settings, press "Switch to Expensify Classic", type a reason in "Your response" and press "Switch to Expensify Classic".
  2. Verify that while SwitchToOldDot is pending, "Switch to Expensify Classic" shows a spinner and "Go back just once" is disabled, and Classic opens only after the response arrives.
  3. Verify the request that opens Classic carries experience=classic, and DevTools > Application > Cookies shows one experience=classic cookie with Domain=.expensify.com.dev, Path=/, Secure, SameSite=Lax and no HttpOnly.
  4. Go back to New Expensify, open Account > Troubleshoot and press "Switch to Expensify Classic" on the Troubleshoot page, not in the Settings sidebar. Verify it switches without the survey after SwitchToOldDot succeeds, and the request that opens Classic carries experience=classic.
  5. Go back and press "Switch to Expensify Classic" in Settings. Verify Classic opens without a SwitchToOldDot request, and the request that opens Classic carries experience=classic.
  6. Reset the tryNewDot NVP, open New Expensify in two tabs and switch through the exit survey from the newer tab. Verify Classic opens after the SwitchToOldDot response arrives.
  7. Reset the tryNewDot NVP and open New Expensify in two tabs. Throttle the network in the first tab, switch through the exit survey and, while it's saving, open the exit survey in the second tab. Verify the first tab opens Classic only after its SwitchToOldDot response arrives, and the second tab stays on the survey with an empty response field.
  8. Reset the tryNewDot NVP and, in Web-Expensify/api.php, add throw new ExpException('Testing a failed switch', 402); as the first line of case 'SwitchToOldDot':. Switch through the exit survey. Verify an error toast shows, the survey answer is kept, the spinner stops, both buttons can be pressed again and the cookie is unchanged. Remove the line and press "Switch to Expensify Classic" again. Verify Classic opens.
  9. Reset the tryNewDot NVP, open the exit survey and press "Go back just once". Verify Classic opens without a SwitchToOldDot request, and the request that opens Classic carries the same experience value as before.
  10. Set experience=new on .expensify.com.dev in DevTools and sign out of New Expensify. Verify no experience cookie is left.
  11. Revert the BetaManager.php change, sign in again and repeat steps 1 and 10. Verify the request that opens Classic doesn't carry a cookie written by New Expensify, and signing out deletes the cookie, like the backend does.
  12. Repeat steps 1 and 10 in a Supportal session and as a Copilot. Verify the cookie is never written or deleted.
  13. Set experience=new in DevTools, then start a Supportal session for another account from Classic. Verify the cookie is still new.
  14. Serve the app from https://dev.new.expensify.com:8082 and repeat steps 1 and 10. Verify the request that opens Classic carries no experience cookie, and signing out leaves an existing cookie in place.
  15. On desktop, switch through the exit survey. When the browser opens Classic, go back to the app and verify the exit survey is closed.
  • Verify that no errors appear in the JS console

Offline tests

  1. Reset the tryNewDot NVP, sign in with the beta account and go offline.
  2. Press "Switch to Expensify Classic" in Account > Troubleshoot. Verify the survey opens with the offline message and both its buttons are disabled.
  3. Go online, complete the survey, return to New Expensify and go offline again.
  4. Verify "Switch to Expensify Classic" in Troubleshoot is disabled.
  5. Press "Switch to Expensify Classic" in Settings. Verify no SwitchToOldDot request is sent, the experience cookie is classic, and New Expensify starts opening Classic, which can't load while offline.

QA Steps

Staging runs on staging.new.expensify.com and adhoc builds on their own test hosts, not on staging.expensify.com, so the cookie isn't written there and only the switching flow can be checked.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@codecov

codecov Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 96.09% <ø> (ø)
...ents/Button/composed/ButtonDisabledWhenOffline.tsx 100.00% <100.00%> (ø)
src/hooks/useOpenClassic.ts 100.00% <100.00%> (ø)
src/hooks/useSwitchToClassic.ts 100.00% <100.00%> (ø)
src/libs/ExperienceCookie/index.native.ts 100.00% <100.00%> (ø)
src/libs/actions/ExitSurvey.ts 80.00% <100.00%> (+80.00%) ⬆️
src/libs/actions/Session/index.ts 70.03% <100.00%> (+0.18%) ⬆️
src/libs/actions/SignInRedirect.ts 84.05% <100.00%> (+1.24%) ⬆️
...c/pages/settings/Troubleshoot/TroubleshootPage.tsx 84.76% <100.00%> (+10.97%) ⬆️
...c/pages/settings/useInitialSettingsPageMenuData.ts 91.79% <100.00%> (+3.82%) ⬆️
... and 4 more
... and 13 files with indirect coverage changes

@jakubstec

Copy link
Copy Markdown
Member Author

@MelvinBot review
@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-12T16:02:42.132894Z
We couldn’t complete this review. Comment @codex review to try again.
77c1e28 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@MelvinBot

Copy link
Copy Markdown
Contributor

Found two issues:

  1. [P2] A survey reset in another tab can trigger premature navigation. In useSwitchToClassic.ts:47–54, any loading→idle transition without errors counts as success. While tab A’s switch is pending, opening the survey in tab B clears the shared form, causing A to open Classic before its request completes. Track completion of the specific request instead.

  2. [P2] Entering Supportal on the shared host clears the agent’s cookie. SignInRedirect.ts:177–183 checks only the outgoing session. During Supportal entry, that is still the agent’s ordinary session, so its cookie is deleted despite the session being stashed. Preserve the cookie during this transition. This applies if the transition uses the shared host; production link routing was not verified.

Validation: All 18 tests across the three new unit suites passed. Findings are based on source tracing; no browser reproduction performed.


view run

@kacper-mikolajczak

Copy link
Copy Markdown
Contributor

Hi! We are aware Melvin tester runs are failing. Please if you could update this branch to latest main and re-run it - this should resolve the issue. If not, reach out to me directly. Thanks for your patience!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 537cae959c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/actions/SignInRedirect.ts Resolved
Comment thread src/hooks/useSwitchToClassic.ts Resolved
@jakubstec

Copy link
Copy Markdown
Member Author

@codex review
@MelvinBot review

@MelvinBot

Copy link
Copy Markdown
Contributor

Both earlier findings are addressed. One remaining issue:

[P2] Overlapping switches can leave a successful request showing an error. In ExitSurvey.ts:24–41, success clears loading but not errors.

If two tabs submit switches before either completes, and the first fails while the second succeeds, the buffered updates retain the first request’s error. The second tab then classifies its successful switch as failed, displays an error, and never opens Classic.

Clear errors on success and associate completion with the initiating request. Add a regression test covering overlapping failure→success responses.

Validation: All 155 tests across six related suites passed. This finding is based on source tracing; no browser reproduction performed.


view run

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3b97d53915

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/hooks/useSwitchToClassic.ts Resolved
@AndrewGable

Copy link
Copy Markdown
Contributor

@jakubstec can you first fix ci?

@jakubstec

Copy link
Copy Markdown
Member Author

@AndrewGable done!

@jakubstec
jakubstec marked this pull request as ready for review November 12, 2026 15:44
@jakubstec
jakubstec requested review from a team as code owners November 12, 2026 15:44
@melvin-bot
melvin-bot Bot requested review from AndrewGable and removed request for a team November 12, 2026 15:44
@melvin-bot

melvin-bot Bot commented Nov 12, 2026

Copy link
Copy Markdown

@AndrewGable Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and removed request for a team November 12, 2026 15:44

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good on my end

size={CONST.BUTTON_SIZE.LARGE}
sentryLabel={CONST.SENTRY_LABEL.SETTINGS_EXIT_SURVEY.GO_TO_CLASSIC}
onPress={goToExpensifyClassic}
onPress={() => switchToClassic(exitSurveyResponse)}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since useSwitchToClassic only calls openClassic after the API is successful, if we close the screen before it's done, Classic never opens. Should we block closing the screen while a switch is saving and we're not offline?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's bad UX to block it. Closing the screen doesn't cancel the switch, since the server still saves it. In a follow-up PR, we will handle the misalignment between NVP and the experience cookie

const WWW_PREFIX = 'www.';

// The server writes the same cookie, so the attributes must match or the browser keeps two copies. It's not HttpOnly so New Expensify can update it.
const COOKIE_ATTRIBUTES = 'Path=/; Secure; SameSite=Lax';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the design doc: the cookie from the server is set as HttpOnly while here it's not HttpOnly. @AndrewGable, can you please confirm?

Set-Cookie: experience=new; Max-Age=31536000; Domain=.expensify.com; Path=/; Secure; HttpOnly; SameSite=Lax

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

further down, the design doc also says that if a user switches from New to Classic, we will update the cookie before the browser navigates to OldDot, so the App has to do it directly using document.cookie. If it were an HttpOnly cookie, it would be blocked, so I assume it's the correct way

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, no HttpOnly I believe.

Comment thread src/hooks/useSwitchToClassic.ts Resolved
@nkdengineer

Copy link
Copy Markdown
Contributor

@jakubstec Please resolve conflicts.

@jakubstec

Copy link
Copy Markdown
Member Author

@nkdengineer done!

@nkdengineer

Copy link
Copy Markdown
Contributor

@jakubstec Please update test steps to notice that the button shows loading instead of disabling. Thanks.

@jakubstec

Copy link
Copy Markdown
Member Author

@nkdengineer updated, thanks!

@nkdengineer

Copy link
Copy Markdown
Contributor

@jakubstec Since the QA can't do anything here, please update the title with [No QA]

@nkdengineer

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-11-13.at.22.43.34.mov
Screen.Recording.2026-11-13.at.22.48.52.mov

@nkdengineer nkdengineer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melvin-bot melvin-bot Bot changed the title Write and clear the HybridWeb experience cookie when switching to Classic and signing out [Payment due @nkdengineer] Write and clear the HybridWeb experience cookie when switching to Classic and signing out Nov 13, 2026
@melvin-bot

melvin-bot Bot commented Nov 13, 2026

Copy link
Copy Markdown

🎯 @nkdengineer, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/700250.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@AndrewGable AndrewGable changed the title [Payment due @nkdengineer] Write and clear the HybridWeb experience cookie when switching to Classic and signing out [no qa][Payment due @nkdengineer] Write and clear the HybridWeb experience cookie when switching to Classic and signing out Nov 13, 2026
@AndrewGable
AndrewGable merged commit 32655a0 into Expensify:main Nov 13, 2026
41 of 48 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 AndrewGable has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.5.40-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — the cookie changes are beta-gated or internal, and the remaining switching reliability fixes do not introduce a new workflow or make any existing article sentence incorrect.


view run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants