You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Bump @react-native-documents/picker to 12.0.3 - #106481
Upgrades @react-native-documents/picker from 10.1.3 to 12.0.3.
This is one of the dependency bumps split out of the React Native 0.88 upgrade (#101739), so it can be tested and shipped on the current React Native 0.86 before the upgrade lands. On Android, 12.x reads the activity through reactApplicationContext.currentActivity in pick, saveDocument and pickDirectory.
Upstream changes between 10.1.3 and 12.0.3 include:
11.0.0: the package ships ES modules only (no CommonJS build). Re.Pack bundles it as is, and Jest keeps using __mocks__/@react-native-documents/picker.ts.
11.0.2: every rejection goes through the same promise wrapper. Cancelling still rejects with the OPERATION_CANCELED code, so our checks in AttachmentPicker and FilePicker still treat it as a cancel (covered by tests 2 and 4).
11.0.3 / 11.0.4: Android no longer uses the deprecated currentActivity getter, and coroutine cancellation no longer leaves promises hanging.
12.0.0: the iOS module moves to Swift 6 concurrency, and Android handles errors when it reads file metadata.
12.0.1 - 12.0.3: Jest setup warnings, podspec source URLs, and Android builds where AGP 9 registers Kotlin itself.
The library is only imported from src/components/AttachmentPicker/index.native.tsx and src/components/FilePicker/index.native.tsx. The web versions of both components use <input type="file">, and the web build does not resolve .native.* files, so web and mWeb are not affected.
This PR updates the react-native-document-picker pod version and checksum in ios/Podfile.lock (standalone NewDot), and the Mobile-Expensify PR does the same in its Podfile.lock (HybridApp).
@react-native-documents/picker is only used on native, so these steps are for the HybridApp on iOS and Android. Web and mWeb are N/A.
Test 1: Attach a single file in a chat
Open any chat and tap + > Add attachment > Choose file.
Verify the system file picker opens.
Pick one file (for example a .txt). On iOS tap the file and then Open. On Android tap the file.
Verify the file is sent to the chat as an attachment.
Test 2: Cancel the picker in a chat
Open any chat and tap + > Add attachment > Choose file.
Close the picker without picking a file. On iOS tap the close (✕) button. On Android press the system Back button.
Verify the picker closes, you stay in the chat, and no error alert appears.
Test 3: Attach several files at once in a chat
Open any chat and tap + > Add attachment > Choose file.
Select a PDF and a second file. On iOS tap both files and then Open. On Android long-press the first file, tap the second one, and tap Select.
Verify both files are sent to the chat and the PDF shows a preview.
Test 4: Cancel the picker in Import spreadsheet
Go to Workspaces > a workspace you own > Categories > More > Import spreadsheet.
Tap Choose file, then close the picker without picking a file (iOS: close button, Android: system Back).
Verify the picker closes, you stay on Import spreadsheet, and no error alert appears.
Test 5: Pick a CSV in Import spreadsheet
Prepare a CSV with a header row, for example:
Category,Enabled
Picker Test Category,true
Go to Workspaces > a workspace you own > Categories > More > Import spreadsheet and tap Choose file.
Pick the CSV.
Verify the Import categories screen opens and shows the Category and Enabled columns with the values from the file. You don't need to tap Import.
Offline tests
N/A. The picker only reads files on the device, and offline handling of the resulting upload is unchanged by this bump.
QA Steps
Same as tests
PR Author Checklist
I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
I added steps for local testing in the Tests section
I added steps for the expected offline behavior in the Offline steps section
I added steps for Staging and/or Production testing in the QA steps section
I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
If new assets were added or existing ones were modified, I verified that:
The assets are optimized and compressed (for SVG files, run npm run compress-svg)
The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
I verified that all the inputs inside a form are aligned with each other.
I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
I asked an AI agent to review the changes for accessibility issues and addressed its findings.
I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
I verified all new/changed elements have meaningful accessible names and roles.
I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
Screenshots/Videos
Android: Native
Test 1:
1-attachment-single-file.mp4
Test 2:
2-attachment-cancel.mp4
Test 3:
3-attachment-multi-select-pdf-txt.mp4
Test 4:
4-file-picker-cancel.mp4
Test 5:
5-file-picker-csv-import.mp4Android: mWeb Chrome
N/A. The library is native-only, web uses <input type="file">.
iOS: Native
Test 1:
1-attachment-single-file.mp4
Test 2:
2-attachment-cancel.mp4
Test 3:
3-attachment-multi-select-pdf-txt.mp4
Test 4:
4-file-picker-cancel.mp4
Test 5:
5-file-picker-csv-import.mp4iOS: mWeb Safari
N/A. The library is native-only, web uses <input type="file">.
MacOS: Chrome / Safari
N/A. The library is native-only, web uses <input type="file">.
⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️
@gijoe0295 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
I verified the steps for local testing are in the Tests section
I verified the steps for Staging and/or Production testing are in the QA steps section
I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
I verified that comments were added to code that is not self explanatory
I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
A similar component doesn't exist in the codebase
All props are defined accurately and each prop has a /** comment above it */
The file is named correctly
The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
The only data being stored in the state is data necessary for rendering and nothing else
For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
All JSX used for rendering exists in the render method
The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
A similar style doesn't already exist
The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
I verified that all the inputs inside a form are aligned with each other.
I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #106481 with the pinned Mobile-Expensify submodule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Upgrades
@react-native-documents/pickerfrom 10.1.3 to 12.0.3.This is one of the dependency bumps split out of the React Native 0.88 upgrade (#101739), so it can be tested and shipped on the current React Native 0.86 before the upgrade lands. On Android, 12.x reads the activity through
reactApplicationContext.currentActivityinpick,saveDocumentandpickDirectory.Upstream changes between 10.1.3 and 12.0.3 include:
__mocks__/@react-native-documents/picker.ts.OPERATION_CANCELEDcode, so our checks inAttachmentPickerandFilePickerstill treat it as a cancel (covered by tests 2 and 4).currentActivitygetter, and coroutine cancellation no longer leaves promises hanging.The library is only imported from
src/components/AttachmentPicker/index.native.tsxandsrc/components/FilePicker/index.native.tsx. The web versions of both components use<input type="file">, and the web build does not resolve.native.*files, so web and mWeb are not affected.This PR updates the
react-native-document-pickerpod version and checksum inios/Podfile.lock(standalone NewDot), and the Mobile-Expensify PR does the same in itsPodfile.lock(HybridApp).Fixed Issues
$ #106112
PROPOSAL: N/A
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/14222
Tests
@react-native-documents/pickeris only used on native, so these steps are for the HybridApp on iOS and Android. Web and mWeb are N/A.Test 1: Attach a single file in a chat
+>Add attachment>Choose file..txt). On iOS tap the file and thenOpen. On Android tap the file.Test 2: Cancel the picker in a chat
+>Add attachment>Choose file.Test 3: Attach several files at once in a chat
+>Add attachment>Choose file.Open. On Android long-press the first file, tap the second one, and tapSelect.Test 4: Cancel the picker in Import spreadsheet
Categories>More>Import spreadsheet.Choose file, then close the picker without picking a file (iOS: close button, Android: system Back).Import spreadsheet, and no error alert appears.Test 5: Pick a CSV in Import spreadsheet
Categories>More>Import spreadsheetand tapChoose file.Import categoriesscreen opens and shows theCategoryandEnabledcolumns with the values from the file. You don't need to tapImport.Offline tests
N/A. The picker only reads files on the device, and offline handling of the resulting upload is unchanged by this bump.
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Test 1:
1-attachment-single-file.mp4
Test 2:
2-attachment-cancel.mp4
Test 3:
3-attachment-multi-select-pdf-txt.mp4
Test 4:
4-file-picker-cancel.mp4
Test 5:
5-file-picker-csv-import.mp4
Android: mWeb Chrome
N/A. The library is native-only, web uses
<input type="file">.iOS: Native
Test 1:
1-attachment-single-file.mp4
Test 2:
2-attachment-cancel.mp4
Test 3:
3-attachment-multi-select-pdf-txt.mp4
Test 4:
4-file-picker-cancel.mp4
Test 5:
5-file-picker-csv-import.mp4
iOS: mWeb Safari
N/A. The library is native-only, web uses
<input type="file">.MacOS: Chrome / Safari
N/A. The library is native-only, web uses
<input type="file">.