Repository navigation
Conversation
|
@codex please review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d637f6689
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@TaduJR C+ review not needed, please ignore |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e87d9f6486
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.36-0 🚀
|
|
No help site update needed — this PR adds internal Sentry tracking labels without changing user-facing features, workflows, terminology, or beta availability. |
|
No FullStory changes needed — this PR only backfills stable Sentry labels on existing controls and performs behavior-preserving refactoring, without adding user-facing functionality. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.36-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Batch 9 of labeling grandfathered
sentryLabelusages: workspace members, overview, categories, tags, taxes, distance rates, report fields, per diem, rules, agents and time tracking.WorkspaceFieldsSectionnow requires row and add-field labels so invoice fields getWorkspaceInvoices-*labels. The shared field detail pages keepWorkspaceReportFields-*for invoice fields too.Fixed Issues
$ #105523
PROPOSAL: N/A
Tests
Test 1: Member details
data-sentry-labelvaluesWorkspaceMemberDetails-Role,WorkspaceMemberDetails-DisplayName,WorkspaceMemberDetails-ChatHistoryandWorkspaceMemberDetails-RemoveTest 2: Categories, tags and taxes
WorkspaceCategories-SettingsNameandWorkspaceCategories-SettingsDeletelabelsWorkspaceTaxes-SettingsRow-CustomTaxName,WorkspaceTaxes-SettingsRow-WorkspaceDefaultandWorkspaceTaxes-SettingsRow-ForeignDefaultlabels and still open their pagesWorkspaceTags-SettingsNamelabelTest 3: Report and invoice fields
WorkspaceReportFields-RowandWorkspaceReportFields-AddFieldlabelsWorkspaceInvoices-FieldRowandWorkspaceInvoices-AddFieldlabelsOffline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari