Repository navigation
Conversation
|
@codex please review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5cd8407bf1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@Krishna2323 C+ review not needed, please ignore |
# Conflicts: # src/pages/workspace/recruiting/approver/MergeATSFinalApproverMenuItem.tsx # src/pages/workspace/travel/WorkspaceTravelBillingSection.tsx
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7fd03348cf
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.36-0 🚀
|
|
No help site update needed — this PR only adds internal Sentry tracking labels and supporting plumbing; it introduces no user-facing features, label changes, workflow changes, or beta releases that would make existing articles incorrect. |
|
No FullStory changes needed — this PR only adds internal Sentry labels and supporting refactoring to existing controls, without introducing new user-facing functionality. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.36-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Batch 10 of labeling grandfathered
sentryLabelusages: error and update-required pages, multifactor authentication, restricted actions, Schedule call, Travel, workspace upgrade/downgrade, copy settings, duplicate, HR and recruiting (Merge), rooms and travel billing. ATS filter rows get one variant per filter type, next to their existing switch labels.Fixed Issues
$ #105523
PROPOSAL: N/A
Tests
Test 1: Travel and workspace travel billing
data-sentry-labelvaluesTravel-ManageTripsBookDemoandTravel-ManageTripsBookTravelWorkspaceTravel-MoreDropdownlabel, and that the travel billing rows (settlement account, frequency, monthly limit) haveWorkspaceTravel-Billing*labels and still open their pagesTest 2: Upgrade and downgrade
WorkspaceUpgrade-IntroUpgradeorWorkspaceUpgrade-GenericFeaturesUpgradelabel, upgrade, and verify that "Got it" on the confirmation has theWorkspaceUpgrade-ConfirmationGotItlabelWorkspaceDowngrade-IntroDowngradelabel (don't confirm)Test 3: Rooms and copy settings
WorkspaceRooms-Createlabel and opens the new room pageWorkspaceCopySettings-ConfirmSettings,WorkspaceCopySettings-ConfirmWorkspacesandWorkspaceCopySettings-ConfirmSubmitlabelsOffline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari