Repository navigation
Conversation
|
@codex please review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f2ac81ef2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@dmkt9 C+ review not needed, please ignore |
…ls-accounting-a # Conflicts: # src/pages/workspace/accounting/intacct/advanced/SageIntacctAdvancedPage.tsx # src/pages/workspace/accounting/intacct/import/SageIntacctToggleMappingsPage.tsx # src/pages/workspace/accounting/netsuite/advanced/NetSuiteAdvancedPage.tsx # src/pages/workspace/accounting/netsuite/import/NetSuiteImportCustomFieldNew/NetSuiteCustomListPicker.tsx # src/pages/workspace/accounting/qbo/export/DynamicQuickbooksCompanyCardExpenseAccountPage.tsx # src/pages/workspace/accounting/qbo/export/DynamicQuickbooksOutOfPocketExpenseConfigurationPage.tsx
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91f1105b4c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
mountiny
left a comment
There was a problem hiding this comment.
Thank you, changes look good ot me
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.36-0 🚀
|
|
No FullStory changes needed — this PR only adds stable tracking labels to existing accounting controls, with no new user-facing functionality, screens, or sensitive content. |
|
No help site update needed — this PR only adds internal Sentry instrumentation; it does not change user-facing features, workflows, UI text, or make existing article instructions incorrect. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.36-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Batch 11 of labeling grandfathered
sentryLabelusages: accounting pages for QBO, Xero, Sage Intacct, NetSuite and Certinia. Settings rows rendered from one code-defined list get one variant per row (e.g.WorkspaceAccountingQBO-ImportRow-Classes); rows built from connection data (tracking categories, user dimensions, custom field records) share one label.Fixed Issues
$ #105523
PROPOSAL: N/A
Tests
Test 1: QBO
data-sentry-labelvaluesWorkspaceAccountingQBO-ImportRow-Accounts,-Classes,-Customers,-Locations,-Itemsand-TaxesWorkspaceAccountingQBO-ExportRow-<Setting>labels, then open Advanced and verify that the auto-sync row has theWorkspaceAccountingQBO-AutoSynclabel and every row still opens its pageTest 2: Xero and NetSuite
WorkspaceAccountingXero-ImportRow-<Setting>andWorkspaceAccountingXero-ExportRow-<Setting>labelsWorkspaceAccountingNetSuite-AdvancedRow-<Setting>labelsTest 3: Sage Intacct
WorkspaceAccountingSageIntacct-ImportMappingRow-<Mapping>labelsWorkspaceAccountingSageIntacct-AddUserDimensionlabelOffline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari