Repository navigation
Conversation
…et and Zoho Books pages (batch 12)
|
@codex please review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8215ed90ea
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| </ButtonDisabledWhenOffline> | ||
| )} | ||
| <ButtonDisabledWhenOffline | ||
| sentryLabel={CONST.SENTRY_LABEL.WORKSPACE.ACCOUNTING.CLAIM_OFFER_CONNECT} |
There was a problem hiding this comment.
Split the connect label by integration
When this page is opened for Xero versus Uber, handleConnect dispatches two different config.onConnect implementations (starting the Xero integration flow versus enabling receipt partners and opening Uber's URL), but both presses are reported as WorkspaceAccounting-ClaimOfferConnect. This collapses two lookup-selected button variants into one Sentry/FullStory selector; define Xero and Uber detail variants and select the matching label from the integration config.
AGENTS.md reference: AGENTS.md:L77-L77
Useful? React with 👍 / 👎.
|
@TaduJR C+ review not needed, please ignore |
…ls-accounting-b # Conflicts: # src/pages/workspace/accounting/businessCentral/advanced/BusinessCentralAdvancedPage.tsx # src/pages/workspace/accounting/businessCentral/export/BusinessCentralCardAccountPage.tsx # src/pages/workspace/accounting/businessCentral/export/BusinessCentralCardProgramAccountPage.tsx # src/pages/workspace/accounting/campfire/advanced/CampfireAdvancedPage.tsx # src/pages/workspace/accounting/campfire/export/CampfireCardAccountPage.tsx # src/pages/workspace/accounting/campfire/export/CampfireCardProgramAccountPage.tsx # src/pages/workspace/accounting/dualentry/advanced/DualEntryAdvancedPage.tsx # src/pages/workspace/accounting/dualentry/export/DualEntryCardAccountPage.tsx # src/pages/workspace/accounting/dualentry/export/DualEntryCardProgramAccountPage.tsx # src/pages/workspace/accounting/qbd/export/DynamicQuickbooksDesktopCompanyCardExpenseAccountPage.tsx # src/pages/workspace/accounting/qbd/export/DynamicQuickbooksDesktopOutOfPocketExpenseConfigurationPage.tsx # src/pages/workspace/accounting/rillet/advanced/RilletAdvancedPage.tsx # src/pages/workspace/accounting/rillet/export/RilletCardAccount.tsx # src/pages/workspace/accounting/rillet/export/RilletCardProgramAccount.tsx # src/pages/workspace/accounting/zohoBooks/advanced/ZohoBooksAdvancedPage.tsx
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32a7616031
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
mountiny
left a comment
There was a problem hiding this comment.
Thank you! Looks good to me
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.36-0 🚀
|
|
No help site update needed — this PR only adds internal Sentry tracking labels to existing controls, without changing user-facing names, workflows, feature availability, or documented behavior. |
|
No FullStory changes needed. This PR only adds Sentry labels to existing accounting controls and passes them through shared components, without introducing new user-facing behavior. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.36-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Batch 12 of labeling grandfathered
sentryLabelusages: accounting pages for QuickBooks Desktop, Business Central, Campfire, DualEntry, Rillet and Zoho Books, plus shared accounting pages (claim offer, reconciliation). Settings rows rendered from one code-defined list get one variant per row; card and feed rows built from connection data share one label per page.Fixed Issues
$ #105523
PROPOSAL: N/A
Tests
Test 1: QuickBooks Desktop
data-sentry-labelvaluesWorkspaceAccountingQBD-ImportRow-Accounts,-Classes,-Customersand-ItemsWorkspaceAccountingQBD-ExportRow-<Setting>labels and still open their pagesTest 2: Other connectors
WorkspaceAccounting<Connector>-<Setting>labels (Business Central:WorkspaceAccountingBusinessCentral-ExportRow-<Setting>)WorkspaceAccounting<Connector>-AccountingMethodlabelTest 3: Existing connections
WorkspaceAccounting-CreateNewConnectionlabel and the existing connection rows have theWorkspaceAccounting-CopyExistingConnectionlabelOffline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari