Skip to content

Part 6 - Audit usage of Str.removeSMSDomain - #106525

Merged
mountiny merged 13 commits into
Expensify:mainfrom
FitseTLT:fix-audit-removeSMSDomain-part-6
Nov 13, 2026
Merged

mountiny merged 13 commits into
Expensify:mainfrom
FitseTLT:fix-audit-removeSMSDomain-part-6

Conversation

@FitseTLT

@FitseTLT FitseTLT commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Str.removeSMSDomain already stripped the @expensify.sms suffix, but left the bare, unformatted digits behind wherever it was used for a phone-login user's name or login — inconsistent with the rest of the app, which uses formatPhoneNumber to show a readable national/international number. This is Part 6 of the ongoing audit (#97957), covering the remaining misc sites: the account switcher's login subtitle and the single-invite confirmation screen's member name.

Converted AccountSwitcher.tsx and AccountSwitcherButton.tsx (both display a login, so bare formatPhoneNumber(login), no guard needed) and WorkspaceInviteMessageComponent.tsx's invitingMemberName (built from a displayName, so the guarded Str.isSMSLogin(x) ? formatPhoneNumber(x) : x). Two originally-scoped sites were dropped: getUserNameByEmail no longer exists in the codebase, and getPhoneNumber in PersonalDetailsUtils.ts is a raw-value getter whose three callers already apply the guard themselves, so it correctly stays unconverted.

Fixed Issues

$ #97957
PROPOSAL:

Tests

Precondition: an account whose login is a phone/SMS number (e.g. +14155550100@expensify.sms) with no display name set, so its display name falls back to the raw login.

To reproduce that precondition: as an admin, invite a phone number that has not yet been registered on Expensify to your Workspace. Then, from a separate session/device, sign in using that same phone number for the first time. Because the account is brand new and was never given a display name, its display name falls back to the raw login — this is the state that currently prints unformatted digits.

  1. Sign in as (or have access to) an account with at least one delegate/copilot relationship so the account-switcher "Switch" button is visible, where one of the accounts is the SMS-login account above. Open the account switcher (left sidebar).
  2. Verify the subtitle under the current account's name shows a formatted phone number (e.g. +1 (415) 555-0100), not raw digits like +14155550100.
  3. Click Switch to open the delegate popover. Verify the SMS-login account's description line also shows the formatted number.
  4. In the same popover, type the account's raw unformatted digits (e.g. 4155550100) into the search box. Verify the account still appears, even though its displayed description is formatted.
  5. With only one delegate account (not 12+), verify the search box still appears in the popover.
  6. As an admin, go to Company Cards → assign a card (or Expensify Card → issue a new card) → Invite new member step. Enter the SMS-login account's phone number as the invitee — this phone number should not already be a Workspace member, so the flow hits the brand-new-invitee fallback path rather than resolving an existing member's name. On the confirmation screen, verify the Member field shows a formatted phone number, not raw digits.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari image image

@FitseTLT
FitseTLT requested review from a team as code owners November 10, 2026 16:40
@melvin-bot
melvin-bot Bot requested a review from shubham1206agra November 10, 2026 16:40
@melvin-bot
melvin-bot Bot removed the request for review from a team November 10, 2026 16:40
@melvin-bot

melvin-bot Bot commented Nov 10, 2026

Copy link
Copy Markdown

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested a review from garrettmknight November 10, 2026 16:40
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T14:20:13.727479Z 2e7ccec Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot removed the request for review from a team November 10, 2026 16:40

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d93c0faaa3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@codecov

codecov Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/AccountSwitcher.tsx 97.43% <100.00%> (ø)
...kspace/members/WorkspaceInviteMessageComponent.tsx 89.85% <100.00%> (+0.09%) ⬆️
src/components/AccountSwitcherButton.tsx 85.36% <88.88%> (+0.27%) ⬆️
...onents/Tables/WorkspaceCompanyCardsTable/index.tsx 82.68% <33.33%> (-0.53%) ⬇️
... and 11 files with indirect coverage changes

@FitseTLT
FitseTLT requested review from Eskalifer1 and removed request for shubham1206agra November 11, 2026 13:18

@Eskalifer1 Eskalifer1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex review

@FitseTLT
FitseTLT requested a review from Eskalifer1 November 11, 2026 14:18

@Eskalifer1 Eskalifer1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are well-written, but I think the QA team might have questions about how to reproduce the precondition so that there is no display name.

I suggest adding a note explaining that this can be done by first adding a phone number(which hasn’t yet been registered in Expensify) from another account to the Workspace as an admin, and only then logging in with that number - in which case the display name won’t be set and the fallback will be used.

Also let's add note to step 4 in tests that invite login(phone number) should not be Workspace member

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2e7ccec277

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@FitseTLT
FitseTLT requested a review from Eskalifer1 November 11, 2026 14:32
@Eskalifer1

This comment was marked as resolved.

@Eskalifer1

Copy link
Copy Markdown
Contributor

1 small cosmetic bug: You have double Verify that no errors appear in the JS console in Tests section.

One more 1: Do you plan to upload recordings for other platforms or we are good to move only with MacOs?

@Eskalifer1

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp 106525-android-native-1 106525-android-native-2
Android: mWeb Chrome 106525-android-web-1 106525-android-web-2
iOS: HybridApp 106525-ios-native-1 106525-ios-native-2
iOS: mWeb Safari 106525-ios-web-1 106525-ios-web-2
MacOS: Chrome / Safari 106525-web-1 106525-web-2

@Eskalifer1 Eskalifer1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Part 7 of the ongoing audit

This should be only Part 6, let's also fix that in Explanation of change section

@Eskalifer1 Eskalifer1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for PR @FitseTLT!

I have left 2 NAB comments here and here

And asked 1q here

Approving it now so as not to delay the process and CME could make review faster.

After answering q and fixing NAB review we can merge this one!

@melvin-bot
melvin-bot Bot requested a review from mountiny November 11, 2026 15:40
@FitseTLT

Copy link
Copy Markdown
Contributor Author

1 small cosmetic bug: You have double Verify that no errors appear in the JS console in Tests section.

One more 1: Do you plan to upload recordings for other platforms or we are good to move only with MacOs?

yes it's ok

@FitseTLT

Copy link
Copy Markdown
Contributor Author

One pending question @Eskalifer1

@FitseTLT

Copy link
Copy Markdown
Contributor Author

We are done here right? @Eskalifer1

@Eskalifer1

Copy link
Copy Markdown
Contributor

We are done here right? @Eskalifer1

Yep! Waiting on @mountiny approve

mountiny
mountiny previously approved these changes Nov 12, 2026

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there are conflicts

@mountiny
mountiny merged commit bca03a8 into Expensify:main Nov 13, 2026
37 of 38 checks passed
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.40-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR fixes phone-number formatting without adding a feature, changing a workflow, or making existing article instructions incorrect.


view run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants