Skip to content

[No QA] Type web-only styles for the React Native Strict TypeScript API - #106526

Merged
roryabraham merged 8 commits into
Expensify:mainfrom
software-mansion-labs:collectioneur/strict-api-web-style-types
Nov 16, 2026
Merged

roryabraham merged 8 commits into
Expensify:mainfrom
software-mansion-labs:collectioneur/strict-api-web-style-types

Conversation

@collectioneur

@collectioneur collectioneur commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

RN 0.87+ makes the Strict TypeScript API the default. @types/react-native-web 0.19.2 widened RN's style types globally, which the Strict API rejects. This bumps it to 0.19.3, which drops that, removes its obsolete patch, and types the web-only CSS values the app uses through WebOnlyStyleUtils and a narrow augmentation. Behavior is unchanged.

What 0.19.2 did. Its declare module "react-native" block merged every CSS property into RN's ViewStyle, TextStyle and ImageStyle, and redeclared keys RN already has (display, position, width, ...) with CSS types. Any CSS value typechecked, including any string as a size. Those redeclarations conflict with RN's own, which skipLibCheck hid because they live in a .d.ts.

How web-only values are typed now. Module augmentation can add keys, but it can't widen a key RN already declares, so there are two paths:

  • Keys RN doesn't declare at all (whiteSpace, gridTemplateColumns, scrollSnapAlign, visibility, ...) are added back in src/types/modules/react-native-web-augmentation.ts with react-native-web's own value types. It's a .ts file, so a conflict with RN's declarations is reported instead of hidden by skipLibCheck.
  • Web values for keys RN declares (display: 'grid', position: 'fixed', calc() sizes, ...) are wrapped in toViewStyle, toTextStyle or toDimensionValue. These return their argument and hold the only type assertion. They still check every key they don't widen against RN's types, which an inline as ViewStyle doesn't.

Why the patch can go. It edited the removed block: it extended Text's accessibilityRole and added userSelect with 'contain' to ViewStyle. Without the block, Text takes accessibilityRole from RN's AccessibilityProps, whose list is the same 30 roles the patch wrote. RN declares userSelect, 'contain' included, on TextStyle only. The augmentation adds it to ViewStyle with TextStyle's type, next to the other text keys the app sets on views (styles.userSelectNone is used on Views).

Why some type assertions are gone. 0.19.2 gave ViewStyle CSS types for color, fontSize and fontWeight while TextStyle kept RN's. So TextStyle stopped being a ViewStyle, and the style types of react-native-render-html and expo-image, which are derived from RN's, stopped matching. The as TextStyle, as ViewStyle and as ExpoImageProps['style'] casts covered that up. Removing them on main, with 0.19.2 and the patch, gives 14 type errors. On this branch it gives none. The casts in MentionUserRenderer and FeatureTrainingCarousel weren't needed even before.

No longer typed: 0.19.2 also let Text take role values that RN's Role doesn't have (paragraph, label, text). Nothing in the app uses them.

Fixed Issues

$ #101439
PROPOSAL: N/A

Tests

This PR changes types, plus identity helpers around web-only style values. Tests 1 and 2 check the type graph, tests 3 and 4 check that the web-only styles still reach the DOM on web.

Test 1: The app still typechecks on the current React Native types

  1. Run npm install
  2. Run npm run typecheck
  3. Verify that it ends with Type checking passed.

Test 2: @types/react-native-web no longer widens React Native's types

  1. Run grep -c 'declare module "react-native"' node_modules/@types/react-native-web/index.d.ts
  2. Verify that it prints 0
  3. Run npm install again and verify that patch-package reports no error for @types/react-native-web
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

No QA

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

…t-api-web-style-types

# Conflicts:
#	src/libs/Navigation/helpers/singleRHPWidth/index.ts
#	src/styles/index.ts
@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/components/Composer/implementation/index.tsx 73.68% <100.00%> (ø)
...onents/FeatureTraining/FeatureTrainingCarousel.tsx 2.41% <100.00%> (ø)
...vider/HTMLRenderers/AccountManagerLinkRenderer.tsx 78.94% <100.00%> (ø)
...ider/HTMLRenderers/MentionReportRenderer/index.tsx 87.80% <100.00%> (ø)
...gineProvider/HTMLRenderers/MentionUserRenderer.tsx 98.76% <100.00%> (ø)
...enderers/VictoryChartRenderer/utils/parseStyles.ts 75.00% <100.00%> (ø)
src/components/Image/BaseImage.native.tsx 74.07% <100.00%> (ø)
src/components/Image/BaseImage.tsx 80.76% <100.00%> (ø)
src/components/Image/index.tsx 65.07% <100.00%> (ø)
src/components/ImageSVG/index.android.tsx 96.96% <100.00%> (ø)
... and 29 more
... and 6 files with indirect coverage changes

@melvin-bot

melvin-bot Bot commented Nov 13, 2026

Copy link
Copy Markdown

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

import parseAttribute from './parseAttribute';

/** Chart nodes also carry the SVG paint properties that the chart's style attribute sets */
type ChartNodeStyle = ViewStyle & {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't victory chart export simiar style? Why would we have to defin ours?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

victory-native has no {fill, stroke} type because it never uses that shape, those keys come from our chart HTML and we turn them into its color and strokeWidth props ourselves.
iewStyle used to accept them because react-native-web types added every CSS property to it and 0.19.3 stopped doing that

Comment thread src/styles/index.ts Resolved

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NAB] I get that extracting those functions to a separate file makes the codebase cleaner, but also everyone now have to check what each function does (which is just an assertion).
Not saying that this is entirely wrong, but it may be worth considering

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe keeping them in one file is the cleanest option, inlining them would mean 39 as casts, each with its own eslint-disable across 17 files. The helpers are also stricter than a bare as, toViewStyle only accepts a WebOnlyViewStyle, so it can't cast an unrelated object.

I've added a one-line JSDoc to each of them so hovering shows they just return their argument

@collectioneur
collectioneur marked this pull request as ready for review November 16, 2026 17:36
@collectioneur
collectioneur requested review from a team as code owners November 16, 2026 17:36
@expensify-chore-bot
expensify-chore-bot Bot requested review from shubham1206agra and removed request for a team November 16, 2026 17:37
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T17:56:46.812665Z 139d8c2 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@expensify-chore-bot

Copy link
Copy Markdown

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@expensify-chore-bot
expensify-chore-bot Bot requested review from garrettmknight and removed request for a team November 16, 2026 17:37

@roryabraham roryabraham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@roryabraham
roryabraham merged commit c615c66 into Expensify:main Nov 16, 2026
47 of 48 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.40-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR updates TypeScript style types and compatibility helpers without changing user-facing features, workflows, or labels, so existing articles remain accurate.


view run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants