Skip to content

[Payment due @bernhardoj] [No QA] Cap victory chart canvas size and axis tick count - #106557

Merged
NicolasBonet merged 3 commits into
mainfrom
nicolasbonet-victorychart-caps
Nov 17, 2026
Merged

NicolasBonet merged 3 commits into
mainfrom
nicolasbonet-victorychart-caps

Conversation

@NicolasBonet

@NicolasBonet NicolasBonet commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

The headless chart renderer creates a surface of whatever width × height the <victorychart> asks for, and the shared axis parser passes any tickcount to victory-native, which generates one tick per count. Very large values let a single chart use gigabytes of memory.

This caps the canvas at 4096 px per side, rejecting larger charts with the same kind of error as the existing size validation, and limits the axis tick count to 100. Real charts are 680 px wide and use fewer than ten ticks, so they are unaffected.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/702554
PROPOSAL: N/A

Tests

  1. Run npm run server:vcr:test.
  2. Verify all tests pass, including the new resolveCanvasSize cases that reject 4097, 16000 and 1e9 and accept 4096.
  3. Run npx jest tests/unit/components/HTMLEngineProvider/VictoryChartParsers.test.ts.
  4. Verify all tests pass, including the new tests that cap tickcount="1000000000" at 100 and keep tickcount="5".
  5. Sign in as a workspace admin whose workspace has expenses, open the workspace's #admins room and ask Concierge a breakdown question, such as "What was my monthly spend for the last 6 months?" or "What are my top spending categories this year?"
  6. Verify the charts render the same as before.

Verified locally:

  • npm run server:vcr:test passes (37 tests), including byte-identical golden images for the existing fixtures.

  • Built the Linux renderer from this branch and ran it in the dev VM: a 680x430 chart renders in 0.26s and a 4096x4096 chart still renders, while a 16000x16000 chart is rejected in 0.2s at about 190 MB instead of taking 7s and 2.2 GB. A chart with tickcount="1000000000" renders in 0.25s.

  • On web, chart comments in a chat render as before, including a chat with 13 charts, and the page stays responsive.

  • Verify that no errors appear in the JS console

Offline tests

N/A, this only changes how chart markup is parsed and rendered.

QA Steps

[No QA] The renderer change only affects charts larger than any we generate, and existing charts render byte-identical golden images in the renderer tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Not tested. The only client change is the tickcount cap in the shared axis parser, which is covered by unit tests and does not depend on the platform.

Android: mWeb Chrome

Not tested. The only client change is the tickcount cap in the shared axis parser, which is covered by unit tests and does not depend on the platform.

iOS: Native

Not tested. The only client change is the tickcount cap in the shared axis parser, which is covered by unit tests and does not depend on the platform.

iOS: mWeb Safari

Not tested. The only client change is the tickcount cap in the shared axis parser, which is covered by unit tests and does not depend on the platform.

MacOS: Chrome / Safari

Chart comment rendered on web (Chromium) with this branch:

Monthly spend chart rendered in a chat

@NicolasBonet
NicolasBonet marked this pull request as ready for review November 10, 2026 22:40
@NicolasBonet
NicolasBonet requested review from a team as code owners November 10, 2026 22:40
@melvin-bot
melvin-bot Bot requested review from bernhardoj and removed request for a team November 10, 2026 22:40
@melvin-bot

melvin-bot Bot commented Nov 10, 2026

Copy link
Copy Markdown

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team November 10, 2026 22:40
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T22:51:43.426319Z f9cd6df Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@joekaufmanexpensify

Copy link
Copy Markdown
Contributor

No product review needed.

@joekaufmanexpensify
joekaufmanexpensify removed their request for review November 12, 2026 21:19
@NicolasBonet
NicolasBonet requested a review from a team November 13, 2026 14:48
@melvin-bot
melvin-bot Bot requested review from puneetlath and removed request for a team November 13, 2026 14:49
@melvin-bot

melvin-bot Bot commented Nov 13, 2026

Copy link
Copy Markdown

@puneetlath Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@bernhardoj

bernhardoj commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari image

@bernhardoj

Copy link
Copy Markdown
Contributor

@NicolasBonet how to have the concierge send a chart? I asked, "Give me a spend analysis chart," but it gives me a link to the Insight page.

@NicolasBonet

Copy link
Copy Markdown
Contributor Author

@bernhardoj Concierge only draws charts for analytical questions that break spend down by month, category, merchant, submitter or tag. It always has that ability in a workspace's #admins room, and the workspace needs expenses. For example, try asking in #admins: "What was my monthly spend for the last 6 months?" or "What are my top spending categories this year?"

I've updated step 5 of the test steps with this too.

@bernhardoj

Copy link
Copy Markdown
Contributor

@NicolasBonet hmm, I got the breakdown in text

image

@bernhardoj

Copy link
Copy Markdown
Contributor

It shows a chart now after I asked it to draw a chart

@melvin-bot melvin-bot Bot changed the title [No QA] Cap victory chart canvas size and axis tick count [Payment due @bernhardoj] [No QA] Cap victory chart canvas size and axis tick count Nov 17, 2026
@melvin-bot

melvin-bot Bot commented Nov 17, 2026

Copy link
Copy Markdown

🎯 @bernhardoj, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/702554.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@NicolasBonet
NicolasBonet requested a review from a team November 17, 2026 14:10
@expensify-chore-bot
expensify-chore-bot Bot requested review from ZhenjaHorbach and removed request for a team November 17, 2026 14:11
@expensify-chore-bot

Copy link
Copy Markdown

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@NicolasBonet
NicolasBonet removed the request for review from ZhenjaHorbach November 17, 2026 14:11
@puneetlath
puneetlath requested a balanced review from Copilot and removed request for puneetlath November 17, 2026 15:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the changes limiting canvas dimensions and axis tick counts.

No open issues 🎉

What changed in this PR

This PR limits memory usage from oversized chart markup in the headless renderer and shared axis parser, while preserving normal chart sizes and tick counts.

Changes:

  • Reject canvas dimensions above 4096 pixels per side.
  • Cap explicit axis tickcount values at 100.
  • Add boundary and regression tests, plus Bun typings for parameterized tests.
File Description
tests/​unit/​components/​HTMLEngineProvider/​VictoryChartParsers.test.ts Tests oversized and normal tick counts.
src/​components/​HTMLEngineProvider/​HTMLRenderers/​VictoryChartRenderer/​parsers/​victoryAxisParser.ts Caps explicit tick counts at the shared maximum.
src/​components/​HTMLEngineProvider/​HTMLRenderers/​VictoryChartRenderer/​constants.ts Defines the 100-tick limit.
server/​victory-chart-renderer/​tests/​resolveCanvasSize.test.ts Tests acceptance at 4096 and rejection above it.
server/​victory-chart-renderer/​src/​types/​bun.d.ts Adds typing for test.each.
server/​victory-chart-renderer/​src/​resolveCanvasSize.ts Rejects canvas dimensions exceeding 4096 pixels.

Review effort: Balanced

@NicolasBonet
NicolasBonet merged commit 0bd54f1 into main Nov 17, 2026
50 of 53 checks passed
@NicolasBonet
NicolasBonet deleted the nicolasbonet-victorychart-caps branch November 17, 2026 15:37
@github-actions

Copy link
Copy Markdown
Contributor

🚧 NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/NicolasBonet in version: 9.5.41-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR only adds internal chart-rendering safeguards against excessive memory use, without introducing a feature, changing the normal user workflow, or making an existing article inaccurate.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@melvin-bot

melvin-bot Bot commented Nov 18, 2026

Copy link
Copy Markdown

🤖 Payment issue created: #107321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants