Repository navigation
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
24f2f90 to
04b1814
Compare
|
The "Done when" in #105627 says the collapsed state should carry over to another device, but |
|
About this comment: my suggestion would be to update the issue to "survives a reload" rather than adding a backend write. Sidebar collapse feels heavily screen-size dependent (e.g., collapsed on a 13" laptop vs. expanded on an external monitor), so syncing it globally across devices could hurt UX. Keeping it device-local in Onyx also stays consistent with @shawnborton what do you think? |
|
I'm cool with keeping it device-local, that makes sense to me. |
…1-collapse # Conflicts: # src/components/Navigation/FlatNavigationBar/index.tsx
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Let me know when this is ready for a build so I can test! |
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc510d687e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
JmillsExpensify
left a comment
There was a problem hiding this comment.
This looks sooo good!
|
@Krishna2323 please prioritize this PR today. I'd like to aim to get it merged so we can focus on breaking up Spend next week. |
|
Reviewing... |
Monosnap.screencast.2026-11-13.21-20-27.mp4 |
|
Flickering fixed 🔧 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMonosnap.screencast.2026-11-13.23-11-17.mp4 |
Monosnap.screencast.2026-11-13.23-14-55.mp4 |
|
About this issue: It feels like a rare edge case with an unclear cause, so I'd leave it as-is for now and just monitor if it comes back. |
|
@mountiny can you review/merge to keep the party going? |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.40-0 🚀
|
|
No help site update needed — the collapsible navigation changes remain behind the |
|
Deploy Blocker #107061 was identified to be related to this PR. |
Explanation of Change
As part of the Flat Navigation project (behind the
flatNavbeta on wide web layouts), this PR implements Release 3.1: collapsingFlatNavigationBarinto a skinny icon rail (60px) and expanding it back to full width (232px). Because Release 2 removes the Spend column along with its collapse button, the flat navigation bar needs its own dedicated collapse control while sharing the same persisted state so both surfaces collapse simultaneously.This PR implements the collapsible navigation bar by:
FlatNavCollapseTogglein the flat navigation bar header next to the Expensify wordmark, usingCONST.SENTRY_LABEL.NAVIGATION_TAB_BAR.COLLAPSEand hit-slop expansion. When the bar is shown on wide layouts, the duplicate toggle inSearchSidebaris hidden.SearchSidebarCollapseStorefrom a single global boolean to trackpeekingSurface(COLLAPSE_SURFACE.NAVIGATION_BARvsCOLLAPSE_SURFACE.SEARCH_SIDEBAR). Hovering over a collapsed navigation bar peeks only the navigation bar over the content without triggering expansion of the adjacent Spend sidebar, and vice versa.Tab(:focus-visible), maintaining the peek while tabbing between items inside, and collapsing back on blur.stickToLeft+zIndex1). When peeking, the navigation bar expands to 232px with a drop shadow overlay (flatNavigationBarPeekShadow), floating above adjacent content without shifting the layout.isCompactsupport toFlatNavCreateButton: the green button keeps filling its container, so it narrows together with the bar from a full-width pill into a 32px circular "+" centered in the 60px rail (60px rail − 2 × 14px inset = 32px button height), instead of snapping to a circle. Moving the collapse fade insideFlatNavAccountStatusto eliminate phantom spacing, and fading the Expensify wordmark in place while maintaining accessible tab index /aria-hiddenstates.FlatNavigationBarso the bar remains pinned in the peeking state while the popup create menu is open, smoothly releasing peek once the menu closes.useNavigationBarWidthto select onlyisCollapsedfromONYXKEYS.NVP_SEARCH_SIDEBAR, ensuring layout width subscribers (TabNavigatorBar, central pane offset) do not re-render during hover peek transitions.NVP_SEARCH_SIDEBAR.isCollapsed(device-local Onyx key preserved across sign-out) so collapse state survives page reloads.Fixed Issues
$ #105627
PROPOSAL: #105175
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
web.mov