Repository navigation
Conversation
Co-authored-by: Maruf Sharifi <marufsharifi@users.noreply.github.com>
|
🤖 Web test steps verification results: ❌ fail Verified access on dev NewDot web. Testing was blocked by the missing workspace and approver, submitter, and external vacation-delegate fixtures; immediate message rendering remains unverified.
|
|
🤖 Android test steps verification results: ❌ fail The documented scenario requires multiple authenticated identities, but only one Android session is available, so testing was blocked before device interaction. No screenshots were captured, and the fix remains unverified; this is an environment blocker, not evidence of a PR defect.
|
|
@MelvinBot, replace the PR Author checklist with the verified one below: PR author checklist |
|
Updated the PR Author Checklist with all supplied boxes checked on your behalf. Other sections and previous test results remain unchanged; no tests were rerun. |
|
@MelvinBot merge the main. |
Co-authored-by: Maruf Sharifi <marufsharifi@users.noreply.github.com>
|
|
|
@MelvinBot mark this as ready for review. |
|
Marked Show delegate submit system messages without reopening expense details as ready for review. |
|
@marufsharifi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-11-12.at.3.11.52.PM.movAndroid: mWeb Chromehow.are.you.mp4iOS: HybridAppiOS: mWeb SafariScreen.Recording.2026-11-12.at.2.16.19.PM.movMacOS: Chrome / Safariweb.mov |
|
Claude posting on behalf of Matt: Closing this PR. Work on the linked issue continues in a new PR. Use this one as a reference. |


Explanation of Change
Exempt
ACTION_DELEGATE_SUBMITfrom empty-message deletion detection, matching other system actions whose text is generated fromoriginalMessage. This prevents the live submit action from being hidden until reopening the expense details supplies rendered message fragments.Add regression coverage for both an empty message array and empty HTML, checking deletion detection and report-action visibility. Both cases failed before the exemption and pass with it.
AI Tests
npm run lint,npm run lint-changed,npm run spell-changed,npm run typecheck, andnpm run storybook -- --smoke-test --ci.npm test -- --silent --maxWorkers=2) exceeded the 10-minute local limit; no failures were reported before timeout. Full-suite completion still needs CI verification.npm run prettier -- --log-level errorcould not run because this revision has noprettierscript. Directoxfmt --checkwas denied by the execution policy; formatting verification remains incomplete.Contributor branch ownership
Created from an upstream branch because Melvin does not have push access to
marufsharifi's fork. To copy the branch into that fork:Then close this draft and open a replacement PR from the fork if preferred.
Fixed Issues
$ #98705
PROPOSAL: #98705 (comment)
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari