Repository navigation
[Payment due @truph01] Apply the itemized receipt rule per snapshot in the Violations column - #106613
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / SafariScreen.Recording.2026-11-16.at.11.35.43.mov |
|
@marcaaron Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🎯 @truph01, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
This PR addresses a review comment raised by @neil-marcellini here, so I'm requesting a review from him. Sorry for the tag, @marcaaron. |
neil-marcellini
left a comment
There was a problem hiding this comment.
Good to go thanks
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here. |
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.5.40-0 🚀
|
|
No help site update needed — this fixes receipt-violation display consistency across repeated submissions and approvals without adding a workflow or making any existing article sentence incorrect. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Explanation of Change
The Search Violations column merged names across all of an expense's submit (or approve) actions, then hid "Receipt required" if "Itemized receipt required" was anywhere in the merged list. Search and Insights apply that rule within each snapshot. So an expense submitted with only
receiptRequired, then resubmitted with both, matchedviolation:receiptRequiredwhile the column showed only "Itemized receipt required". The column now appliesfilterReceiptViolationsto each snapshot before merging, so it lists both in that case. https://github.com/Expensify/Auth/pull/26577 does the same for the CSV export. Agreed in https://github.com/Expensify/Auth/pull/26133#discussion_r4533507118Fixed Issues
$ https://github.com/Expensify/Expensify/issues/699199
PROPOSAL: N/A
Tests
type:expense has:submitted-violation.Now:
Before:

Offline tests
Same as tests. The column reads report actions already in Onyx, so it shows the same names offline.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Now:
Before:
