Skip to content

Guard missing workspace domain verification parameters - #106614

Merged
mountiny merged 1 commit into
mainfrom
claude-guardMissingDomainParams
Nov 19, 2026
Merged

mountiny merged 1 commit into
mainfrom
claude-guardMissingDomainParams

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Safely read the verification screen's domain account ID and show the existing dismissible not-found page when it is missing. This prevents a render-time crash before domain validation and avoids constructing destination routes with an absent ID. Valid-ID behavior is unchanged.

Add regression coverage for undefined params and an empty params object, asserting that the fallback renders without mounting the verification flow or requesting a validation code. The upstream navigation trigger remains unconfirmed; this is the approved defensive fix.

AI Tests

  • Passed: full Jest suite — 2,331 suites and 38,791 tests passed; 1 suite and 146 tests skipped; 160 snapshots passed. An initial two-worker attempt timed out; the four-worker rerun completed successfully.
  • Passed: targeted verification suite — all 9 tests, including both new regression cases.
  • Passed: npm run lint, npm run lint-changed, npm run typecheck, npm run spell-changed, Storybook smoke test, and direct React Compiler check of the changed screen.
  • Passed: staged diff whitespace check and independent coding-standards review (no violations).
  • Tooling limitations: the requested Prettier script no longer exists; attempts to invoke the replacement formatter were denied. The changed-file compiler check could not resolve its empty base-branch setting; direct file compilation passed instead.
  • Browser verification blocked: the handed-off web session was blank, so neither URL routing nor Back behavior could be verified. This is not evidence of a fix regression. Native/HybridApp testing remains outstanding.

Fixed Issues

$ #106405
PROPOSAL: #106405 (comment)

Tests

  1. Sign in on NewDot (web and/or Android).
  2. Open workspaces/verify-domain/123456789 (unknown / non-existent domain ID).
    • Confirm a recoverable Not Found screen is shown.
  3. Open workspaces/verify-domain with no domain ID.
    • Confirm Not Found is shown.
  4. Open workspaces/verify-domain/<validDomainAccountID> for a domain you can verify.
    • Confirm the normal verify-domain UI loads.

Offline tests

N/A

QA Steps

Same as Tests.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Web verification was blocked by a blank handed-off session; this screenshot documents the blocker, not successful verification.

Blank handed-off web session preventing route verification

Co-authored-by: abdulrahuman5196 <abdulrahuman5196@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team November 11, 2026 08:45
@melvin-bot melvin-bot Bot added Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web labels Nov 11, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch because an accessible contributor fork was not found. To copy the branch to your fork and push updates yourself, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-guardMissingDomainParams
git checkout -b claude-guardMissingDomainParams upstream/claude-guardMissingDomainParams
git push -u origin claude-guardMissingDomainParams

You can then close this draft and open a replacement PR from your fork.

@MelvinBot

MelvinBot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Web test steps verification results: ⚠️ partial

Verified invalid-route recovery on dev NewDot web. Valid-domain verification and the console-error assertion remain blocked.

Missing-ID URL fallback with functional Back

Step Status
Unknown domain ID shows recoverable not-found; Back returns to WorkspacesOpened workspaces/verify-domain/123456789. The not-found screen rendered, and Back returned to Workspaces.
Unknown-domain not-found screen with Back
✅
Missing-ID URL shows not-found with functional Back and no visible crashOpened workspaces/verify-domain. Not-found rendered, and Back returned to the prior chat. This verifies URL fallback—not reproduction of undefined route.params or direct exercise of the new guard.
Missing-ID URL fallback with functional Back
✅
Valid-domain instructions, DNS records, and validation work normallyBlocked: no existing domain was available, and no valid domain/DNS-control fixture was supplied.
⚠️
No JavaScript console errorsBlocked: console inspection was unavailable through the testing interface. No visible crash occurred, but console cleanliness is unverified.
⚠️

view run · view recording

@MelvinBot

MelvinBot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Android test steps verification results: ⚠️ partial

Verified both boundary URLs on standalone Android NewDot. This does not reproduce the reported HybridApp crash or prove execution with undefined route.params.

Missing domain ID displays not-found with Back

Step Status
Unknown domain ID shows recoverable not-found; Back returns to WorkspacesOpened workspaces/verify-domain/123456789 through an in-app link. Not-found rendered, and Back returned to Workspaces, confirmed by snapshot.
Unknown domain ID displays recoverable not-found with Back
✅
Missing domain ID shows not-found with functional Back and no visible crashOpened workspaces/verify-domain. Not-found rendered, and Back returned to the originating chat. This verifies URL fallback only—not actual undefined route.params.
Missing domain ID displays not-found with Back
✅
Valid domain preserves instructions, DNS records and validationBlocked: Domains showed an empty state, and no valid domain-account fixture was available. These flows remain untested.
⚠️
No JavaScript console errors during checksUnobservable: console logging was inactive. No visible crash occurred, but a clean console could not be verified.
⚠️

view run · view recording

@abdulrahuman5196

Copy link
Copy Markdown
Contributor

@MelvinBot
Can you publish the PR? I can add the required details later?

@MelvinBot
MelvinBot marked this pull request as ready for review November 17, 2026 07:46
@MelvinBot
MelvinBot requested a review from a team as a code owner November 17, 2026 07:46
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Marked the PR ready for review. You can add the remaining details later; the description and checklist are unchanged.


view run

@expensify-chore-bot
expensify-chore-bot Bot requested review from abdulrahuman5196 and removed request for a team November 17, 2026 07:46
@expensify-chore-bot

Copy link
Copy Markdown

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@expensify-chore-bot
expensify-chore-bot Bot requested review from joekaufmanexpensify and removed request for a team November 17, 2026 07:46
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T07:51:36.274726Z 138744b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@abdulrahuman5196

Copy link
Copy Markdown
Contributor

@MelvinBot could you update the test section with the below information and also check all the check boxes in authors checklist

Tests

  1. Sign in on NewDot (web and/or Android).
  2. Open workspaces/verify-domain/123456789 (unknown / non-existent domain ID).
    • Confirm a recoverable Not Found screen is shown.
  3. Open workspaces/verify-domain with no domain ID.
    • Confirm Not Found is shown.
  4. Open workspaces/verify-domain/<validDomainAccountID> for a domain you can verify.
    • Confirm the normal verify-domain UI loads.

Offline tests

N/A

QA Steps

Same as Tests.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Updated Tests, Offline tests, and QA Steps with your supplied text, and checked all PR Author Checklist boxes on your behalf. No tests were rerun.


view run

@joekaufmanexpensify

Copy link
Copy Markdown
Contributor

No product review needed.

@joekaufmanexpensify
joekaufmanexpensify removed their request for review November 17, 2026 22:08
@abdulrahuman5196

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
androidHybrid-0-Screen_Recording_2026-11-19_at_12.46.31.AM.mov
Android: mWeb Chrome
iOS: HybridApp
iosHybrid-0-Screen_Recording_2026-11-19_at_12.17.44.AM.mov
iOS: mWeb Safari
iosMWeb-0-Screen_Recording_2026-11-19_at_12.30.31.AM.mov
MacOS: Chrome / Safari
macOS-0-Screen_Recording_2026-11-18_at_9.19.04.PM.mov

@abdulrahuman5196

Copy link
Copy Markdown
Contributor

I am having setup issue with android chrome, but checked all other platform. IMO this shouldn't block the merge, do let me know otherwise.

@abdulrahuman5196 abdulrahuman5196 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @mountiny

🎀 👀 🎀
C+ Reviewed

@melvin-bot
melvin-bot Bot requested a review from mountiny November 18, 2026 20:01
@mountiny
mountiny merged commit ce578e0 into main Nov 19, 2026
55 of 57 checks passed
@mountiny
mountiny deleted the claude-guardMissingDomainParams branch November 19, 2026 00:16
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.43-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor Author

No help site update needed — this PR prevents a crash when domain verification opens without a domain ID; it adds no new workflow and leaves the documented verification steps unchanged.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.47-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.51-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.51-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants