Repository navigation
Prevent crashes on missing amount-input keyboard keys - #106653
Conversation
Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>
|
This draft uses an upstream branch because Melvin does not have push access to your fork. To copy it to your fork and push future updates, run the following in your fork checkout: git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-guardAmountEditingKeys
git checkout -b claude-guardAmountEditingKeys upstream/claude-guardAmountEditingKeys
git push -u origin claude-guardAmountEditingKeysIf an upstream remote already exists, skip the first command. You can then open a replacement PR from your fork and close this draft. |
|
🤖 Android test steps verification results: Recovered sign-in and completed workspace setup on Android native, but Require receipts opened a Control-plan upgrade gate, blocking all amount-edit tests. The original Android Chrome issue and malformed-key reproduction remain unverified.
|
|
🤖 Web test steps verification results: On dev NewDot web, Rules > Require receipts is blocked by a Control-plan upgrade gate. No upgrade or bypass was attempted; threshold interactions and malformed-key reproduction were not tested.
view run · no recording available |
|
@MelvinBot Suggest test steps for this PR. |
Suggested manual / QA stepsPrerequisite: Use a workspace admin account with Control-plan access and Rules enabled. Previous attempts were blocked by the upgrade gate.
Prioritize Chrome on Android, where the error was reported. Also check desktop Chrome/Safari; on macOS, verify Ctrl+D still deletes the character after the caret. Automated regression checksOrdinary typing does not prove the missing-key fix. Run the amount-controller regression suites and verify:
Limitation: The original keyboard/IME sequence is still unknown. Treat manual testing as regression coverage, not confirmation that the production trigger was reproduced. |
|
@MelvinBot Update description as follows: |
|
Updated the PR description with your supplied text and checklist selections. No tests were rerun. Note: step 3 retains a typo from my suggestion—Backspace between |
|
@MelvinBot Fix that typo and merge main. |
…tingKeys Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>
|
Corrected step 3: Backspace removes 3, not 2. Merged Storybook smoke test passed. Jest hit module-loading errors; lint/typecheck/compiler checks were blocked by Bun setup, and the Prettier script is unavailable. Recorded these limitations in the description. |
|
|
|
@MelvinBot Mark is ready for review. |
|
Marked Prevent crashes on missing amount-input keyboard keys ready for review. |
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
- I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots
🔲 iOS / native
14.11.2026_12.58.41_REC.mp4
🔲 iOS / Safari
14.11.2026_13.01.33_REC.mp4
🔲 MacOS / Chrome
12.11.2026_23.58.58_REC.mp4
🔲 Android / native
14.11.2026_12.50.08_REC.mp4
🎀 👀 🎀 C+ reviewed
|
🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.5.40-0 🚀
|
|
No help site update needed — this PR fixes crashes during amount entry, restoring expected behavior without adding a feature or changing any documented workflow. |




Explanation of Change
Treat missing/non-string amount-input keys as non-forward-delete events instead of calling
toLowerCase()on them. Apply the same string guard before detached-sign backspace handling, while always forwarding the event to the base controller so stale forward-delete state is cleared. Make the local event key optional.Add 19 regression cases covering missing, undefined, null, numeric, object, empty, and unidentified keys, sign preservation, and clearing a previous forward-delete flag.
AI Tests
git diff --checkand Storybook smoke test passed. After refreshing dependencies, Jest failed with ES-module loading errors, including in the two targeted amount-controller suites; no passing regression result is claimed for this merge. Lint, lint-changed, typecheck, and compiler checks were blocked by missing Bun installation setup. The Prettier script remains unavailable. Manual QA was not rerun.npm run lint, lint on all five changed files,npm run typecheck, spell-check on all five changed files, Storybook smoke test, and direct React Compiler compliance check of the changed hook. Independent staged-diff code review found no violations.lint-changedwas attempted; subsequent runs timed out fetching the base branch. Explicit changed-file lint passed after correcting the test fixtures.react-compiler-compliance-check check-changedcould not resolve the CI base branch; the direct changed-hook check passed.prettierscript. A standalone formatter check was not permitted in this environment.Fixed Issues
$ #106409
PROPOSAL: #106409 (comment)
Tests
Prerequisite: Use a workspace admin account with Control-plan access and Rules enabled. Previous attempts were blocked by the upgrade gate.
Prioritize Chrome on Android, where the error was reported. Also check desktop Chrome/Safari; on macOS, verify Ctrl+D still deletes the character after the caret.
Offline tests
same as tests.
QA Steps
same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Web verification blocked: the dev session rendered a blank page before the amount flow could be reached. This is blocker evidence, not a passing functional verification.