Skip to content

[No QA] Merge main - #106668

Merged
stephanieelliott merged 46 commits into
claude-commuterExclusionsReleases2And3from
main
Nov 12, 2026
Merged

stephanieelliott merged 46 commits into
claude-commuterExclusionsReleases2And3from
main

Conversation

@stephanieelliott

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

MelvinBot and others added 30 commits October 14, 2026 17:22
Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
…ceCurrencyGlobalCreate

Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>

# Conflicts:
#	src/pages/iou/request/step/IOURequestStepConfirmation.tsx
Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
…y correction

Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
…the extra comment

Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
…ceCurrencyGlobalCreate

Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
…ing main

Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
Deploy each PR Worker and its matching assets together from one App SHA.
Remove S3 web uploads and keep trusted deployment tooling on main.
Preserve queued push builds while canceling superseded manual builds.
Use named PR Previews under the existing pr-testing-expensify Worker.
Publish branch code and assets without per-PR Workers or zone routes.
Keep artifact validation and code/assets identity checks.
Remove unrelated generated action bundle changes from this migration.
Updated section headings for clarity and consistency, corrected minor typos, and improved formatting throughout the document.
@stephanieelliott
stephanieelliott merged commit 637df78 into claude-commuterExclusionsReleases2And3 Nov 12, 2026
133 checks passed
@melvin-bot

melvin-bot Bot commented Nov 12, 2026

Copy link
Copy Markdown

Product reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR?

cc @joekaufmanexpensify

@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and mollfpr and removed request for a team November 12, 2026 01:32
@melvin-bot

melvin-bot Bot commented Nov 12, 2026

Copy link
Copy Markdown

@mollfpr @joekaufmanexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

NOTE: It looks like docs/redirects.csv was modified in this PR. Please see this SO for special instructions on how to review changes to that file.

- Auditor
- Approve-only

People admins cannot invite someone as a Workspace admin, Card admin, People admin, or Payments admin. [Learn what each workspace role can do](/articles/new-expensify/workspaces/Understand-Workspace-Roles-and-Permissions#what-each-workspace-role-can-do).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming/style: Lowercase role names in running text; capitalize only when quoting a UI label (per HELPSITE_NAMING_CONVENTIONS.md "Roles").

Suggested change
People admins cannot invite someone as a Workspace admin, Card admin, People admin, or Payments admin. [Learn what each workspace role can do](/articles/new-expensify/workspaces/Understand-Workspace-Roles-and-Permissions#what-each-workspace-role-can-do).
People admins cannot invite someone as a workspace admin, card admin, people admin, or payments admin. [Learn what each workspace role can do](/articles/new-expensify/workspaces/Understand-Workspace-Roles-and-Permissions#what-each-workspace-role-can-do).


1. In the navigation tabs (on the left on web, on the bottom on mobile), select **Workspaces > [workspace name]**.
2. Select **Members**.
3. Select **More**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming/style: Reference the three dots menu as More (⋮) with the symbol in parentheses (per HELPSITE_NAMING_CONVENTIONS.md "Three Dots Menu").

Suggested change
3. Select **More**.
3. Select **More (⋮)**.

1. In the navigation tabs (on the left on web, on the bottom on mobile), select **Workspaces > [workspace name]**.
2. Select **Members**.
3. Select **More**.
4. Choose **Import via Spreadsheet**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming/style: Use select for activating a UI element; choose is only for decisions between options (per HELPSITE_NAMING_CONVENTIONS.md "Actions").

Suggested change
4. Choose **Import via Spreadsheet**.
4. Select **Import via Spreadsheet**.


Use the [member import template](https://docs.google.com/spreadsheets/d/19fjknN-KOS74RjXDccXZGUNTm-utdV7Gvveo5EyrJLE/edit?gid=0#gid=0) to prepare your file.

### What member fields can I import?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure: Only # and ## headings are allowed; ### is forbidden (HELP_AUTHORING_GUIDELINES.md Section 4 and the pre-publish checklist). Demote to ##.

Suggested change
### What member fields can I import?
## What member fields can I import?


## How to change a member’s role

1. In the navigation tabs (on the left on web, at the bottom on mobile), select **Workspaces > [workspace name]**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming/style: The only approved position wording is "on the bottom on mobile", not "at the bottom" (HELPSITE_NAMING_CONVENTIONS.md "Navigation Tabs").

Suggested change
1. In the navigation tabs (on the left on web, at the bottom on mobile), select **Workspaces > [workspace name]**.
1. In the navigation tabs (on the left on web, on the bottom on mobile), select **Workspaces > [workspace name]**.

4. Select **Role**.
5. Choose the new role and select **Save**.

On web, you can also hover over the member’s **Role** in the member list and select the pencil icon to change it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming/style: Name UI elements by function, not appearance — use "edit icon" instead of "pencil icon" (HELPSITE_NAMING_CONVENTIONS.md "Name UI Elements by Function").

Suggested change
On web, you can also hover over the member’s **Role** in the member list and select the pencil icon to change it.
On web, you can also hover over the member’s **Role** in the member list and select the edit icon to change it.


On web, you can also hover over the member’s **Role** in the member list and select the pencil icon to change it.

### Why the authorized payer’s role can't be changed

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure: ### headings are forbidden; only # and ## are allowed (HELP_AUTHORING_GUIDELINES.md Section 4). Demote to ##.

Suggested change
### Why the authorized payer’s role can't be changed
## Why the authorized payer’s role can't be changed


## How to remove a workspace member

1. In the navigation tabs (on the left on web, at the bottom on mobile), select **Workspaces > [workspace name]**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming/style: Use the approved wording "on the bottom on mobile", not "at the bottom" (HELPSITE_NAMING_CONVENTIONS.md "Navigation Tabs").

Suggested change
1. In the navigation tabs (on the left on web, at the bottom on mobile), select **Workspaces > [workspace name]**.
1. In the navigation tabs (on the left on web, on the bottom on mobile), select **Workspaces > [workspace name]**.


1. In the navigation tabs on the bottom, select **Workspaces > [workspace name]**.
2. Select **Members**.
3. Long press a member you want to remove and tap **Select**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming/style: Use select, never "tap" (HELPSITE_NAMING_CONVENTIONS.md "Actions").

Suggested change
3. Long press a member you want to remove and tap **Select**.
3. Long press a member you want to remove and select **Select**.

2. Select **Members**.
3. Long press a member you want to remove and tap **Select**.
4. Select the checkboxes next to the members you want to remove.
5. Tap **Selected**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming/style: Use select, never "tap" (HELPSITE_NAMING_CONVENTIONS.md "Actions").

Suggested change
5. Tap **Selected**.
5. Select **Selected**.

3. Long press a member you want to remove and tap **Select**.
4. Select the checkboxes next to the members you want to remove.
5. Tap **Selected**.
6. Choose **Remove members**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming/style: Use select for activating a UI element; choose is only for decisions between options (HELPSITE_NAMING_CONVENTIONS.md "Actions").

Suggested change
6. Choose **Remove members**.
6. Select **Remove members**.


You can filter the Members table by workspace role or approver assignment. The **Approvers** filter shows members designated as approvers, while **Approve-only** shows members assigned the Approve-only role.

1. In the navigation tabs (on the left on web, at the bottom on mobile), select **Workspaces > [workspace name]**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming/style: Use the approved wording "on the bottom on mobile", not "at the bottom" (HELPSITE_NAMING_CONVENTIONS.md "Navigation Tabs").

Suggested change
1. In the navigation tabs (on the left on web, at the bottom on mobile), select **Workspaces > [workspace name]**.
1. In the navigation tabs (on the left on web, on the bottom on mobile), select **Workspaces > [workspace name]**.


Workspace admins can set a display name for a member who has not added a name of their own. If the member has already set their name, only they can edit it.

1. In the navigation tabs (on the left on web, at the bottom on mobile), select **Workspaces > [workspace name]**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming/style: Use the approved wording "on the bottom on mobile", not "at the bottom" (HELPSITE_NAMING_CONVENTIONS.md "Navigation Tabs").

Suggested change
1. In the navigation tabs (on the left on web, at the bottom on mobile), select **Workspaces > [workspace name]**.
1. In the navigation tabs (on the left on web, on the bottom on mobile), select **Workspaces > [workspace name]**.


Workspace admins, people admins, and editors on Submit workspaces can download a CSV of workspace members.

1. In the navigation tabs (on the left on web, at the bottom on mobile), select **Workspaces > [workspace name]**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming/style: Use the approved wording "on the bottom on mobile", not "at the bottom" (HELPSITE_NAMING_CONVENTIONS.md "Navigation Tabs").

Suggested change
1. In the navigation tabs (on the left on web, at the bottom on mobile), select **Workspaces > [workspace name]**.
1. In the navigation tabs (on the left on web, on the bottom on mobile), select **Workspaces > [workspace name]**.


1. In the navigation tabs (on the left on web, at the bottom on mobile), select **Workspaces > [workspace name]**.
2. Select **Members**.
3. Select **More**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming/style: Reference the three dots menu as More (⋮) with the symbol in parentheses (HELPSITE_NAMING_CONVENTIONS.md "Three Dots Menu").

Suggested change
3. Select **More**.
3. Select **More (⋮)**.


## What settings admin roles can access

Card admins, People admins, and Payments admins have access to the workspace settings needed for their responsibilities.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming/style: Lowercase role names in running text; capitalize only when quoting a UI label (HELPSITE_NAMING_CONVENTIONS.md "Roles").

Suggested change
Card admins, People admins, and Payments admins have access to the workspace settings needed for their responsibilities.
Card admins, people admins, and payments admins have access to the workspace settings needed for their responsibilities.

| **People admin** | Members and the **Approvals** section of **Workflows** | Overview |
| **Payments admin** | The **Payments** section of **Workflows** | Overview and Members |

Other workspace settings pages are hidden for Card admins, People admins, and Payments admins.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming/style: Lowercase role names in running text (HELPSITE_NAMING_CONVENTIONS.md "Roles").

Suggested change
Other workspace settings pages are hidden for Card admins, People admins, and Payments admins.
Other workspace settings pages are hidden for card admins, people admins, and payments admins.

- Auditor
- Approve-only

People admins cannot add or remove Workspace admins, Card admins, People admins, or Payments admins, or change someone to or from one of those roles.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming/style: Lowercase role names in running text (HELPSITE_NAMING_CONVENTIONS.md "Roles").

Suggested change
People admins cannot add or remove Workspace admins, Card admins, People admins, or Payments admins, or change someone to or from one of those roles.
People admins cannot add or remove workspace admins, card admins, people admins, or payments admins, or change someone to or from one of those roles.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR splits the monolithic Managing-Workspace-Members.md (199 lines, multiple workflows) into three focused, single-workflow articles and adds a redirect for the retired page:

  • Invite-Members-to-a-Workspace.md (task) — direct invites and spreadsheet import
  • Manage-Workspace-Members-and-Access.md (task) — role changes, removal, filtering, display names, CSV export
  • Understand-Workspace-Roles-and-Permissions.md (topic) — role permission reference
  • docs/redirects.csv — redirects the old URL to the new roles article

This is a strong, well-motivated restructure that directly follows the "one primary workflow per article" principle (HELP_AUTHORING_GUIDELINES.md Section 1). The new files add internalScope, contentType, and platform metadata that the old file lacked, and they replace "Click/Go to" phrasing with the required select + bolded navigation path pattern. The main defects are a few H3 (###) headings, which violate the heading-hierarchy rule, and some naming/action wording inconsistencies.

Scores Summary

  • Readability: 9/10 — Clear, scannable, well-sequenced numbered steps; strong "Who can…" gating sections and a clean role permissions table. Separate "On web"/"On mobile" blocks for the bulk-remove flow are handled well.
  • AI Readiness: 7/10 — Excellent metadata (full internalScope with explicit exclusions, task-based titles, strong keywords) and clean cross-linking scoped to prerequisites. Dropped points for H3 headings breaking the # and ## only hierarchy (Section 4 / Section 9 checklist).
  • Style Compliance: 8/10 — Correct select/choose in most places, bolded navigation paths with lowercase [workspace name] placeholder, relative links only, proper # FAQ. Issues: a few choose/tap for UI activation, three-dots menu not using More (⋮), "at the bottom" vs the required "on the bottom on mobile", a UI element named by appearance ("pencil icon"), and some lowercase-role fixes needed in running text.

Key Findings

  • Heading hierarchy (must fix): ### What member fields can I import? in Invite-Members-to-a-Workspace.md:53 and ### Why the authorized payer's role can't be changed in Manage-Workspace-Members-and-Access.md:37. Only # and ## are allowed — promote these to ##.
  • Three dots menu: Must be Select **More (⋮)** — Invite-Members-to-a-Workspace.md:45, Manage-Workspace-Members-and-Access.md:105.
  • Action verbs: choose/tap used for activating UI where select is required — Invite-Members-to-a-Workspace.md:46, Manage-Workspace-Members-and-Access.md:67, 69, 70.
  • Navigation position wording: Standardize to the approved "on the bottom on mobile" (not "at the bottom") — Manage-Workspace-Members-and-Access.md:29, 45, 79, 89, 103.
  • Name UI by function: "pencil icon" → "edit icon" — Manage-Workspace-Members-and-Access.md:35.
  • Lowercase roles in running text — Invite-Members-to-a-Workspace.md:25, Understand-Workspace-Roles-and-Permissions.md:34, 43, 58.
  • Positive: The restructure is exactly the fix the guidelines call for; internalScope entries are exemplary (audience, covered workflows, explicit exclusions with cross-links); ownership-transfer content was correctly delegated via cross-link to keep each article single-workflow.

Recommendations

  • Convert the two ### headings to ##, keeping their task/question phrasing.
  • Apply the inline naming/action-verb suggestions (More (⋮), select, "on the bottom on mobile", "edit icon", lowercase roles).
  • Verify cross-link anchors resolve (e.g. #how-to-update-your-display-name-or-legal-name in Account-Settings.md).
  • Optional: remove trailing whitespace and normalize curly vs straight apostrophes.

Files Reviewed

  • Invite-Members-to-a-Workspace.md — New. Strong; one ### heading plus naming/action nits.
  • Manage-Workspace-Members-and-Access.md — New. Strong; one ### heading, nav-phrase, three-dots, action-verb, and UI-naming nits.
  • Understand-Workspace-Roles-and-Permissions.md — New. Nearly compliant; a few lowercase-role fixes.
  • Managing-Workspace-Members.md — Deleted. Correctly retired in favor of the split articles.
  • docs/redirects.csv — Adds a valid redirect from the old URL to the roles article.

Note: Detailed line-by-line feedback has been posted as 18 inline comments.

@github-actions github-actions Bot changed the title Merge main [No QA] Merge main Nov 12, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.40-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR already includes the workspace-member documentation updates; the remaining changes are expected-behavior bug fixes and developer tooling that don’t make existing articles inaccurate.


view run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants