Repository navigation
[No QA] Merge main - #106668
[No QA] Merge main#106668
Conversation
Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
…ceCurrencyGlobalCreate Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com> # Conflicts: # src/pages/iou/request/step/IOURequestStepConfirmation.tsx
Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
…y correction Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
…the extra comment Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
…ceCurrencyGlobalCreate Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
…ing main Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
Deploy each PR Worker and its matching assets together from one App SHA. Remove S3 web uploads and keep trusted deployment tooling on main. Preserve queued push builds while canceling superseded manual builds.
Use named PR Previews under the existing pr-testing-expensify Worker. Publish branch code and assets without per-PR Workers or zone routes. Keep artifact validation and code/assets identity checks. Remove unrelated generated action bundle changes from this migration.
…embers-and-Access.md
Updated section headings for clarity and consistency, corrected minor typos, and improved formatting throughout the document.
…derstand-Workspace-Roles-and-Permissions.md
637df78
into
claude-commuterExclusionsReleases2And3
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? |
|
@mollfpr @joekaufmanexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
| - Auditor | ||
| - Approve-only | ||
|
|
||
| People admins cannot invite someone as a Workspace admin, Card admin, People admin, or Payments admin. [Learn what each workspace role can do](/articles/new-expensify/workspaces/Understand-Workspace-Roles-and-Permissions#what-each-workspace-role-can-do). |
There was a problem hiding this comment.
Naming/style: Lowercase role names in running text; capitalize only when quoting a UI label (per HELPSITE_NAMING_CONVENTIONS.md "Roles").
| People admins cannot invite someone as a Workspace admin, Card admin, People admin, or Payments admin. [Learn what each workspace role can do](/articles/new-expensify/workspaces/Understand-Workspace-Roles-and-Permissions#what-each-workspace-role-can-do). | |
| People admins cannot invite someone as a workspace admin, card admin, people admin, or payments admin. [Learn what each workspace role can do](/articles/new-expensify/workspaces/Understand-Workspace-Roles-and-Permissions#what-each-workspace-role-can-do). |
|
|
||
| 1. In the navigation tabs (on the left on web, on the bottom on mobile), select **Workspaces > [workspace name]**. | ||
| 2. Select **Members**. | ||
| 3. Select **More**. |
There was a problem hiding this comment.
Naming/style: Reference the three dots menu as More (⋮) with the symbol in parentheses (per HELPSITE_NAMING_CONVENTIONS.md "Three Dots Menu").
| 3. Select **More**. | |
| 3. Select **More (⋮)**. |
| 1. In the navigation tabs (on the left on web, on the bottom on mobile), select **Workspaces > [workspace name]**. | ||
| 2. Select **Members**. | ||
| 3. Select **More**. | ||
| 4. Choose **Import via Spreadsheet**. |
There was a problem hiding this comment.
Naming/style: Use select for activating a UI element; choose is only for decisions between options (per HELPSITE_NAMING_CONVENTIONS.md "Actions").
| 4. Choose **Import via Spreadsheet**. | |
| 4. Select **Import via Spreadsheet**. |
|
|
||
| Use the [member import template](https://docs.google.com/spreadsheets/d/19fjknN-KOS74RjXDccXZGUNTm-utdV7Gvveo5EyrJLE/edit?gid=0#gid=0) to prepare your file. | ||
|
|
||
| ### What member fields can I import? |
There was a problem hiding this comment.
Structure: Only # and ## headings are allowed; ### is forbidden (HELP_AUTHORING_GUIDELINES.md Section 4 and the pre-publish checklist). Demote to ##.
| ### What member fields can I import? | |
| ## What member fields can I import? |
|
|
||
| ## How to change a member’s role | ||
|
|
||
| 1. In the navigation tabs (on the left on web, at the bottom on mobile), select **Workspaces > [workspace name]**. |
There was a problem hiding this comment.
Naming/style: The only approved position wording is "on the bottom on mobile", not "at the bottom" (HELPSITE_NAMING_CONVENTIONS.md "Navigation Tabs").
| 1. In the navigation tabs (on the left on web, at the bottom on mobile), select **Workspaces > [workspace name]**. | |
| 1. In the navigation tabs (on the left on web, on the bottom on mobile), select **Workspaces > [workspace name]**. |
| 4. Select **Role**. | ||
| 5. Choose the new role and select **Save**. | ||
|
|
||
| On web, you can also hover over the member’s **Role** in the member list and select the pencil icon to change it. |
There was a problem hiding this comment.
Naming/style: Name UI elements by function, not appearance — use "edit icon" instead of "pencil icon" (HELPSITE_NAMING_CONVENTIONS.md "Name UI Elements by Function").
| On web, you can also hover over the member’s **Role** in the member list and select the pencil icon to change it. | |
| On web, you can also hover over the member’s **Role** in the member list and select the edit icon to change it. |
|
|
||
| On web, you can also hover over the member’s **Role** in the member list and select the pencil icon to change it. | ||
|
|
||
| ### Why the authorized payer’s role can't be changed |
There was a problem hiding this comment.
Structure: ### headings are forbidden; only # and ## are allowed (HELP_AUTHORING_GUIDELINES.md Section 4). Demote to ##.
| ### Why the authorized payer’s role can't be changed | |
| ## Why the authorized payer’s role can't be changed |
|
|
||
| ## How to remove a workspace member | ||
|
|
||
| 1. In the navigation tabs (on the left on web, at the bottom on mobile), select **Workspaces > [workspace name]**. |
There was a problem hiding this comment.
Naming/style: Use the approved wording "on the bottom on mobile", not "at the bottom" (HELPSITE_NAMING_CONVENTIONS.md "Navigation Tabs").
| 1. In the navigation tabs (on the left on web, at the bottom on mobile), select **Workspaces > [workspace name]**. | |
| 1. In the navigation tabs (on the left on web, on the bottom on mobile), select **Workspaces > [workspace name]**. |
|
|
||
| 1. In the navigation tabs on the bottom, select **Workspaces > [workspace name]**. | ||
| 2. Select **Members**. | ||
| 3. Long press a member you want to remove and tap **Select**. |
There was a problem hiding this comment.
Naming/style: Use select, never "tap" (HELPSITE_NAMING_CONVENTIONS.md "Actions").
| 3. Long press a member you want to remove and tap **Select**. | |
| 3. Long press a member you want to remove and select **Select**. |
| 2. Select **Members**. | ||
| 3. Long press a member you want to remove and tap **Select**. | ||
| 4. Select the checkboxes next to the members you want to remove. | ||
| 5. Tap **Selected**. |
There was a problem hiding this comment.
Naming/style: Use select, never "tap" (HELPSITE_NAMING_CONVENTIONS.md "Actions").
| 5. Tap **Selected**. | |
| 5. Select **Selected**. |
| 3. Long press a member you want to remove and tap **Select**. | ||
| 4. Select the checkboxes next to the members you want to remove. | ||
| 5. Tap **Selected**. | ||
| 6. Choose **Remove members**. |
There was a problem hiding this comment.
Naming/style: Use select for activating a UI element; choose is only for decisions between options (HELPSITE_NAMING_CONVENTIONS.md "Actions").
| 6. Choose **Remove members**. | |
| 6. Select **Remove members**. |
|
|
||
| You can filter the Members table by workspace role or approver assignment. The **Approvers** filter shows members designated as approvers, while **Approve-only** shows members assigned the Approve-only role. | ||
|
|
||
| 1. In the navigation tabs (on the left on web, at the bottom on mobile), select **Workspaces > [workspace name]**. |
There was a problem hiding this comment.
Naming/style: Use the approved wording "on the bottom on mobile", not "at the bottom" (HELPSITE_NAMING_CONVENTIONS.md "Navigation Tabs").
| 1. In the navigation tabs (on the left on web, at the bottom on mobile), select **Workspaces > [workspace name]**. | |
| 1. In the navigation tabs (on the left on web, on the bottom on mobile), select **Workspaces > [workspace name]**. |
|
|
||
| Workspace admins can set a display name for a member who has not added a name of their own. If the member has already set their name, only they can edit it. | ||
|
|
||
| 1. In the navigation tabs (on the left on web, at the bottom on mobile), select **Workspaces > [workspace name]**. |
There was a problem hiding this comment.
Naming/style: Use the approved wording "on the bottom on mobile", not "at the bottom" (HELPSITE_NAMING_CONVENTIONS.md "Navigation Tabs").
| 1. In the navigation tabs (on the left on web, at the bottom on mobile), select **Workspaces > [workspace name]**. | |
| 1. In the navigation tabs (on the left on web, on the bottom on mobile), select **Workspaces > [workspace name]**. |
|
|
||
| Workspace admins, people admins, and editors on Submit workspaces can download a CSV of workspace members. | ||
|
|
||
| 1. In the navigation tabs (on the left on web, at the bottom on mobile), select **Workspaces > [workspace name]**. |
There was a problem hiding this comment.
Naming/style: Use the approved wording "on the bottom on mobile", not "at the bottom" (HELPSITE_NAMING_CONVENTIONS.md "Navigation Tabs").
| 1. In the navigation tabs (on the left on web, at the bottom on mobile), select **Workspaces > [workspace name]**. | |
| 1. In the navigation tabs (on the left on web, on the bottom on mobile), select **Workspaces > [workspace name]**. |
|
|
||
| 1. In the navigation tabs (on the left on web, at the bottom on mobile), select **Workspaces > [workspace name]**. | ||
| 2. Select **Members**. | ||
| 3. Select **More**. |
There was a problem hiding this comment.
Naming/style: Reference the three dots menu as More (⋮) with the symbol in parentheses (HELPSITE_NAMING_CONVENTIONS.md "Three Dots Menu").
| 3. Select **More**. | |
| 3. Select **More (⋮)**. |
|
|
||
| ## What settings admin roles can access | ||
|
|
||
| Card admins, People admins, and Payments admins have access to the workspace settings needed for their responsibilities. |
There was a problem hiding this comment.
Naming/style: Lowercase role names in running text; capitalize only when quoting a UI label (HELPSITE_NAMING_CONVENTIONS.md "Roles").
| Card admins, People admins, and Payments admins have access to the workspace settings needed for their responsibilities. | |
| Card admins, people admins, and payments admins have access to the workspace settings needed for their responsibilities. |
| | **People admin** | Members and the **Approvals** section of **Workflows** | Overview | | ||
| | **Payments admin** | The **Payments** section of **Workflows** | Overview and Members | | ||
|
|
||
| Other workspace settings pages are hidden for Card admins, People admins, and Payments admins. |
There was a problem hiding this comment.
Naming/style: Lowercase role names in running text (HELPSITE_NAMING_CONVENTIONS.md "Roles").
| Other workspace settings pages are hidden for Card admins, People admins, and Payments admins. | |
| Other workspace settings pages are hidden for card admins, people admins, and payments admins. |
| - Auditor | ||
| - Approve-only | ||
|
|
||
| People admins cannot add or remove Workspace admins, Card admins, People admins, or Payments admins, or change someone to or from one of those roles. |
There was a problem hiding this comment.
Naming/style: Lowercase role names in running text (HELPSITE_NAMING_CONVENTIONS.md "Roles").
| People admins cannot add or remove Workspace admins, Card admins, People admins, or Payments admins, or change someone to or from one of those roles. | |
| People admins cannot add or remove workspace admins, card admins, people admins, or payments admins, or change someone to or from one of those roles. |
HelpDot Documentation ReviewOverall AssessmentThis PR splits the monolithic
This is a strong, well-motivated restructure that directly follows the "one primary workflow per article" principle (HELP_AUTHORING_GUIDELINES.md Section 1). The new files add Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been posted as 18 inline comments. |
|
A preview of your ExpensifyHelp changes have been deployed to https://03d928fe.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.40-0 🚀
|
|
No help site update needed — this PR already includes the workspace-member documentation updates; the remaining changes are expected-behavior bug fixes and developer tooling that don’t make existing articles inaccurate. |
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari