Repository navigation
[No QA] Docs updates for E/A#105939 Document saving workspace expense drafts without reports - #106683
Conversation
Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>
|
I created this PR from an upstream branch because I do not have push access to your fork. To take ownership of the branch and push updates, run: git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-docsReportNone105939
git checkout -b claude-docsReportNone105939 upstream/claude-docsReportNone105939
git push -u origin claude-docsReportNone105939You can then close this draft and open a new PR from your fork. |
|
A preview of your ExpensifyHelp changes have been deployed to https://74d67ffe.helpdot.pages.dev ⚡️ Updated articles: |
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
|
||
| ## How to manually add an expense | ||
|
|
||
| When manually creating an expense from a workspace chat, select **Report > None**, then **Create expense**, to save it in your personal space without a report. |
There was a problem hiding this comment.
Naming violation: **Report > None** is formatted as a navigation path, but navigation paths must start with a navigation tab and chain UI navigation segments (per HELPSITE_NAMING_CONVENTIONS.md > Navigation Paths). Here None is a value chosen for the Report field, so reference it as a field/value instead.
| When manually creating an expense from a workspace chat, select **Report > None**, then **Create expense**, to save it in your personal space without a report. | |
| When manually creating an expense from a workspace chat, set the **Report** field to **None**, then select **Create expense**, to save it in your personal space without a report. |
HelpDot Documentation ReviewOverall AssessmentThis PR makes a single, small addition to Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as an inline comment. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.41-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
New feature: Report > None lets someone creating a workspace expense save it in their personal space without a report. Refactor ReportField logic to simplify report editability condition adds this action to the full-page picker as well as the beta dropdown, so the action itself is not beta-only.
Adds one sentence to the existing Track Expenses article. No existing sentence is incorrect; this update documents the new feature rather than filling an unrelated gap. No new section or FAQ is added.
The new selection handler moves the draft to personal tracking. Only the dropdown presentation is beta-gated.
AI Tests
git diff --check --cached: passed.npm run lint-changed: passed; no lintable files changed.npm run spell-changed -- <article>: completed with zero files checked because article markdown is excluded by the spelling configuration.Fixed Issues
$ #105939
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validates your changed worked.
Offline tests
Not applicable: article text only.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Verified on dev NewDot web: selecting None changed the draft recipient to personal space; the confirmation button read Create expense. The expense was not saved.
@DylanDylann, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.