Skip to content

[No QA] Docs updates for E/A#105939 Document saving workspace expense drafts without reports - #106683

Merged
stephanieelliott merged 1 commit into
mainfrom
claude-docsReportNone105939
Nov 16, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
claude-docsReportNone105939

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

New feature: Report > None lets someone creating a workspace expense save it in their personal space without a report. Refactor ReportField logic to simplify report editability condition adds this action to the full-page picker as well as the beta dropdown, so the action itself is not beta-only.

Adds one sentence to the existing Track Expenses article. No existing sentence is incorrect; this update documents the new feature rather than filling an unrelated gap. No new section or FAQ is added.

The new selection handler moves the draft to personal tracking. Only the dropdown presentation is beta-gated.

AI Tests

  • git diff --check --cached: passed.
  • npm run lint-changed: passed; no lintable files changed.
  • npm run spell-changed -- <article>: completed with zero files checked because article markdown is excluded by the spelling configuration.
  • Documentation-only change: no application code, routing, or configuration changes; application test bundles are not applicable.
  • Reviewed the added sentence against all three HelpDot governance files and the inline reviewer's rules; no violations found.

Fixed Issues

$ #105939
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

Not applicable: article text only.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Verified on dev NewDot web: selecting None changed the draft recipient to personal space; the confirmation button read Create expense. The expense was not saved.

Step Status
Exact labels ✅ Report, None
Personal tracking ✅ Recipient changed to personal space; confirmation button was Create expense
Unsaved personal expense draft after selecting None

@DylanDylann, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team November 12, 2026 08:46
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Nov 12, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch because I do not have push access to your fork. To take ownership of the branch and push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-docsReportNone105939
git checkout -b claude-docsReportNone105939 upstream/claude-docsReportNone105939
git push -u origin claude-docsReportNone105939

You can then close this draft and open a new PR from your fork.

@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://74d67ffe.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott
stephanieelliott marked this pull request as ready for review November 16, 2026 23:02
@stephanieelliott
stephanieelliott self-requested a review as a code owner November 16, 2026 23:02
@expensify-chore-bot

Copy link
Copy Markdown

Product reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR?

cc @flaviadefaria

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T23:26:04.056052Z 848928b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@expensify-chore-bot
expensify-chore-bot Bot requested review from flaviadefaria and removed request for a team November 16, 2026 23:03

## How to manually add an expense

When manually creating an expense from a workspace chat, select **Report > None**, then **Create expense**, to save it in your personal space without a report.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming violation: **Report > None** is formatted as a navigation path, but navigation paths must start with a navigation tab and chain UI navigation segments (per HELPSITE_NAMING_CONVENTIONS.md > Navigation Paths). Here None is a value chosen for the Report field, so reference it as a field/value instead.

Suggested change
When manually creating an expense from a workspace chat, select **Report > None**, then **Create expense**, to save it in your personal space without a report.
When manually creating an expense from a workspace chat, set the **Report** field to **None**, then select **Create expense**, to save it in your personal space without a report.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a single, small addition to docs/articles/new-expensify/reports-and-expenses/Track-Expenses.md. One explanatory sentence is inserted under the existing ## How to manually add an expense heading, clarifying that when creating an expense from a workspace chat, selecting Report > None keeps the expense in personal space without a report. No structural, metadata, or heading changes are proposed. This review scores only the added line.

Scores Summary

  • Readability: 7/10 - The sentence is clear and benefit-focused ("to save it in your personal space without a report"), but it is slightly overloaded with two comma-separated clauses and an embedded navigation path, making it a little dense to scan.
  • AI Readiness: 6/10 - Uses the UI-exact action label and ties to a real search intent (saving an expense without a report). However, it is placed as a floating sentence directly under a heading and before the numbered steps, rather than integrated into the procedural flow, which weakens retrieval structure. No metadata or heading updates accompany it.
  • Style Compliance: 6/10 - Correctly uses select, bolds UI labels, and uses lowercase generic terms ("expense," "report," "workspace chat"). Two concerns against HELPSITE_NAMING_CONVENTIONS.md: (1) "personal space" is not an established UI/product term and may read as invented phrasing; and (2) the construction "select Report > None, then Create expense" mixes a navigation-path-style arrow (reserved for navigation tab paths) with a button action in a single run-on instruction, rather than following the clean path/step conventions.

Key Findings

  • Positive: The addition fills a genuine gap (how to keep a manually created expense off a report) and correctly applies select plus bold UI labels.
  • Concern: "personal space" should be verified against src/languages/en.ts and the production UI; if it is not the exact product term, replace it with the exact label.
  • Concern: Combining **Report > None** (arrow syntax) with then **Create expense** conflates a field selection with a button action. Per the naming conventions, the > arrow is reserved for navigation tab paths; a field-value selection plus a button press is cleaner as a short step.
  • Minor: The sentence sits between the heading and the existing mobile/desktop numbered steps, slightly interrupting the established On mobile / On desktop structure of this section.

Recommendations

  • Verify "personal space" against the live UI and en.ts; substitute the exact term if it differs.
  • Reword to avoid the arrow syntax for a field value, for example: "When creating an expense from a workspace chat, set the Report field to None before you select Create expense to keep the expense off a report."
  • Consider whether the clarification belongs as a short note after the numbered steps (consistent with the existing 💡 Note pattern in this article) rather than as a lead-in sentence.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Track-Expenses.md - One sentence added under ## How to manually add an expense; functionally useful but needs terminology verification and minor rewording for style compliance.

Note: Detailed line-by-line feedback has been provided as an inline comment.

@stephanieelliott
stephanieelliott merged commit 535e640 into main Nov 16, 2026
26 of 28 checks passed
@stephanieelliott
stephanieelliott deleted the claude-docsReportNone105939 branch November 16, 2026 23:06
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.41-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants