Repository navigation
[No QA] Docs updates for E/A#106369 Document inline editing of distance tax reclaimable amounts - #106684
Conversation
Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://f9732e3a.helpdot.pages.dev ⚡️ Updated articles: |
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
| 5. Select **Save**. | ||
|
|
||
| On the web, you can also edit a rate's **Name** or **Rate** directly from the table. Hover over the value and click the pencil icon that appears to edit it inline. | ||
| On web with a wide screen, you can also edit a rate's **Name**, **Rate**, or **Tax reclaimable on** amount (if enabled) directly from the table. Hover over the value and select the **Edit** icon to edit it inline. |
There was a problem hiding this comment.
Naming violation: Per the "Name UI Elements by Function" rule in HELPSITE_NAMING_CONVENTIONS.md, function-named icons (e.g. "Search icon", "Delete icon") are written in plain text, not bolded like a button label. "Edit icon" bolds the icon as if it were a button. Unbold it to match the convention.
| On web with a wide screen, you can also edit a rate's **Name**, **Rate**, or **Tax reclaimable on** amount (if enabled) directly from the table. Hover over the value and select the **Edit** icon to edit it inline. | |
| On web with a wide screen, you can also edit a rate's **Name**, **Rate**, or **Tax reclaimable on** amount (if enabled) directly from the table. Hover over the value and select the Edit icon to edit it inline. |
HelpDot Documentation ReviewOverall AssessmentThis PR makes a single-sentence edit to the inline-editing paragraph in Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.41-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
New feature: inline editing of Tax reclaimable on amounts in the wide web distance-rates table, introduced by Allow inline editing of distance tax reclaimable amounts.
Update only the existing inline-edit paragraph in Set Distance Rates to include the new editable amount. No new sections or FAQs. This qualifies as a new user-facing editing workflow, not an article-gap correction: the existing Name/Rate instructions remain valid. The feature is not beta-gated; workspace tax settings and write permissions still apply.
AI Tests
npm run lint-changed: passed; no lintable files changed.npm run spell-changed: passed, one file checked with no spelling issues.git diff --cached --check: passed.Fixed Issues
$ #106369
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
Offline tests
Not applicable: documentation-only wording change.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
UI terminology verification only; initial navigation and missing-tax-data blockers were resolved. The hover control remained inaccessible to activation.
Created from an upstream branch because MelvinBot cannot push to the contributor's fork. To copy it to your fork:
@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.