Skip to content

[No QA] Docs updates for E/A#106369 Document inline editing of distance tax reclaimable amounts - #106684

Merged
stephanieelliott merged 1 commit into
mainfrom
claude-docs106369-inlineDistanceTax
Nov 16, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
claude-docs106369-inlineDistanceTax

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

New feature: inline editing of Tax reclaimable on amounts in the wide web distance-rates table, introduced by Allow inline editing of distance tax reclaimable amounts.

Update only the existing inline-edit paragraph in Set Distance Rates to include the new editable amount. No new sections or FAQs. This qualifies as a new user-facing editing workflow, not an article-gap correction: the existing Name/Rate instructions remain valid. The feature is not beta-gated; workspace tax settings and write permissions still apply.

AI Tests

  • npm run lint-changed: passed; no lintable files changed.
  • npm run spell-changed: passed, one file checked with no spelling issues.
  • git diff --cached --check: passed.
  • Staged-diff code and HelpDot governance review: no violations.
  • Docs-only prose edit: app-code test suites and docs-route generation are not applicable. No runtime code or routes changed.
  • Live web UI confirmed Name, Rate, Tax reclaimable on, and the accessible Edit control. Inline hover activation could not be verified; the details-page amount editor opened successfully. No complete functional-test pass is claimed.

Fixed Issues

$ #106369
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".

  • Verify that no errors appear in the JS console

Offline tests

Not applicable: documentation-only wording change.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

UI terminology verification only; initial navigation and missing-tax-data blockers were resolved. The hover control remained inaccessible to activation.

Initial navigation verification blocker Distance rates before assigning tax Distance rates with Tax reclaimable on column Tax reclaimable on editor

Created from an upstream branch because MelvinBot cannot push to the contributor's fork. To copy it to your fork:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-docs106369-inlineDistanceTax
git checkout -b claude-docs106369-inlineDistanceTax upstream/claude-docs106369-inlineDistanceTax
git push -u origin claude-docs106369-inlineDistanceTax

@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team November 12, 2026 08:53
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Nov 12, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://f9732e3a.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott
stephanieelliott requested review from stephanieelliott and removed request for stephanieelliott November 14, 2026 03:33
@stephanieelliott
stephanieelliott marked this pull request as ready for review November 16, 2026 23:19
@stephanieelliott
stephanieelliott self-requested a review as a code owner November 16, 2026 23:19
@expensify-chore-bot

Copy link
Copy Markdown

Product reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR?

cc @garrettmknight

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T23:38:38.324099Z 393d383 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@expensify-chore-bot
expensify-chore-bot Bot requested review from garrettmknight and removed request for a team November 16, 2026 23:19
5. Select **Save**.

On the web, you can also edit a rate's **Name** or **Rate** directly from the table. Hover over the value and click the pencil icon that appears to edit it inline.
On web with a wide screen, you can also edit a rate's **Name**, **Rate**, or **Tax reclaimable on** amount (if enabled) directly from the table. Hover over the value and select the **Edit** icon to edit it inline.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming violation: Per the "Name UI Elements by Function" rule in HELPSITE_NAMING_CONVENTIONS.md, function-named icons (e.g. "Search icon", "Delete icon") are written in plain text, not bolded like a button label. "Edit icon" bolds the icon as if it were a button. Unbold it to match the convention.

Suggested change
On web with a wide screen, you can also edit a rate's **Name**, **Rate**, or **Tax reclaimable on** amount (if enabled) directly from the table. Hover over the value and select the **Edit** icon to edit it inline.
On web with a wide screen, you can also edit a rate's **Name**, **Rate**, or **Tax reclaimable on** amount (if enabled) directly from the table. Hover over the value and select the Edit icon to edit it inline.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a single-sentence edit to the inline-editing paragraph in Set-distance-rates.md, documenting that the Tax reclaimable on amount can now be edited inline in the wide-screen web distance-rates table. The change is tightly scoped to the new feature and simultaneously corrects two pre-existing style violations in the same sentence. It adds no new sections, headings, metadata, or FAQs, which is appropriate since the existing workflow remains valid.

Scores Summary

  • Readability: 9/10 - The revised sentence is clear, scannable, and correctly scopes the behavior to "web with a wide screen." Labels are bolded consistently. Minor: the sentence is now slightly denser with the added "(if enabled)" qualifier, but it remains easy to follow.
  • AI Readiness: 8/10 - The exact feature/column name Tax reclaimable on is used verbatim, improving retrieval precision. The edit touches only body prose (no headings/metadata in the diff), so there is limited surface to score here; nothing in the change degrades AI readiness.
  • Style Compliance: 9/10 - Strong. The change replaces "click the pencil icon" with "select the Edit icon," fixing both the prohibited "click" verb and the look-based icon naming (naming it by function per the conventions). It also corrects "On the web" to "web." Remaining minor consideration: "Hover over the value" uses a mouse-specific verb, but this is inherent to the wide-web-only inline interaction and the sentence is already platform-scoped.

Key Findings

  • Corrects two pre-existing violations in the edited sentence: "click" → "select," and "pencil icon" → "Edit icon" (named by function).
  • Uses the exact UI label Tax reclaimable on, matching the column terminology used elsewhere in the article and confirmed via UI verification in the PR description.
  • Properly scopes the feature to web wide-screen and fixes the "On the web" → "web" phrasing.
  • Change is minimal and single-workflow, consistent with "update only the existing paragraph" intent. No scope creep.
  • One naming nit (posted inline): per "Name UI Elements by Function," function-named icons ("Search icon," "Delete icon") are written in plain text, not bolded like a button label — so "Edit icon" should be unbolded to "the Edit icon."
  • "Hover over the value" remains a mouse-centric instruction, but acceptable given the interaction is web/wide-screen only.

Recommendations

  • No blocking issues. Optional: unbold "Edit" icon per the inline comment to match the function-named-icon convention.
  • Optional: confirm whether "Edit icon" is the exact accessible control name in the UI (the PR notes hover activation could not be fully verified); if the UI exposes a different accessible label, match it exactly.
  • Optional: the PR description's Tests/QA sections still contain TODO placeholders for the human co-author to complete before marking ready for review.

Files Reviewed

  • docs/articles/new-expensify/workspaces/Set-distance-rates.md - One-line prose edit; compliant with governance and improves on the prior wording. Approve.

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott
stephanieelliott merged commit 51fc66d into main Nov 16, 2026
26 of 27 checks passed
@stephanieelliott
stephanieelliott deleted the claude-docs106369-inlineDistanceTax branch November 16, 2026 23:22
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.41-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants