Repository navigation
Fix trip Total changing to 0 after opening and closing the trip room - #106686
4 commits merged into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da1734f005
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
@suneox can you reply on the codex comment as well? #106686 (comment) |
104c34d
…m-fare Fix trip Total changing to 0 after opening and closing the trip room
|
I think this is deployed to staging now. Something funky happened, though, and botify tried to leave a comment on this but failed. |
Explanation of Change
The trip row in Spend > Trips now reads its Total from the trip fare (
totalFare) instead of the trip room'stotal, which opening the room overwrites with 0. It falls back tototalwhen the trip has no payload.Fixed Issues
$ #105339
PROPOSAL: #105339 (comment)
Tests
travelApprovalin Account > Troubleshoot > Beta overridesOffline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
az_recorder_20261113_151722.1.mp4
Android: mWeb Chrome
az_recorder_20261113_151722.mp4
iOS: Native
Screen.Recording.iPhone.17.Pro.13-11-2026.at.15.20.28.4.mp4
iOS: mWeb Safari
Screen.Recording.iPhone.17.Pro.13-11-2026.at.15.18.57.3.mp4
MacOS: Chrome / Safari
CleanShot.2026-11-13.at.15.15.20.2.mp4