Repository navigation
Remove useOnyx loading status reads from domain pages - #106692
VickyStash wants to merge 2 commits into
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@nkdengineer Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No product review needed. |
|
@nkdengineer can you prioritize this review please? |
|
Will review it today. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-11-13.at.13.42.27.movAndroid: mWeb ChromeScreen.Recording.2026-11-13.at.13.43.02.moviOS: HybridAppScreen.Recording.2026-11-13.at.13.39.46.moviOS: mWeb SafariScreen.Recording.2026-11-13.at.13.41.15.movMacOS: Chrome / SafariScreen.Recording.2026-11-13.at.13.06.12.mov |
…atus-pt4 # Conflicts: # config/oxlint/oxlint.seatbelt.tsv
Explanation of Change
This continues the cleanup from #106374. This part covers the domain pages.
Once the app has started,
useOnyxonly returnsloadingwhen a key has nothing in the cache yet and anOnyx.mergefor it hasn't been applied. None of these pages can run into that:isLoadingflag still shows the spinner while it loads.So I removed the loading checks, the metadata variables, and the code that only ran while loading. I also removed the
DomainNameOrNotFoundWrapperloading tests, since that state no longer exists.FullScreenLoadingIndicatorTestalready covers the loader's default "Go back" button.Fixed Issues
$ #104583
PROPOSAL:
Tests
/domain/<domain ID>/saml/verifiedand verify the "Domain verified" page shows. For an unverified domain, open the same URL and verify you're sent to the Verify domain page.Note: I wasn't able to test step 4 in local setup as I has access to domains with multiple admins only
Offline tests
Same, as in Tests section
QA Steps
Same, as in Tests section
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Note: I've skipped SAML related steps in recordings as it may have secret data. But I've tested it locally
Android: Native
android.mp4
iOS: Native
ios.mov
MacOS: Chrome / Safari
web.mp4