Skip to content

Remove useOnyx loading status reads from domain pages - #106692

Open
VickyStash wants to merge 2 commits into
Expensify:mainfrom
callstack-internal:VickyStash/refactor/104583-workspace-onyx-status-pt4
Open

VickyStash wants to merge 2 commits into
Expensify:mainfrom
callstack-internal:VickyStash/refactor/104583-workspace-onyx-status-pt4

Conversation

@VickyStash

@VickyStash VickyStash commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

This continues the cleanup from #106374. This part covers the domain pages.

Once the app has started, useOnyx only returns loading when a key has nothing in the cache yet and an Onyx.merge for it hasn't been applied. None of these pages can run into that:

  • All of them read the domain. They only open for a domain that's already in Onyx: from the Domains list, from another domain page, or after the add domain page finds the new domain in Onyx. Opening the domain page doesn't write anything optimistically, and the actions that change a domain run on pages that already show it.
  • The SAML page also reads the domain member settings. Those are only merged by actions on the domain pages, after the settings have loaded.
  • The SAML configuration details read the SAML metadata. It's fetched in an effect after the first render, and the existing isLoading flag still shows the spinner while it loads.

So I removed the loading checks, the metadata variables, and the code that only ran while loading. I also removed the DomainNameOrNotFoundWrapper loading tests, since that state no longer exists. FullScreenLoadingIndicatorTest already covers the loader's default "Go back" button.

Fixed Issues

$ #104583
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console
  1. As an admin of a verified domain, go to Workspaces > Domains and open the domain. Verify the domain page opens.
  2. Press Groups and verify it opens.
  3. Press SAML. With SAML enabled, verify the configuration details load. For an unverified domain, press SAML > Verify domain and verify the TXT record shows.
  4. Go to Admins, open your admin details while you're the only admin, and press Reset domain. Verify the page shows the domain name.
  5. For a verified domain, open /domain/<domain ID>/saml/verified and verify the "Domain verified" page shows. For an unverified domain, open the same URL and verify you're sent to the Verify domain page.

Note: I wasn't able to test step 4 in local setup as I has access to domains with multiple admins only

Offline tests

Same, as in Tests section

QA Steps

Same, as in Tests section

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Note: I've skipped SAML related steps in recordings as it may have secret data. But I've tested it locally

Android: Native
android.mp4
iOS: Native
ios.mov
MacOS: Chrome / Safari
web.mp4

@codecov

codecov Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/pages/domain/BaseVerifyDomainPage.tsx 93.25% <100.00%> (-0.08%) ⬇️
src/pages/domain/DomainNameOrNotFoundWrapper.tsx 100.00% <100.00%> (ø)
src/pages/domain/DomainNotFoundPageWrapper.tsx 88.88% <100.00%> (+2.52%) ⬆️
src/pages/domain/DomainSamlPage.tsx 88.88% <100.00%> (+1.65%) ⬆️
src/pages/domain/BaseDomainVerifiedPage.tsx 0.00% <0.00%> (ø)
src/pages/domain/DomainAddedPage.tsx 0.00% <0.00%> (ø)
...in/Saml/SamlConfigurationDetailsSectionContent.tsx 0.00% <0.00%> (ø)
src/pages/domain/DomainInitialPage.tsx 0.00% <0.00%> (ø)
src/pages/domain/DomainResetPage.tsx 0.00% <0.00%> (ø)
... and 10 files with indirect coverage changes

@VickyStash
VickyStash marked this pull request as ready for review November 12, 2026 12:57
@VickyStash
VickyStash requested review from a team as code owners November 12, 2026 12:57
@melvin-bot
melvin-bot Bot requested review from nkdengineer and removed request for a team November 12, 2026 12:57
@melvin-bot

melvin-bot Bot commented Nov 12, 2026

Copy link
Copy Markdown

@nkdengineer Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team November 12, 2026 12:58
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-12T13:14:21.193140Z
We couldn’t complete this review. Comment @codex review to try again.
e7a1f19 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@joekaufmanexpensify

Copy link
Copy Markdown
Contributor

No product review needed.

@joekaufmanexpensify
joekaufmanexpensify removed their request for review November 12, 2026 21:18
@mountiny

Copy link
Copy Markdown
Contributor

@nkdengineer can you prioritize this review please?

@nkdengineer

Copy link
Copy Markdown
Contributor

Will review it today.

@nkdengineer

nkdengineer commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-11-13.at.13.42.27.mov
Android: mWeb Chrome
Screen.Recording.2026-11-13.at.13.43.02.mov
iOS: HybridApp
Screen.Recording.2026-11-13.at.13.39.46.mov
iOS: mWeb Safari
Screen.Recording.2026-11-13.at.13.41.15.mov
MacOS: Chrome / Safari
Screen.Recording.2026-11-13.at.13.06.12.mov

@nkdengineer nkdengineer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melvin-bot
melvin-bot Bot requested a review from mountiny November 13, 2026 06:46
mountiny
mountiny previously approved these changes Nov 13, 2026

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts

…atus-pt4

# Conflicts:
#	config/oxlint/oxlint.seatbelt.tsv

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants