Repository navigation
[Insights polish] Details RHP: Fix receipt preview, offline icon and stale rows - #106719
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
dylanexpensify
left a comment
There was a problem hiding this comment.
Looks good from a product perspective 👍
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-11-13.at.00.20.03.movAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-11-13.at.00.11.32.movScreen.Recording.2026-11-13.at.00.11.51.movScreen.Recording.2026-11-13.at.00.12.48.mov |
|
🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.5.40-0 🚀
|
|
No help site update needed — this PR restores expected receipt previews, offline icon rendering, and expense-list updates without introducing a new workflow or making existing article text incorrect. |
Explanation of Change
Fixes a few issues in the Insights details page opened from a chart point:
receiptis added to OnyxsnapshotMergeKeys. Snapshot merges only copy fields that already exist on the snapshot entry and an expense created without a receipt has noreceiptfield, so a newly added receipt never reached the rows.Fixed Issues
$ #106531
$ #106523
$ #106521
$ #106520
PROPOSAL: N/A
Tests
Precondition:
insightsAIbeta enabled, a workspace with expenses in the selected period.Receipt hover preview (desktop web):
Adding a receipt:
Changing the date:
Offline tests
Offline icon (iOS and Android):
Adding a receipt offline:
QA Steps
Same as tests and offline tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
iOS: Native
Simulator.Screen.Recording.-.iPhone.17.-.2026-11-12.at.14.41.33.mov
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-11-12.o.14.32.00.mov