Repository navigation
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@codex please review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0b0dacda8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex please review again |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3921c2dd02
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@ikevin127 C+ review not needed, please ignore, @twisterdotcom Vit will review |
…bels-items-components
# Conflicts: # src/CONST/SENTRY_LABEL.ts
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.38-0 🚀
|
|
No help site update needed — this PR only adds internal Sentry tracking labels and related developer guidance, without changing user-facing features, workflows, or documented behavior. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.39-2 🚀
|
Explanation of Change
Adds
sentryLabels fromCONST.SENTRY_LABELto menu, dropdown and tab items in shared components and hooks (Search bulk actions, report selection menus, SettlementButton and Pay/Approve menus, workspace/domain list menus, avatar, video, onboarding help). Lint can't check labels passed in data objects. Labels follow the updated two/three-part rules inSENTRY_LABEL.mdfrom #106727.Fixed Issues
$ #105523
PROPOSAL: N/A
Tests
document.querySelectorAll('[data-sentry-label]')in the console)data-sentry-label, e.g.Search-BulkActionsHold,Search-BulkActionsDeletedata-sentry-labelstarting withSettlementButton-PaymentMenu-(e.g.SettlementButton-PaymentMenu-PayElsewhere)WorkspaceList-ThreeDotMenuGoToWorkspaceOffline tests
N/A, the change only adds labels.
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari