Repository navigation
Conversation
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1af175df3d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…de-to-keep-navigation-handling-in-the-UI-components
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-11-15.at.14.11.05.moviOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-11-15.at.14.08.26.mov |
…de-to-keep-navigation-handling-in-the-UI-components
|
🚧 Gonals has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.5.41-0 🚀
|
|
No help site update needed — this PR only refactors internal distance-expense handling without changing user-facing workflows, labels, or behavior, so no existing article becomes inaccurate. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Part of #84631, which moves navigation decisions out of the expense actions and into the screens that navigate. This PR changes no behavior.
createDistanceRequestbuilt a distance expense, sent it, and returned{iouReport, chatReportID, transactionID}so its callers knew which chat to open, which expense to highlight, and which report to add the next duplicate to. It was one of the 12 actions the guard test lists as still returning data.The action is split in two.
planDistanceRequestbuilds the request and its optimistic data, sends nothing, and returns the result.commitDistanceRequesttakes that result and does the rest of what the old action did, in the same order and under the same conditions: the sound, the highlight for a report going from one expense to two, the request itself, and the "Expense added" message.createDistanceRequestis deleted.Callers read the IDs from the plan. The confirmation page (
useDistanceSubmission), the distance step when confirmation is skipped (handleMoneyRequestStepDistanceNavigation), and duplicating a distance expense (createExpenseByType) each build the plan, commit it straight away, and take the chat and transaction IDs from it. The duplicate loops still get the expense report and transaction ID back and use them as before.The write wait moved to the commit.
writeBarrierused to be part of the request info. It is now the second argument ofcommitDistanceRequest, since it controls when the request is sent, not what is in it. The confirmation page passes the same barrier as before, duplicating passes on its caller's barrier as the old code did, and the distance step still passes none.The plan no longer changes its input. The old action overwrote
transactionParams.commenton the object it was given with the parsed comment. The planner keeps the parsed comment to itself. No caller reused that object, so nothing visible changes.The guard test is updated.
createDistanceRequestis off the list of actions that still return data, which is down to 11.planDistanceRequestis declared as a helper that may return a value, since it writes nothing.Fixed Issues
$ #84631
PROPOSAL: #84631 (comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-11-12.at.6.15.57.PM.mov