Repository navigation
[Payment due @ZhenjaHorbach] [Wise][Release 1] UI - Update Dismiss Banner Entry Trigger - #106737
Conversation
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 29bd7e0671
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (hasStartedWiseOnboarding(bankAccountList)) { | ||
| return undefined; |
There was a problem hiding this comment.
Ignore entry-click dismissals from the old trigger
For users who pressed Get started before this version and backed out before saving, the old handler has already persisted both banner entries with dismissedMethod: 'click'. Although this new gate will now find their eligible account, WalletWiseGlobalReimbursementsBanner.tsx:23-35 and WorkspaceWiseGlobalReimbursementsBanner.tsx:31-45 still treat any persisted entry as dismissed, and a repo-wide search shows no reset or migration for these names. Those existing users therefore still never see either banner; ignore or clear legacy click entries while retaining explicit x dismissals.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Not addressing this one: the feature is behind the WISE_REIMBURSEMENTS beta, so we don’t need to migrate dismissals saved by the old trigger. QA can use a fresh account or clear nvp_dismissedProductTraining.
|
🚧 joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Not a huge deal, but I feel like the removal of the banner looks kind of abrupt/tilted on the page when we do it. I wonder if it would be better to hold off on removing it until we close the right-hand pane. It might fit in more naturally with the transition there. Thoughts? 2026-11-12_15-44-02.mp4 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-11-13.at.11.09.50.movAndroid: mWeb ChromeScreen.Recording.2026-11-13.at.11.09.50.moviOS: HybridAppScreen.Recording.2026-11-13.at.11.09.50.moviOS: mWeb SafariScreen.Recording.2026-11-13.at.11.09.50.movMacOS: Chrome / SafariScreen.Recording.2026-11-13.at.10.56.26.movScreen.Recording.2026-11-13.at.10.53.14.mov |
|
Not sure if we need to show a banner when the reimbursement account has a deleted status before a BE response Screen.Recording.2026-11-13.at.10.50.25.mov |
|
But overall changes look good! |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@joekaufmanexpensify @ZhenjaHorbach both issues should be fixed now, ready for another look :) |
|
🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🎯 @ZhenjaHorbach, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Working well, thank you!
af95b46
| * so changes made from the RHP show once it closes instead of shifting the layout visible beside it. | ||
| * Only primitives are accepted, since a value rebuilt on every render would never match the stored one and would set state on every render. | ||
| */ | ||
| function useDeferUntilScreenRevealed<TValue extends Primitive>(value: TValue): TValue { |
There was a problem hiding this comment.
@WojtekBoman is this a new pattern or could this hook be used elsewhere? curious that we dont have similar behavior in app already
There was a problem hiding this comment.
It’s a new pattern. Usually we want the screen next to the RHP to update live, so this hasn’t come up much. Here, saving the onboarding removes the banner, which makes the page jump while the RHP is still open. The hook keeps the old value until the RHP closes. It’s generic, so it could be reused if the same case comes up somewhere else :)
grgia
left a comment
There was a problem hiding this comment.
LGTM, comment non-blocking
|
🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.5.40-0 🚀
|
|
No help site update needed — this PR fixes premature dismissal of onboarding banners for the still-beta-gated Wise reimbursements feature, without adding a public workflow or making existing article text incorrect. |
cc: @ZhenjaHorbach @grgia
Explanation of Change
The Wise intro page dismissed the Wallet and Workspace Wise banners for good on Get started, so users who left before saving had no way back. Now the button no longer dismisses them. Both banners hide once any bank account has Wise as its provider, which the server sets on the first saved onboarding page, when Wallet starts offering to continue (
hasStartedWiseOnboardinginBankAccountUtils).wise-banner-693598.mp4
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/693598
PROPOSAL:
Tests
Prerequisites: an account with the Wise reimbursements beta, a verified (open) USD business bank account with no Wise setup, and the Wise banners not dismissed yet.
Leaving the intro page without saving keeps the banner
Saving the first onboarding page hides both banners
Dismissing the banner still works
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari