Skip to content

[Payment due @ZhenjaHorbach] [Wise][Release 1] UI - Update Dismiss Banner Entry Trigger - #106737

Merged
grgia merged 7 commits into
Expensify:mainfrom
software-mansion-labs:wojtekboman/keep-wise-banner-until-onboarding-saved
Nov 16, 2026
Merged

grgia merged 7 commits into
Expensify:mainfrom
software-mansion-labs:wojtekboman/keep-wise-banner-until-onboarding-saved

Conversation

@WojtekBoman

@WojtekBoman WojtekBoman commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

cc: @ZhenjaHorbach @grgia

Explanation of Change

The Wise intro page dismissed the Wallet and Workspace Wise banners for good on Get started, so users who left before saving had no way back. Now the button no longer dismisses them. Both banners hide once any bank account has Wise as its provider, which the server sets on the first saved onboarding page, when Wallet starts offering to continue (hasStartedWiseOnboarding in BankAccountUtils).

wise-banner-693598.mp4

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/693598
PROPOSAL:

Tests

Prerequisites: an account with the Wise reimbursements beta, a verified (open) USD business bank account with no Wise setup, and the Wise banners not dismissed yet.

Leaving the intro page without saving keeps the banner

  1. Navigate to Settings > Wallet
  2. Verify that the Wise global reimbursements banner is shown
  3. Click Get started on the banner, then click Get started on the intro page
  4. Go back from the first onboarding page without saving it, then return to Settings > Wallet
  5. Verify that the Wise banner is still shown

Saving the first onboarding page hides both banners

  1. Navigate to Settings > Wallet and click Get started on the Wise banner, then Get started on the intro page
  2. Fill in the first onboarding page and save it
  3. Go back to Settings > Wallet
  4. Verify that the Wise banner is hidden and the bank account shows the option to continue the Wise setup
  5. Navigate to Workspaces > a workspace that reimburses via Expensify from that bank account > Workflows
  6. Verify that the Wise banner is hidden there too

Dismissing the banner still works

  1. With a fresh account matching the prerequisites, navigate to Settings > Wallet
  2. Click the close (X) button on the Wise banner
  3. Reload the page
  4. Verify that the Wise banner stays hidden
  • Verify that no errors appear in the JS console

Offline tests

  1. With an account matching the prerequisites, navigate to Settings > Wallet and go offline
  2. Click Get started on the Wise banner, then Get started on the intro page, and go back to Settings > Wallet
  3. Verify that the Wise banner is still shown
  4. Go online, start the onboarding again, save the first onboarding page, and return to Settings > Wallet
  5. Verify that the Wise banner is hidden once the save request completes

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@WojtekBoman WojtekBoman changed the title Keep the Wise banners until onboarding is saved [Wise][Release 1] UI - Update Dismiss Banner Entry Trigger Nov 12, 2026
@WojtekBoman
WojtekBoman marked this pull request as ready for review November 12, 2026 15:55
@WojtekBoman
WojtekBoman requested review from a team as code owners November 12, 2026 15:55
@melvin-bot
melvin-bot Bot requested review from ZhenjaHorbach and removed request for a team November 12, 2026 15:55
@melvin-bot

melvin-bot Bot commented Nov 12, 2026

Copy link
Copy Markdown

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from twisterdotcom and removed request for a team November 12, 2026 15:55
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T16:17:07.189532Z 29bd7e0 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 29bd7e0671

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +310 to +311
if (hasStartedWiseOnboarding(bankAccountList)) {
return undefined;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Ignore entry-click dismissals from the old trigger

For users who pressed Get started before this version and backed out before saving, the old handler has already persisted both banner entries with dismissedMethod: 'click'. Although this new gate will now find their eligible account, WalletWiseGlobalReimbursementsBanner.tsx:23-35 and WorkspaceWiseGlobalReimbursementsBanner.tsx:31-45 still treat any persisted entry as dismissed, and a repo-wide search shows no reset or migration for these names. Those existing users therefore still never see either banner; ignore or clear legacy click entries while retaining explicit x dismissals.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not addressing this one: the feature is behind the WISE_REIMBURSEMENTS beta, so we don’t need to migrate dismissals saved by the old trigger. QA can use a fresh account or clear nvp_dismissedProductTraining.

@joekaufmanexpensify
joekaufmanexpensify requested review from grgia and joekaufmanexpensify and removed request for twisterdotcom November 12, 2026 19:43
@github-actions

Copy link
Copy Markdown
Contributor

🚧 joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@joekaufmanexpensify

Copy link
Copy Markdown
Contributor

Not a huge deal, but I feel like the removal of the banner looks kind of abrupt/tilted on the page when we do it. I wonder if it would be better to hold off on removing it until we close the right-hand pane. It might fit in more naturally with the transition there. Thoughts?

2026-11-12_15-44-02.mp4

@ZhenjaHorbach

ZhenjaHorbach commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-11-13.at.11.09.50.mov
Android: mWeb Chrome
Screen.Recording.2026-11-13.at.11.09.50.mov
iOS: HybridApp
Screen.Recording.2026-11-13.at.11.09.50.mov
iOS: mWeb Safari
Screen.Recording.2026-11-13.at.11.09.50.mov
MacOS: Chrome / Safari
Screen.Recording.2026-11-13.at.10.56.26.mov
Screen.Recording.2026-11-13.at.10.53.14.mov

@ZhenjaHorbach

ZhenjaHorbach commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Not sure if we need to show a banner when the reimbursement account has a deleted status before a BE response

Screen.Recording.2026-11-13.at.10.50.25.mov

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

But overall changes look good!

@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/hooks/useDeferUntilScreenRevealed.ts 100.00% <100.00%> (ø)
src/libs/BankAccountUtils.ts 99.05% <100.00%> (+0.02%) ⬆️
src/libs/actions/WiseOnboarding.ts 84.84% <ø> (-1.27%) ⬇️
...Reimbursements/Wise/WiseBusinessOnboardingPage.tsx 100.00% <100.00%> (ø)
...tings/Wallet/WiseGlobalReimbursementsIntroPage.tsx 98.11% <100.00%> (-0.11%) ⬇️
...kflows/WorkspaceWiseGlobalReimbursementsBanner.tsx 70.58% <100.00%> (ø)
...gs/Wallet/WalletWiseGlobalReimbursementsBanner.tsx 0.00% <0.00%> (ø)
... and 19 files with indirect coverage changes

@WojtekBoman

Copy link
Copy Markdown
Contributor Author

@joekaufmanexpensify @ZhenjaHorbach both issues should be fixed now, ready for another look :)

grgia
grgia previously approved these changes Nov 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@melvin-bot
melvin-bot Bot requested a review from grgia November 13, 2026 12:24
@melvin-bot melvin-bot Bot changed the title [Wise][Release 1] UI - Update Dismiss Banner Entry Trigger [Payment due @ZhenjaHorbach] [Wise][Release 1] UI - Update Dismiss Banner Entry Trigger Nov 13, 2026
@melvin-bot

melvin-bot Bot commented Nov 13, 2026

Copy link
Copy Markdown

🎯 @ZhenjaHorbach, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/693598.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@joekaufmanexpensify joekaufmanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well, thank you!

* so changes made from the RHP show once it closes instead of shifting the layout visible beside it.
* Only primitives are accepted, since a value rebuilt on every render would never match the stored one and would set state on every render.
*/
function useDeferUntilScreenRevealed<TValue extends Primitive>(value: TValue): TValue {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WojtekBoman is this a new pattern or could this hook be used elsewhere? curious that we dont have similar behavior in app already

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s a new pattern. Usually we want the screen next to the RHP to update live, so this hasn’t come up much. Here, saving the onboarding removes the banner, which makes the page jump while the RHP is still open. The hook keeps the old value until the RHP closes. It’s generic, so it could be reused if the same case comes up somewhere else :)

@grgia grgia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, comment non-blocking

@grgia
grgia merged commit 1441a2b into Expensify:main Nov 16, 2026
38 of 40 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/grgia in version: 9.5.40-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR fixes premature dismissal of onboarding banners for the still-beta-gated Wise reimbursements feature, without adding a public workflow or making existing article text incorrect.


view run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants