Repository navigation
Prevent resubmitting an international bank account after success - #106752
Conversation
Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
|
🤖 Web test steps verification results: ❌ fail Blocked on dev NewDot web: Add bank account requires an emailed six-digit security code. No account was created; stopped without attempting to bypass verification.
view run · no recording available |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
|
Pushed 1707da3, correcting the Oxfmt failure with a formatting-only test change. Passed locally: formatter, all 4 targeted tests, file-targeted lint, and Storybook smoke. Broader checks timed out; new CI results are pending. The independent-approval failure requires human review, not a code fix. |
|
🤖 Android test steps verification results: ❌ fail Standalone Android NewDot testing was blocked by mandatory email security-code verification after selecting Add bank account. No bank account was created; Wise beta state and success-path behavior remain unverified.
|
|
|
|
|
|
@MelvinBot did you implement my alternative solution instead of your original proposal because my approach is better? |
|
Yes—I implemented your alternative solution, rather than my original route-replacement proposal. It is better scoped for this bug: it preserves unfinished-step history and edit navigation, whereas my proposal would also change browser Back during an unfinished flow. The implementation uses your two mechanisms: finish on Android Back from success, and finish when a completed confirmation regains focus. I should have explicitly explained that choice before implementing it. End-to-end verification remains blocked by email security-code verification. |
|
@MelvinBot add QA steps and mark this PR ready for review
|
|
Added your seven QA steps and marked Prevent resubmitting an international bank account after success ready for review. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safariweb.mov |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #102213 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
JmillsExpensify
left a comment
There was a problem hiding this comment.
All good on my end
|
All three comments are valid based on code inspection:
No code changed: these comments were authored by |
|
@MelvinBot yes implement them if the fix is small, regression-free. |
|
I left the PR unchanged because I couldn’t establish a small, regression-safe fix for all three concerns. Draft cleanup and
The combined fix needs completion-only history cleanup, with regression coverage for browser refresh, pending-request edits, and alternate entry points. I haven’t claimed those cases are regression-free or pushed an incomplete fix. |
|
@MelvinBot implement only the draft cleanup and |
Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
|
🤖 Web test steps verification results: ❌ fail Blocked on dev NewDot web: the existing session was suspended, and the app rendered a blank page with zero snapshot nodes. No recovery, bypass, or simulated success was attempted.
Pushed b23fe0f2: implemented successful-creation draft cleanup and Passed: 22 targeted tests, typecheck, lint, formatting, changed-file spelling, and Storybook smoke. Full Jest and compiler-comparison checks remain incomplete. view run · no recording available |
|
No code fix was warranted, so I didn’t push changes.
|
|
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.5.40-0 🚀
|
|
No help site update needed — this fixes unintended resubmission after successful international bank-account setup without adding a feature or making existing article instructions incorrect. |



Explanation of Change
Prevent returning from international bank-account success to a confirmation that can submit the same account again. This follows
situchan's alternative solution, preserving normal step history rather than replacing every wizard route:Scope is the reported Wallet flow. The pre-existing finish fallback for entry points outside Settings/Inbox without
backTois unchanged; as noted in the alternative solution, that fallback can still pop a step rather than close the entire flow.Per
situchan's scoped follow-up, history is intentionally unchanged. This does not remove completed Confirmation from browser history or address the reported transition flash.AI Tests
lint-changedandspell-changeddiscovery failed because the shallow checkout lacked a merge base; direct changed-file checks passed. React Compilercheck-changedexceeded 120 seconds; the direct file check exited successfully without output, so no completed compliance comparison is claimed. The legacyprettierscript is absent; used the repository's Oxfmt formatter instead. Full-repository spelling reported pre-existing issues outside the changed files.npm run typecheck, changed-file lint (npm run lint-changed -- --shards=1), changed-file spelling, Storybook smoke test, and staged whitespace check.check-changedexceeded 60 seconds. A direct file check exited successfully without output; no complete changed-versus-main compliance result is claimed.npm run fmt) and committed its test-only formatting correction. A second formatter run produced no unstaged diff. All 4 completion-navigation tests, file-targeted lint, Storybook smoke, staged whitespace, and AI coding-standards review passed. Full lint, full Jest, and typecheck exceeded 180-second local limits; lint-changed and spell-changed stalled fetching origin/main. The legacyprettiercommand is unavailable because this repository uses Oxfmt.Fixed Issues
$ #102213
PROPOSAL: #102213 (comment)
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari