Skip to content

perf: move tab-root gesture logic out of TabNavigator to stop re-renders on navigation - #106820

Merged
mountiny merged 2 commits into
Expensify:mainfrom
software-mansion-labs:perf/tab-root-gesture-controller
Nov 17, 2026
Merged

mountiny merged 2 commits into
Expensify:mainfrom
software-mansion-labs:perf/tab-root-gesture-controller

Conversation

@jmusial

@jmusial jmusial commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Moves the tab-root swipe-back gesture logic, which subscribed to the focused route, out of TabNavigator into a component that renders nothing (TabRootGestureController), so navigating no longer re-renders the whole tab navigator. On web that removes 15 of 15 TabNavigator re-renders over the tested navigation flow, about 17 ms each in dev.

Fixed Issues

$ #106875
PROPOSAL:

Tests

  1. Open the app
  2. Navigate to the Inbox tab and open any chat
  3. Click the chat header to open the details page, then close it
  4. Navigate to the Home tab and back to the Inbox tab
  5. Verify that each screen opens and closes as before and the tab bar keeps showing the selected tab
  6. On iOS only, navigate to the Home tab and swipe right from the left edge of the screen
  7. Verify that nothing happens and Home stays visible
  8. On iOS only, navigate to Workspaces, open any workspace and swipe right from the left edge of the screen
  9. Verify that the app returns to the workspace list

Offline tests

Same as tests

QA Steps

Same as tests

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
pr106820-android-native.mp4
Android: mWeb Chrome
pr106820-android-mweb-chrome.mp4
iOS: Native
pr106820-ios-native.mp4
iOS: mWeb Safari https://github.com/user-attachments/assets/33e77c2f-1902-4cf2-966d-be6d55dcb89a
MacOS: Chrome / Safari
pr106820-desktop-chrome.mp4

@jmusial

jmusial commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

@MelvinBot review

@MelvinBot

MelvinBot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Web test steps verification results: ⚠️ partial

No actionable code-review findings or confirmed navigation regressions. Online navigation worked at wide and narrow widths; offline testing was blocked, selected-tab state was inconclusive, and performance improvements were not measured.

390×844 Inbox after tab navigation and opening/closing Concierge chat

Step Status
Online 1: Open appSigned-in Home displayed.
✅
Online 2: Inbox and open chatConcierge chat opened at both widths.
✅
Online 3: Open and close chat detailsHeader opened Profile; Back restored chat.
✅
Online 4: Home then InboxBoth tabs displayed their expected content.
✅
Online 5: Transitions and selected tabTransitions worked; selected-tab state could not be confirmed programmatically.
Wide web Inbox with Concierge chat after Home-to-Inbox navigation
⚠️
Online 6: iOS Home edge swipeNot applicable on web.
⚠️
Online 7: Home remains after swipeNot applicable on web.
⚠️
Online 8: iOS workspace-detail swipeNot applicable on web.
⚠️
Online 9: Return to workspace listiOS gesture assertion—not applicable on web.
⚠️
Offline 1: Open appBlocked: available browser tooling provides no offline toggle.
⚠️
Offline 2: Inbox and open chatBlocked: offline state unavailable.
⚠️
Offline 3: Open and close detailsBlocked: offline state unavailable.
⚠️
Offline 4: Home then InboxBlocked: offline state unavailable.
⚠️
Offline 5: Transitions and selected tabBlocked: offline state unavailable.
⚠️
Offline 6: iOS Home edge swipeNot applicable on web.
⚠️
Offline 7: Home remains after swipeNot applicable on web.
⚠️
Offline 8: iOS workspace-detail swipeNot applicable on web.
⚠️
Offline 9: Return to workspace listiOS gesture assertion—not applicable on web.
⚠️
Narrow web tab navigationHome and Inbox navigation worked at 390×844.
390×844 Inbox after tab navigation and opening/closing Concierge chat
✅

view run · view recording

@melvin-bot

melvin-bot Bot commented Nov 13, 2026

Copy link
Copy Markdown

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from dylanexpensify and removed request for a team November 13, 2026 16:55
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T17:11:28.296724Z 61f4e74 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dylanexpensify dylanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product input not required for this PR.

@hoangzinh

hoangzinh commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-11-16.at.22.46.56.mov
Android: mWeb Chrome
Screen.Recording.2026-11-16.at.22.48.15.mov
iOS: HybridApp
Screen.Recording.2026-11-16.at.22.49.29.mov
iOS: mWeb Safari
Screen.Recording.2026-11-16.at.22.51.03.mov
MacOS: Chrome / Safari
Screen.Recording.2026-11-16.at.22.44.46.mov

@hoangzinh hoangzinh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@melvin-bot
melvin-bot Bot requested a review from mountiny November 16, 2026 15:51

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me

@mountiny
mountiny merged commit 8161f4b into Expensify:main Nov 17, 2026
37 of 39 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.41-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR is an internal performance refactor that preserves existing navigation behavior, adds no user-facing workflow, and makes no existing article inaccurate.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants