Repository navigation
perf: move tab-root gesture logic out of TabNavigator to stop re-renders on navigation - #106820
Conversation
…ers on navigation
|
@MelvinBot review |
|
🤖 Web test steps verification results: No actionable code-review findings or confirmed navigation regressions. Online navigation worked at wide and narrow widths; offline testing was blocked, selected-tab state was inconclusive, and performance improvements were not measured.
|
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
dylanexpensify
left a comment
There was a problem hiding this comment.
Product input not required for this PR.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-11-16.at.22.46.56.movAndroid: mWeb ChromeScreen.Recording.2026-11-16.at.22.48.15.moviOS: HybridAppScreen.Recording.2026-11-16.at.22.49.29.moviOS: mWeb SafariScreen.Recording.2026-11-16.at.22.51.03.movMacOS: Chrome / SafariScreen.Recording.2026-11-16.at.22.44.46.mov |
mountiny
left a comment
There was a problem hiding this comment.
Thank you! Looks good to me
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.41-0 🚀
|
|
No help site update needed — this PR is an internal performance refactor that preserves existing navigation behavior, adds no user-facing workflow, and makes no existing article inaccurate. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀
Bundle Size Analysis (Sentry): |


Explanation of Change
Moves the tab-root swipe-back gesture logic, which subscribed to the focused route, out of
TabNavigatorinto a component that renders nothing (TabRootGestureController), so navigating no longer re-renders the whole tab navigator. On web that removes 15 of 15TabNavigatorre-renders over the tested navigation flow, about 17 ms each in dev.Fixed Issues
$ #106875
PROPOSAL:
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
pr106820-android-native.mp4
Android: mWeb Chrome
pr106820-android-mweb-chrome.mp4
iOS: Native
pr106820-ios-native.mp4
iOS: mWeb Safari
https://github.com/user-attachments/assets/33e77c2f-1902-4cf2-966d-be6d55dcb89aMacOS: Chrome / Safari
pr106820-desktop-chrome.mp4