Repository navigation
Remove useOnyx loading status reads from company card and Expensify card pages - #106824
Conversation
|
@nkdengineer Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
JmillsExpensify
left a comment
There was a problem hiding this comment.
No product review required.
roryabraham
left a comment
There was a problem hiding this comment.
Nice simplification!
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-11-15.at.23.16.34.movAndroid: mWeb ChromeScreen.Recording.2026-11-15.at.23.10.49.moviOS: HybridAppScreen.Recording.2026-11-15.at.23.15.28.moviOS: mWeb SafariScreen.Recording.2026-11-15.at.23.12.45.movMacOS: Chrome / SafariScreen.Recording.2026-11-15.at.23.05.26.mov |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Explanation of Change
This continues the Workspace cleanup from #106374. This part covers the company cards and Expensify card pages.
Once the app has started,
useOnyxonly returnsloadingwhen a key has nothing in the cache yet and anOnyx.mergefor it hasn't been applied. None of these pages can run into that:Onyx.set(clearAddNewCardFlow,clearAssignCardStepAndData), which updates the cache right away. Later merges land on a key that's already cached. The imported spreadsheet is also written withOnyx.setbefore the columns page opens.WorkspaceCompanyCardsPageonly used the status to hold back the feed fetch. Nothing writes the cards list optimistically, so the check never fired.loadingafter startup.So I removed the loading checks, the metadata variables, and the loaders that only rendered while loading. The
lastSelectedFeedread inWorkspaceCompanyCardsTableanduseCompanyCards, which is a real loading case when switching feeds, is left for the components and hooks batches.Fixed Issues
$ #104583
PROPOSAL:
Tests
Use a Control workspace with a company card feed that has a few cards.
Offline tests
Same, as in Tests section
QA Steps
Same, as in Tests section
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mp4
iOS: Native
ios.mov
MacOS: Chrome / Safari
web_01.mp4
web2.mp4