Repository navigation
[Pinnable columns] Allow hiding optional group columns from the Spend column menu - #106826
Conversation
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee58ba59d9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Hiding a group column on a grouped search with no saved columns saved only the group columns. The Columns page then showed every expense column unchecked, and saving from it dropped the defaults the groups expanded to. Save the default expense columns alongside the group columns, and have ColumnsSettingsList fall back to each section's defaults on its own.
Hiding a group column on a grouped search with no saved expense columns saved the static default expense columns too. Expanded groups then switched from columns derived from their data to that static list, so a Description column disappeared and empty Category and Tag columns appeared. Save only the group columns, so expanded groups keep deriving their columns from the data.
|
@Krishna2323 comment addressed! |
…ouped search With no group columns saved, hiding one saved the group columns on screen. The table drops Amount debited and Amount reimbursed when no withdrawal has a conversion amount, so those were left out of the saved list and never came back. Start from the default group columns instead, the way the Columns page does, keeping any shown column the defaults lack.
twisterdotcom
left a comment
There was a problem hiding this comment.
Looks very cool from a product perspective.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMonosnap.screencast.2026-11-17.00-24-57.mp4 |
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.41-0 🚀
|
|
No help site update needed — this PR fixes expected column-hiding behavior behind the existing |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
The Spend column menu hid "Hide column" on every grouped table.
useHideSearchColumnnow treats a grouped table's group columns as its hidable set. When no group columns are saved yet, hiding one saves the other shown group columns together with the saved expense columns, the way the Columns page does, so expanded groups keep their expense columns. Required columns like From still can't be hidden.Fixed Issues
$ #106765
PROPOSAL:
Tests
pinnableTableColumnsbeta and have expenses from at least two membersgroup-by:fromtype:expense group-by:from columns:merchant,amount(expense columns saved, no group columns)Offline tests
N/A, hiding a column only rewrites the search query.
QA Steps
Same as tests, on staging.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
hide-group-after.mp4