Repository navigation
Add the fraud review screen with the recognized transaction flow - #106863
Draft
JakubKorytko wants to merge 7 commits into
Draft
JakubKorytko wants to merge 7 commits into
JakubKorytko wants to merge 7 commits into
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Part 3/7 of the RiskControl transaction review FE.
Adds the fraud review screen (
multifactor-authentication/review-transaction/:transactionID) in the MFA RHP stack, theREVIEW-FRAUD-TRANSACTIONMFA scenario for "Yes, I do" with the "Try again" outcome, and wires the fraud queue intouseNavigateToForcedTransactionReview:Notes:
illustration_card_pos_refresh.svgadded ascard-pos-refresh.svg(compressed)Fixed Issues
$ #104109
PROPOSAL: N/A
Tests
Precondition: sign in with an account that has an Expensify Card with a transaction pending fraud review.
Offline tests
N/A
QA Steps
Same as tests. The precondition needs the backend part of the design doc on staging, plus a test RiskControl rule that applies a REVIEW tag (same as the "Deploy & verify" section of the doc).
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Not recorded, same React Native code as iOS: Native.
Android: mWeb Chrome
Not recorded, same web code as MacOS: Chrome.
iOS: Native
Recorded on the iOS simulator (HybridApp, top of the stack) with
GetTransactionsPendingFraudReviewandRecordFraudFeedbackfaked inside the app for the recording, since the backend does not have these commands yet. MFA, Face ID registration and the card pages use the real backend.pr3-ios.mp4
iOS: mWeb Safari
Not recorded, same web code as MacOS: Chrome.
MacOS: Chrome / Safari
Recorded on staging with
GetTransactionsPendingFraudReviewandRecordFraudFeedbackanswered by a local mock, since the backend does not have these commands yet. Everything else (sign in, MFA, passkey, card pages) is the real staging backend.pr3-web.mp4