Skip to content

[NoQA][Insights polish] Replace the Top violations donut with a table - #106872

Merged
luacmartins merged 23 commits into
Expensify:mainfrom
software-mansion-labs:insights/top-violations-table
Nov 17, 2026
Merged

luacmartins merged 23 commits into
Expensify:mainfrom
software-mansion-labs:insights/top-violations-table

Conversation

@mhawryluk

@mhawryluk mhawryluk commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Explanation of Change

Replaces the Top violations donut on the Compliance dashboard with a full-width table, moved below Violations by submitter and Violations by approver.

Each row shows the violation, its share of all violation types' expenses, the number of expenses and their amount. Rows are sorted by expenses and open the chart's Spend query when pressed. With Compare: Previous period, a change column shows how each violation's expenses changed. With Compare: Average, a line marks the all-violation average on the share bars. On mobile, the table becomes a list with the same rows.

The table is built as a generic ranking table, so other Insights charts will be able to use it.

The table is built from plain views rather than the shared Table component, because Table is built around a page-level virtualized list, while this one sits inside a dashboard card with at most 15 rows, like the other tables inside Insights cards.

Fixed Issues

$ #106841
PROPOSAL: N/A

Tests

  1. Sign in to an account with a Control workspace with submitted expenses that have several different violations. Enable the insightsCompliance beta.
  2. Open Insights > Compliance and verify Top violations is a full-width table below Violations by submitter and Violations by approver, sorted by Expenses, with at most 15 rows.
  3. Press a row and verify the Spend page opens with the chart's filters (no violation yet, the PR for it hasn't landed yet)
  4. Set Compare to Previous period and verify a % change column shows each violation's change. Pick a period where a violation had no expenses in the previous period and verify it shows New.
  5. Set Compare to Average and verify a dashed average line with an "avg" pill runs through the Share column.
  6. Repeat 2 to 5 on a narrow screen and verify the table shows as a list, with an average legend at the bottom in Average mode.
  7. Pick a date range with no violations and verify the card shows the empty state.

Offline tests

  1. Go offline and open the dashboard with no data fetched already.
  2. Verify it shows the offline state.
  3. Go online. Verify the skeleton then the table with data shows.
  4. Go offline. Verify the data is still shown.

QA Steps

No tests.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Nagranie.z.ekranu.2026-11-16.o.17.17.50.mov
Android: mWeb Chrome
iOS: Native
Simulator.Screen.Recording.-.iPhone.17.-.2026-11-16.at.17.06.32.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-11-16.o.17.06.53.mov
Zrzut ekranu 2026-11-16 o 17 23 47 Zrzut ekranu 2026-11-16 o 17 12 48 Zrzut ekranu 2026-11-16 o 17 13 12

@melvin-bot

melvin-bot Bot commented Nov 13, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

@OSBotify

Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/de.ts b/src/languages/de.ts
index a6cd6833..3ad74a31 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -1243,6 +1243,8 @@ const translations: TranslationDeepObject<typeof en> = {
             allMerchantAverage: 'Durchschnitt über alle Händler',
             allCategoryAverage: 'Durchschnitt aller Kategorien',
             averageValue: (amount: string) => `${amount} durchschnittl.`,
+            allViolationAverage: 'Durchschnitt aller Verstöße',
+            noChange: 'Keine Änderung',
         },
         compliance: 'Compliance',
         runningTotal: 'Laufende Summe',
@@ -1267,6 +1269,8 @@ const translations: TranslationDeepObject<typeof en> = {
         longestToSubmit: 'Am längsten bis zur Einreichung',
         slowestToApprove: 'Am langsamsten bei der Genehmigung',
         mostTimeToPay: 'Längste Zahlungsfrist',
+        percentChange: '% Änderung',
+        share: 'Anteil',
     },
     allSettingsScreen: {
         subscription: 'Abonnement',
diff --git a/src/languages/el.ts b/src/languages/el.ts
index e888695e..3d57bb2d 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -1289,6 +1289,8 @@ const translations: TranslationDeepObject<typeof en> = {
             allMerchantAverage: 'Μέσος όρος όλων των εμπόρων',
             allCategoryAverage: 'Μέσος όρος όλων των κατηγοριών',
             averageValue: (amount: string) => `${amount} κατά μέσο όρο`,
+            allViolationAverage: 'Μέσος όρος όλων των παραβάσεων',
+            noChange: 'Χωρίς αλλαγή',
         },
         compliance: 'Συμμόρφωση',
         runningTotal: 'Τρέχον σύνολο',
@@ -1313,6 +1315,8 @@ const translations: TranslationDeepObject<typeof en> = {
         longestToSubmit: 'Περισσότερος χρόνος για υποβολή',
         slowestToApprove: 'Πιο αργοί στην έγκριση',
         mostTimeToPay: 'Περισσότερος χρόνος για πληρωμή',
+        percentChange: '% μεταβολή',
+        share: 'Μερίδιο',
     },
     allSettingsScreen: {
         subscription: 'Συνδρομή',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 5e5a6359..ae2c881c 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -1237,6 +1237,8 @@ const translations: TranslationDeepObject<typeof en> = {
             allMerchantAverage: 'Promedio de todos los comercios',
             allCategoryAverage: 'Promedio de todas las categorías',
             averageValue: (amount: string) => `${amount} prom de media`,
+            allViolationAverage: 'Media de todas las infracciones',
+            noChange: 'Sin cambios',
         },
         compliance: 'Cumplimiento',
         runningTotal: 'Total acumulado',
@@ -1261,6 +1263,8 @@ const translations: TranslationDeepObject<typeof en> = {
         longestToSubmit: 'Más lento en enviar',
         slowestToApprove: 'Más lento en aprobar',
         mostTimeToPay: 'Más tiempo para pagar',
+        percentChange: '% de cambio',
+        share: 'Porcentaje de participación',
     },
     allSettingsScreen: {
         subscription: 'Suscripcion',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 25294bb4..fcf4f7ef 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -1250,6 +1250,8 @@ const translations: TranslationDeepObject<typeof en> = {
             allMerchantAverage: 'Moyenne tous marchands',
             allCategoryAverage: 'Moyenne toutes catégories',
             averageValue: (amount: string) => `${amount} en moyenne`,
+            allViolationAverage: 'Moyenne de toutes les infractions',
+            noChange: 'Aucun changement',
         },
         compliance: 'Conformité',
         runningTotal: 'Total cumulé',
@@ -1274,6 +1276,8 @@ const translations: TranslationDeepObject<typeof en> = {
         longestToSubmit: 'Le plus long à soumettre',
         slowestToApprove: 'Plus lent à approuver',
         mostTimeToPay: 'Délai de paiement le plus long',
+        percentChange: '% de changement',
+        share: 'Part de la part totale (%)',
     },
     allSettingsScreen: {
         subscription: 'Abonnement',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 27bd6949..a1716bdf 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -1246,6 +1246,8 @@ const translations: TranslationDeepObject<typeof en> = {
             allMerchantAverage: 'Media tutti gli esercenti',
             allCategoryAverage: 'Media di tutte le categorie',
             averageValue: (amount: string) => `${amount} in media`,
+            allViolationAverage: 'Media di tutte le violazioni',
+            noChange: 'Nessuna modifica',
         },
         compliance: 'Conformità',
         runningTotal: 'Totale progressivo',
@@ -1270,6 +1272,8 @@ const translations: TranslationDeepObject<typeof en> = {
         longestToSubmit: 'Più lungo per l’invio',
         slowestToApprove: 'I più lenti ad approvare',
         mostTimeToPay: 'Tempo massimo per pagare',
+        percentChange: '% variazione',
+        share: 'Quota%',
     },
     allSettingsScreen: {
         subscription: 'Abbonamento',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 4bc64761..49ece2b6 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -1231,6 +1231,8 @@ const translations: TranslationDeepObject<typeof en> = {
             allMerchantAverage: '全加盟店の平均',
             allCategoryAverage: '全カテゴリ平均',
             averageValue: (amount: string) => `平均 ${amount}`,
+            allViolationAverage: 'すべての違反の平均',
+            noChange: '変更なし',
         },
         compliance: 'コンプライアンス',
         runningTotal: '累計合計',
@@ -1255,6 +1257,8 @@ const translations: TranslationDeepObject<typeof en> = {
         longestToSubmit: '提出まで最も長い順',
         slowestToApprove: '承認が最も遅い',
         mostTimeToPay: '支払いまで最も時間がかかる',
+        percentChange: '% 変化',
+        share: 'シェア割合',
     },
     allSettingsScreen: {
         subscription: 'サブスクリプション',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 8b9d8457..2ea22d69 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -1242,6 +1242,8 @@ const translations: TranslationDeepObject<typeof en> = {
             allMerchantAverage: 'Gemiddelde voor alle handelaren',
             allCategoryAverage: 'Gemiddelde voor alle categorieën',
             averageValue: (amount: string) => `${amount} gem.`,
+            allViolationAverage: 'Gemiddelde over alle overtredingen',
+            noChange: 'Geen wijziging',
         },
         compliance: 'Naleving',
         runningTotal: 'Doorlopend totaal',
@@ -1266,6 +1268,8 @@ const translations: TranslationDeepObject<typeof en> = {
         longestToSubmit: 'Langste om in te dienen',
         slowestToApprove: 'Traagst om goed te keuren',
         mostTimeToPay: 'Meeste tijd om te betalen',
+        percentChange: '% wijziging',
+        share: 'Aandeel',
     },
     allSettingsScreen: {
         subscription: 'Abonnement',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index eeafb23c..7de9a231 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -1269,6 +1269,8 @@ const translations: TranslationDeepObject<typeof en> = {
             allMerchantAverage: 'Średnia dla wszystkich sprzedawców',
             allCategoryAverage: 'Średnia dla wszystkich kategorii',
             averageValue: (amount: string) => `średnio ${amount}`,
+            allViolationAverage: 'Średnia wszystkich naruszeń',
+            noChange: 'Bez zmian',
         },
         compliance: 'Zgodność',
         runningTotal: 'Suma narastająco',
@@ -1293,6 +1295,8 @@ const translations: TranslationDeepObject<typeof en> = {
         longestToSubmit: 'Najdłużej oczekujące na wysłanie',
         slowestToApprove: 'Najwolniejszy w zatwierdzaniu',
         mostTimeToPay: 'Najdłuższy czas na zapłatę',
+        percentChange: '% zmiana',
+        share: 'Udział',
     },
     allSettingsScreen: {
         subscription: 'Subskrypcja',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index f2bda196..9258f7fa 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -1245,6 +1245,8 @@ const translations: TranslationDeepObject<typeof en> = {
             allMerchantAverage: 'Média de todos os estabelecimentos',
             allCategoryAverage: 'Média de todas as categorias',
             averageValue: (amount: string) => `${amount} média`,
+            allViolationAverage: 'Média de todas as violações',
+            noChange: 'Sem alteração',
         },
         compliance: 'Conformidade',
         runningTotal: 'Total acumulado',
@@ -1269,6 +1271,8 @@ const translations: TranslationDeepObject<typeof en> = {
         longestToSubmit: 'Mais demorados para enviar',
         slowestToApprove: 'Mais lento para aprovar',
         mostTimeToPay: 'Maior prazo para pagar',
+        percentChange: '% de mudança',
+        share: 'Participação',
     },
     allSettingsScreen: {
         subscription: 'Assinatura',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 145b9424..26319c9d 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -1196,6 +1196,8 @@ const translations: TranslationDeepObject<typeof en> = {
             allMerchantAverage: '所有商户平均值',
             allCategoryAverage: '所有类别平均值',
             averageValue: (amount: string) => `${amount} 平均`,
+            allViolationAverage: '所有违规平均值',
+            noChange: '无更改',
         },
         compliance: '合规',
         runningTotal: '累计总额',
@@ -1216,6 +1218,8 @@ const translations: TranslationDeepObject<typeof en> = {
         longestToSubmit: '提交所用时间最长',
         slowestToApprove: '审批最慢',
         mostTimeToPay: '最长付款时间',
+        percentChange: '百分比变动',
+        share: '占比',
     },
     allSettingsScreen: {
         subscription: '订阅',

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

@codecov

codecov Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 96.15% <ø> (ø)
src/components/Charts/utils/formatChartCount.ts 100.00% <100.00%> (ø)
src/components/Search/buildChartSeries.ts 100.00% <100.00%> (ø)
src/components/Search/chartGroupByConfig.ts 86.20% <100.00%> (+3.44%) ⬆️
src/pages/Insights/InsightsChangeBadge.tsx 100.00% <100.00%> (ø)
src/pages/Insights/ai/InsightsAIChip.tsx 100.00% <100.00%> (ø)
src/pages/Insights/buildInsightsChartCSV.ts 100.00% <100.00%> (ø)
src/pages/Insights/charts/buildRankingTableRows.ts 100.00% <100.00%> (ø)
src/pages/Insights/dashboardSpecs.ts 100.00% <ø> (ø)
src/styles/variables.ts 100.00% <ø> (ø)
... and 10 more
... and 38 files with indirect coverage changes

@mhawryluk
mhawryluk marked this pull request as ready for review November 16, 2026 16:24
@mhawryluk
mhawryluk requested review from a team as code owners November 16, 2026 16:24
@expensify-chore-bot
expensify-chore-bot Bot requested review from truph01 and removed request for a team November 16, 2026 16:24
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T16:47:47.218626Z 9e81b8d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@expensify-chore-bot

Copy link
Copy Markdown

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@expensify-chore-bot
expensify-chore-bot Bot requested review from JmillsExpensify and removed request for a team November 16, 2026 16:25
Comment thread src/pages/Insights/dashboardSpecs.ts Resolved
@dannymcclain

Copy link
Copy Markdown
Contributor

Dang this is looking good. Can we run an ad hoc build to test?

I think we should probably use the same line style for the average line in the table on desktop as the one from the charts above. Also @JmillsExpensify are we expecting to be able to click on these rows and open a details RHP?

@JmillsExpensify

Copy link
Copy Markdown
Contributor

Awesome, sounds good to me. @mhawryluk hopefully a quick change once you're back online.

@truph01

truph01 commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained """"why"""" the code was doing something instead of only explaining """"what"""" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
Screen.Recording.2026-11-17.at.11.34.01.mov
iOS: mWeb Safari
Screen.Recording.2026-11-17.at.11.34.01.mov
MacOS: Chrome / Safari
Screen.Recording.2026-11-17.at.11.31.56.mov

};

/** Splits the charts, in order, into sections: a full-width chart on its own, or the charts between two full-width ones, which share a two-column grid */
function getDashboardSections(charts: InsightsDashboardChart[]): Array<InsightsDashboardChart | InsightsDashboardChart[]> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Compliance, filtered to a workspace with several members but no approvals, Violations by submitter sits alone in the left half with an empty right half.

Maybe a one-chart grid could go full width too?

image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! We could also move the chart down to the bottom for this case.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, both solutions are doable. I moved the row with the gap at the bottom of the page for now:

Zrzut ekranu 2026-11-17 o 11 25 07

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think that works and we can merge with that solution in mind. Another potential future option is always showing that graph for approvers and simply showing it with the empty state. The reality is that most accounts have approvals enabled.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super down to roll with it at the bottom, but this also doesn't sound like a bad idea to me:

Another potential future option is always showing that graph for approvers and simply showing it with the empty state

@mhawryluk

Copy link
Copy Markdown
Member Author

Ah right on - I think the New badge calls too much attention to itself without saying anything personally. I'd love to see it with just the —.

sure, done!

Zrzut ekranu 2026-11-17 o 11 35 08

@mhawryluk
mhawryluk requested a review from truph01 November 17, 2026 10:36
@github-actions

Copy link
Copy Markdown
Contributor

🚧 JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@melvin-bot
melvin-bot Bot requested a review from luacmartins November 17, 2026 11:09

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes are looking great. Let's get this merged.

@luacmartins
luacmartins merged commit 4454150 into Expensify:main Nov 17, 2026
39 of 40 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.5.41-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — the table change remains behind the existing compliance beta gate, and no existing article sentence becomes incorrect.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants