Repository navigation
[No QA] Stabilize CIGitLogic sandbox cleanup - #106901
Merged
Merged
Conversation
Co-authored-by: Rory Abraham <roryabraham@users.noreply.github.com>
roryabraham
requested changes
Nov 13, 2026
Co-authored-by: Rory Abraham <roryabraham@users.noreply.github.com>
Co-authored-by: Rory Abraham <roryabraham@users.noreply.github.com>
roryabraham
approved these changes
Nov 13, 2026
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
@dmkt9 C+ review not needed here |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
blimpich
approved these changes
Nov 13, 2026
francoisl
approved these changes
Nov 13, 2026
mountiny
approved these changes
Nov 13, 2026
Contributor
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.40-0 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Harden the CI Git test sandbox against checkout-deletion races:
The injected disappearance deterministically produced the same
ENOENT ... lstat '.../checkout'at the original deletion before the fix and passes afterward. This reproduces the missing-checkout failure mode, not proof that Git maintenance caused the original CI failure; that trigger remains a hypothesis.Sandbox changes: tests/tooling/CIGitLogic.test.ts:193-238.
AI Tests
git diff --checkpassed. Lint-changed and spell-changed failed because the shallow checkout lacks a merge base. Full lint, typecheck, and Jest exceeded 120 seconds; theprettierscript is absent. Code review found no violations; its comparison used the staged diff and remote PR diff because no merge base was available.git diff --checkpassed. Lint-changed and spell-changed could not find a merge base in the shallow checkout. Full lint, typecheck, Jest, and Storybook smoke checks each exceeded 120 seconds; theprettierscript is absent.npm run typecheck -- tsconfig.bun.json,npm run spell-changed, Storybook smoke test, pre-commit Oxfmt formatting, andgit diff --check.Cannot read properties of undefined (reading 'Cjs')); full typecheck reports errors in unchanged application code. Full Jest execution hit the 120-second limit while reporting navigation ESM-loading failures. The oldprettierscript does not exist; the repository's Oxfmt pre-commit check passed instead.Fixed Issues
$ #106889
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari