Skip to content

Show last weekday monthly submission dates in admin logs - #106947

Merged
francoisl merged 1 commit into
mainfrom
claude-monthlyOffsetAdminLog
Nov 16, 2026
Merged

francoisl merged 1 commit into
mainfrom
claude-monthlyOffsetAdminLog

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Reuse the shared monthly-offset parser and display formatter in admin log messages so all seven "Last weekday" values display correctly as both the new and previous dates. This also preserves numeric ordinals, the existing last-day options, and the wording for an empty previous date. No API or translation changes are needed.

Narrow the submission schedule helper's existing policy import to its defining module to avoid introducing a circular dependency when the report-action formatter imports it.

AI Tests

  • Passed: full Jest suite, 2,384 suites and 39,716 tests; 160 snapshots passed (146 tests and one suite skipped by the suite configuration).
  • Passed: focused report-action suite, 606 tests, including 31 new regression cases for old/new monthly offsets.
  • Passed: full lint, lint-changed, typecheck, spell-changed, Storybook smoke test, and staged Oxfmt formatting in the commit hook.
  • Passed: staged code review against all App coding-standard rules; no violations.
  • Tooling limitation: the matrix's legacy npm run prettier script no longer exists; the repository's Oxfmt commit hook passed instead. Translation generation dry-run could not run: the legacy ts-node invocation failed during initialization (TypeError reading fileExists), and the Bun invocation was unavailable. No translation files were changed.
  • Browser verification is incomplete: Workflows was visible, but attempting to open it produced an empty page and the testing session became unavailable. Frequency persistence and both admin log messages remain unverified end to end.
Web verification blocker screenshots Workspace Overview during initial navigation attempt Empty page when attempting to continue to Workflows

Fixed Issues

$ #103478
PROPOSAL: #103478 (comment)

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  1. As a workspace admin, go to Workspace settings > Workflows > Submissions > Frequency.
  2. Select Monthly > Day of the month > Last Friday > Save.
  3. Press Save on the Frequency page.
  4. Open the workspace #admins room.

Expected result: The admin log shows: updated the monthly report submission date to "Last Friday" (previously "1st").

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
@MelvinBot

MelvinBot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Android test steps verification results: ⚠️ partial

Verified the monthly-date flow and both admin-log values on standalone Android NewDot. The running build’s PR-head identity could not be confirmed, and JavaScript-error absence remains unverified.

Admin thread showing restored 1st with previous date Last Friday

Step Status
Open Workflows > Submissions > FrequencyCreated an admin-owned workspace; confirmed Monthly with Day of the month set to 1st. Baseline screenshot not captured.
✅
Select Monthly > Day of the month > Last Friday > SaveSaved Last Friday; Frequency displayed the selected date. Step screenshot not captured.
✅
Save Frequency and confirm persistenceSubmissions displayed Monthly on the last Friday; reopening Frequency retained Last Friday. Step screenshot not captured.
✅
Verify admin log: Last Friday, previously 1stAdmin log displayed “Last Friday” (previously “1st”), without blank values.
Admin thread showing Last Friday with previous date 1st
✅
Restore 1st and verify previous date Last FridayRestored 1st; admin log displayed “1st” (previously “Last Friday”).
Admin thread showing restored 1st with previous date Last Friday
✅
Verify no JavaScript errorsNo visible error overlay occurred, but native-log access was blocked; absence of JavaScript errors is unverified.
⚠️

view run · view recording

@situchan

Copy link
Copy Markdown
Contributor

@MelvinBot add QA steps same as OP and mark this PR ready for review

@MelvinBot

MelvinBot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Web test steps verification results: ⚠️ partial

The five functional checks passed on dev NewDot web, including both admin-log date values and restoring 1st. The running build’s PR-head identity remains unconfirmed, and JS-console inspection was unavailable.

Admin log displays restored 1st and previously Last Friday

Step Status
Open Workflows > Submissions > Frequency, starting at 1stCreated an admin-owned workspace, established Monthly on the 1st, and reopened Frequency to confirm. Screenshot corroborates the baseline through the admin log.
Admin log corroborates the initial 1st setting
✅
Select Monthly > Day of the month > Last Friday > SaveSelected and saved Last Friday; Frequency displayed Day of the month, Last Friday.
Admin log corroborates the Last Friday change
✅
Save Frequency and confirm persistenceSubmissions displayed Monthly on the last Friday. Reopening Frequency confirmed Last Friday remained selected.
Admin log records the saved Last Friday setting
✅
Open admins room and verify Last Friday, previously 1stLog displayed: updated the monthly report submission date to "Last Friday" (previously "1st"). Neither value was blank.
Admin log displays Last Friday and previously 1st
✅
Restore 1st and verify previous date Last FridayRestored Monthly on the 1st. Log displayed: updated the monthly report submission date to "1st" (previously "Last Friday").
Admin log displays restored 1st and previously Last Friday
✅
Verify no JS-console errorsUnverified: supported browser tooling did not expose console inspection. A clean console could not be confirmed.
⚠️

view run · view recording

@MelvinBot
MelvinBot marked this pull request as ready for review November 15, 2026 16:07
@MelvinBot
MelvinBot requested a review from a team as a code owner November 15, 2026 16:07
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Added the QA steps and expected result from the original issue, and marked this PR ready for review.


view run

@expensify-chore-bot
expensify-chore-bot Bot requested review from situchan and trjExpensify and removed request for a team and trjExpensify November 15, 2026 16:07
@expensify-chore-bot

Copy link
Copy Markdown

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@expensify-chore-bot
expensify-chore-bot Bot removed the request for review from a team November 15, 2026 16:07
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T16:09:08.919245Z 729b507 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@situchan

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
ios.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mov

@melvin-bot

melvin-bot Bot commented Nov 15, 2026

Copy link
Copy Markdown

We did not find an internal engineer to review this PR, trying to assign a random engineer to #103478 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

@francoisl
francoisl merged commit 91ba457 into main Nov 16, 2026
55 of 57 checks passed
@francoisl
francoisl deleted the claude-monthlyOffsetAdminLog branch November 16, 2026 18:19
@github-actions

Copy link
Copy Markdown
Contributor

🚧 francoisl has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/francoisl in version: 9.5.40-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor Author

No help site update needed — this PR fixes monthly submission dates displaying incorrectly in admin logs without changing the workflow or making any existing article inaccurate.


view run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants