Skip to content

[No QA] Docs updates for E/A#106502 Explain read-only report fields in expense details - #107045

Merged
stephanieelliott merged 1 commit into
mainfrom
claude-docsReportExpenseFields106502
Nov 16, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
claude-docsReportExpenseFields106502

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Document the new, non-beta capability introduced by Show report columns as additional expense fields: additional selected report columns appear as read-only fields in expense details and single-expense reports.

Update the existing expense-table paragraph with one sentence and use “Selecting” instead of “Clicking.” No existing sentence became incorrect; this qualifies because it is a new user-facing capability, not because the article was incomplete. No new section or FAQ is added.

The new fields are rendered without a beta gate in MoneyRequestView.tsx:1853–1863, using the saved column selection in MoneyRequestViewAdditionalFields.tsx:62–93.

AI Tests

  • npm run spell-changed: passed, no spelling issues.
  • npm run lint-changed: passed; no lintable code changed.
  • git diff --check: passed.
  • Staged-diff review against the code reviewer and HelpDot governance rules: no violations.
  • Markdown prose only; no app code, docs routes, or configuration changed, so app compilation/unit tests and Docker services are not applicable.
  • Live dev web UI confirmed the exact Columns and Purchase amount labels. Full behavior verification was blocked because the relevant options were disabled in that environment; this was not a test of the adhoc PR deployment. Behavior is supported by the source diff and its tests, not claimed as runtime-verified here.

Fixed Issues

$ #101300
PROPOSAL: N/A — documentation follow-up to #106502

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validate your changes worked.

  • Verify that no errors appear in the JS console

Offline tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari Columns customization dialog

@brunovjk, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Bruno Rocha <brunovjk@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team November 16, 2026 22:29
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Nov 16, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://ec766d2e.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott
stephanieelliott marked this pull request as ready for review November 16, 2026 23:35
@stephanieelliott
stephanieelliott self-requested a review as a code owner November 16, 2026 23:35
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T23:47:40.618010Z 0e8a3f1 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@expensify-chore-bot

Copy link
Copy Markdown

Product reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR?

cc @JmillsExpensify

@expensify-chore-bot
expensify-chore-bot Bot requested review from JmillsExpensify and removed request for a team November 16, 2026 23:35
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a single, surgical one-line change to docs/articles/new-expensify/reports-and-expenses/Managing-Expenses-in-a-Report.md. It documents a new, non-beta capability (from PR #106502): additional report columns selected in the Columns picker now also appear as read-only fields in expense details and single-expense reports. The change also corrects the verb "Clicking" to "Selecting" to comply with naming conventions. No new sections, headings, FAQ, or metadata were added, which is appropriate for scoping a small behavioral addition to an existing explanatory paragraph.

Scores Summary

  • Readability: 9/10 - The added sentence is clear, concise, and scannable. It flows naturally after the existing sentence about opening expense details. Minor nitpick: the sentence packs two destinations ("expense details and single-expense reports") into one line, but it remains easy to parse.
  • AI Readiness: 9/10 - Uses full, UI-exact feature labels (Columns, Purchase amount) that match real search intent. The example-driven phrasing ("such as Purchase amount") improves semantic retrieval. The change sits under an existing task-based ## heading and introduces no heading or hierarchy issues. No metadata changes were in scope, so internalScope is neither helped nor harmed.
  • Style Compliance: 10/10 - Fully compliant. "Clicking" → "Selecting" aligns with the mandatory "select" verb rule (HELPSITE_NAMING_CONVENTIONS.md Actions). UI labels are bolded and match the UI exactly, consistent with their existing use in the same article (the Columns picker on the preceding lines and Purchase amount in the column list). "read-only fields" correctly uses "field" terminology. "expense details" and "single-expense reports" are lowercased generic terms, per the Generic Terms rule. No prohibited or vague navigation language.

Key Findings

  • The verb correction from "Clicking" to "Selecting" fixes a pre-existing style violation while adding the new content — a clean, well-scoped improvement.
  • UI terminology is exact and internally consistent: Columns and Purchase amount match labels already used elsewhere in the article.
  • Scope discipline is strong: the PR documents exactly one new capability without expanding the article or introducing unrelated edits, matching the one-workflow principle.
  • No critical issues. The change introduces no heading, metadata, cross-linking, or navigation concerns.
  • Minor consideration only: "read-only fields" is a behavioral description rather than a quoted UI label; this is acceptable and not a violation.

Recommendations

  • No blocking changes required. The diff is compliant and ready.
  • Optional polish: if desired, the author could confirm whether "single-expense reports" is the preferred customer-facing phrasing versus "single-expense report view," but the current wording is clear and acceptable.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Managing-Expenses-in-a-Report.md — One line modified (line 158). Compliant with all three governance files; verb corrected and new read-only-fields capability documented accurately.

Note: The inline reviewer posted 0 inline comments — the diff contains no line-level violations.

@stephanieelliott
stephanieelliott merged commit f5eb25f into main Nov 16, 2026
26 of 27 checks passed
@stephanieelliott
stephanieelliott deleted the claude-docsReportExpenseFields106502 branch November 16, 2026 23:38
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.41-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants