Repository navigation
[No QA] Docs updates for E/A#106502 Explain read-only report fields in expense details - #107045
Conversation
Co-authored-by: Bruno Rocha <brunovjk@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://ec766d2e.helpdot.pages.dev ⚡️ Updated articles: |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? |
HelpDot Documentation ReviewOverall AssessmentThis PR makes a single, surgical one-line change to Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: The inline reviewer posted 0 inline comments — the diff contains no line-level violations. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.41-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Document the new, non-beta capability introduced by Show report columns as additional expense fields: additional selected report columns appear as read-only fields in expense details and single-expense reports.
Update the existing expense-table paragraph with one sentence and use “Selecting” instead of “Clicking.” No existing sentence became incorrect; this qualifies because it is a new user-facing capability, not because the article was incomplete. No new section or FAQ is added.
The new fields are rendered without a beta gate in MoneyRequestView.tsx:1853–1863, using the saved column selection in MoneyRequestViewAdditionalFields.tsx:62–93.
AI Tests
npm run spell-changed: passed, no spelling issues.npm run lint-changed: passed; no lintable code changed.git diff --check: passed.Fixed Issues
$ #101300
PROPOSAL: N/A — documentation follow-up to #106502
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validate your changes worked.
Offline tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@brunovjk, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.