Repository navigation
[No QA] Fix typecheck on main: add sentryLabel to ThreeDotsMenu test items - #107060
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
expensify-chore-bot
Bot
requested review from
danieldoglas
and removed request for
a team
November 16, 2026 23:24
|
@danieldoglas Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
robertjchen
approved these changes
Nov 16, 2026
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Contributor
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.41-0 🚀
|
1 of 7 tasks
Contributor
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀
Bundle Size Analysis (Sentry): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
npm run typecheckfails onmainwithtests/unit/ThreeDotsMenuModalSubscriptionTest.tsx(63,21): error TS2322: Type '{ text: string; onSelected: () => void; }[]' is not assignable to type 'PopoverMenuItem[]'.Two PRs landed at close to the same time and conflicted in a way no single PR could catch:
sentryLabelrequired onPopoverMenuItem.ThreeDotsMenuModalSubscriptionTest.tsx, whosemenuItemshas nosentryLabel.This PR adds
sentryLabel: CONST.SENTRY_LABEL.TEST.LABELto the test'smenuItems, the same label other tests use. It only changes a test fixture. No app code changes.Fixed Issues
$ #107061
PROPOSAL:
Tests
npm run typecheck.tests/unit/ThreeDotsMenuModalSubscriptionTest.tsx.npx jest tests/unit/ThreeDotsMenuModalSubscriptionTest.tsx.Offline tests
N/A. This is a test only change.
QA Steps
No QA. This is a test only change with no user facing behavior.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Not yet tested — needs manual QA.
Android: mWeb Chrome
Not yet tested — needs manual QA.
iOS: Native
Not yet tested — needs manual QA.
iOS: mWeb Safari
Not yet tested — needs manual QA.
MacOS: Chrome / Safari
Not yet tested — needs manual QA.