Repository navigation
[No QA] Clarify NetSuite automatic exports before payment - #107070
Conversation
Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://53b053bd.helpdot.pages.dev ⚡️ Updated articles: |
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
HelpDot Documentation ReviewOverall AssessmentThis PR revises two NetSuite configuration articles (New Expensify and Expensify Classic) to clarify when reimbursable expenses export automatically, distinguishing Accrual (final approval) from Cash (paid or marked as paid). The changes also perform a broad structural cleanup: fixing the title casing ( Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
@stephanieelliott one tiny comment outstanding, but otherwise it's good. |
|
🚀 Deployed to staging by https://github.com/kadiealexander in version: 9.5.43-0 🚀
|
|
🚀 Deployed to staging by https://github.com/kadiealexander in version: 9.5.47-0 🚀
|
|
🚀 Deployed to staging by https://github.com/kadiealexander in version: 9.5.51-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.51-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Clarify how to automatically export approved NetSuite reports before paying them, in both the New Expensify and Expensify Classic help articles:
AI Tests
npm run spell-changed— passed for both articles (zero spelling issues).npm run lint-changed— passed; no lintable code files changed.npm run createDocsRoutes— passed.git diff --check— passed.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/699048
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari