Skip to content

[No QA] Clarify NetSuite automatic exports before payment - #107070

Merged
kadiealexander merged 1 commit into
mainfrom
claude-netSuiteAutoExportDocs
Nov 19, 2026
Merged

kadiealexander merged 1 commit into
mainfrom
claude-netSuiteAutoExportDocs

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Clarify how to automatically export approved NetSuite reports before paying them, in both the New Expensify and Expensify Classic help articles:

  • Explain Accrual (final approval) versus Cash (paid or marked as paid).
  • Link automatic export guidance to the accounting method and correct the conflicting reimbursement FAQ.
  • Add the FAQ about exporting automatically without first paying in Expensify.
  • Use the current source-code labels: When to Export and Auto-sync in New Expensify; Accounting Method and Auto Sync in Classic. Source verification instead of live UI verification was authorized by the requester.
  • Align article titles and heading structure with the help authoring guidelines, preserving existing invoice and advanced-settings redirect targets. Unrelated legacy body content is unchanged; other accounting integrations are out of scope.

AI Tests

  • npm run spell-changed — passed for both articles (zero spelling issues).
  • npm run lint-changed — passed; no lintable code files changed.
  • npm run createDocsRoutes — passed.
  • git diff --check — passed.
  • Read-only source verification confirmed platform-specific labels and export-timing descriptions. No live UI testing was performed.
  • A full Jekyll build could not be run because the environment denied the build command. Full site rendering remains unverified locally.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/699048
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team November 17, 2026 03:30
@OSBotify

Copy link
Copy Markdown
Contributor

@stephanieelliott
stephanieelliott marked this pull request as ready for review November 17, 2026 06:03
@stephanieelliott
stephanieelliott self-requested a review as a code owner November 17, 2026 06:03
@expensify-chore-bot

expensify-chore-bot Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Product reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR?

cc @garrettmknight

@expensify-chore-bot
expensify-chore-bot Bot requested review from garrettmknight and removed request for a team November 17, 2026 06:03
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T06:14:56.899019Z c7a6dbe Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR revises two NetSuite configuration articles (New Expensify and Expensify Classic) to clarify when reimbursable expenses export automatically, distinguishing Accrual (final approval) from Cash (paid or marked as paid). The changes also perform a broad structural cleanup: fixing the title casing (NetSuite), adding a single # H1 title, converting all former # section headings to task-based ## headings, adding internalScope metadata, correcting a conflicting reimbursement FAQ, and adding a new FAQ about exporting after approval without payment. The changes are well-aligned with the governance guidelines and materially improve both readability and AI retrievability.

Scores Summary

  • Readability: 9/10 - New Accounting Method / When to Export sections use clean bullet contrasts and sequential numbered steps. Sentences are concise and action-oriented. Minor nit: a few new explanatory sentences are dense (e.g., the combined company-card/reimbursable FAQ answer).
  • AI Readiness: 9/10 - Strong improvement. Every changed heading is now task-based (How to..., Can I...), the file now has exactly one # title plus # FAQ, internalScope metadata was added to both files, keywords were expanded with real search phrases, and full feature names are used consistently. Heading hierarchy is now compliant (# and ## only).
  • Style Compliance: 8/10 - New content correctly uses select/choose, bolded UI labels, lowercase generic terms, and (in New Expensify) the exact navigation-tabs phrasing with a lowercase [workspace name] placeholder. Small inconsistencies remain between new and legacy content (see findings), but these are confined mostly to unchanged lines.

Key Findings

  • Positive: The # → ## heading conversion resolves the prior multiple-H1 violation and makes headings searchable and task-based, directly satisfying HELP_AUTHORING_GUIDELINES Sections 2 and 4.
  • Positive: internalScope added to both files with clear audience, coverage, and exclusions, matching the TEMPLATE.md metadata requirement.
  • Positive: Accounting-method logic is now consistent across the Export and Advanced sections and the FAQ, and the previously contradictory reimbursable-export FAQ in New Expensify was corrected.
  • Positive: Cross-links use descriptive anchor text ("Learn how to choose the NetSuite Accounting Method"), relative anchors, and are placed in explanatory sentences rather than inside numbered steps, per Section 7.
  • Minor: In the Classic file, new step blocks start navigation with **Settings > Workspaces** rather than a navigation tab. This reflects the Classic UI, and the naming conventions are primarily NewDot-oriented, so it is acceptable, but the placeholder/path style differs from the NewDot rules.
  • Minor: New Classic content correctly uses lowercase [workspace name], while surrounding unchanged legacy lines still use [Workspace Name] and Settings > Workspace > Group. This creates in-file inconsistency, though the legacy lines are outside this PR's diff and are not scored.
  • Minor: Multiple empty <a id="..."> anchors were added to preserve redirect targets. These are reasonable for link stability but add markup noise; worth confirming they are all still referenced.

Recommendations

  • Priority: None blocking. The changes are publishable as-is.
  • Consider tightening the reworked FAQ answer "Why do company card expenses export immediately, but reimbursable expenses don't?" into two short bullets to preserve scannability lost when the bullet list was collapsed into a paragraph.
  • Optional: In a future pass, align the legacy Classic navigation paths ([Workspace Name], Group) with the lowercase-placeholder convention now used in the new sections for whole-file consistency.
  • Optional: Verify each newly added <a id> anchor corresponds to a real inbound link so no dead anchors are introduced.

Files Reviewed

  • /home/runner/_work/App/App/docs/articles/new-expensify/connections/netsuite/Configure-Netsuite.md - Strong. Correct navigation-tabs phrasing, task-based headings, internalScope added, corrected FAQ.
  • /home/runner/_work/App/App/docs/articles/expensify-classic/connections/netsuite/Configure-Netsuite.md - Strong. Title casing fixed, heading hierarchy corrected, new accounting-method steps and FAQ added; minor legacy/new placeholder inconsistency (unchanged lines only).

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott stephanieelliott added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Nov 18, 2026
@stephanieelliott
stephanieelliott requested review from stephanieelliott and removed request for stephanieelliott November 18, 2026 03:30
@garrettmknight

Copy link
Copy Markdown
Contributor

@stephanieelliott one tiny comment outstanding, but otherwise it's good.

@stephanieelliott
stephanieelliott requested review from stephanieelliott and removed request for stephanieelliott November 18, 2026 23:22
@kadiealexander
kadiealexander merged commit a7dd709 into main Nov 19, 2026
26 of 28 checks passed
@kadiealexander
kadiealexander deleted the claude-netSuiteAutoExportDocs branch November 19, 2026 02:56
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/kadiealexander in version: 9.5.43-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/kadiealexander in version: 9.5.47-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/kadiealexander in version: 9.5.51-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.51-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants