Repository navigation
Conversation
…licateTransactionViolation and getChangeTransactionsReportOnyxData
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safaritest.movtest2.mov |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
situchan
left a comment
There was a problem hiding this comment.
QA steps don't reach the changed lookup
The new personalDetailsByLogins is only read when a submitted report on a workspace with Basic or Advanced approvals looks up its next approver by email.
QA case A runs on an open report and case B on a manual submit workspace.
Both end in "waiting for submit" or "add expense", so neither reaches the changed code.
Lines 359 to 361 in 32ec409
Suggested extra QA case:
- Precondition: workspace with approvals on. A is the admin and approver, B is a member. B has a submitted report with duplicate expenses.
- As B, open the report.
- Go offline.
- Press Review duplicates > Keep all.
- Verify that next step shows "Waiting for A to approve".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32ec409de2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Found 2 unrelated bugs which already happen on production Bug1: Sometimes Review duplicates page shows not found view bug1.movBug2: bug2.mov |
|
Oxlint check failing |
|
Done |
|
No product review required. This is a personal details refactor. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.43-0 🚀
|
|
No help site update needed — this PR fixes report next-step updates to reflect expected behavior, without adding a feature, changing documented workflows, or making existing article text incorrect. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.47-0 🚀
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.51-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.51-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #66391
PROPOSAL:
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
A.
Prerequisite: have duplicate expenses on a report
B.
Prerequisite: use a manual submit workspace
C.
Precondition: workspace with approvals on. A is the admin and approver, B is a member. B has a submitted report with duplicate expenses.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
resolve.dupe.mp4
change.report.mp4