Skip to content

Open and delete legacy unreported expenses that have no IOU action - #107101

Merged
mountiny merged 4 commits into
Expensify:mainfrom
callstack-internal:VickyStash/bugfix/106850-legacy-expense-fail-to-open
Nov 21, 2026
Merged

mountiny merged 4 commits into
Expensify:mainfrom
callstack-internal:VickyStash/bugfix/106850-legacy-expense-fail-to-open

Conversation

@VickyStash

@VickyStash VickyStash commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Some legacy unreported expenses have no IOU action. Search reads the expense owner from that action, so a missing action made tapping the expense in Spend -> Expenses do nothing, and hid the Delete option.

When an unreported expense has no IOU action, the owner is now decided from the transaction:

  • An expense that isn't on a managed card belongs to the current user, because only its owner can see an unreported expense.
  • A managed card expense belongs to the current user only if they hold the card, because workspace admins also see members' card expenses on their card feeds.

Opening such an expense creates its thread in the current user's self DM. The transaction is passed along, so the existing legacy fallback in openReport builds the missing IOU action and asks the backend to create it. createTransactionThreadReport takes a new optional isOwnedByCurrentUser param, since without an action it can't tell the expense is the user's.

canDeleteMoneyRequestReport uses the same rule, so the Delete option shows for these expenses.

Another member's card expense with no IOU action, which an admin can see on their card feed, isn't covered here. It will be handled after BE https://github.com/Expensify/Expensify/issues/705811 is fixed.

Fixed Issues

$ #106850
PROPOSAL: N/A

Tests

These steps need an account with a legacy unreported expense that has no IOU action, like the one in the issue. New expenses always get one.

  1. Sign in as a user with a legacy unreported expenses that has no IOU action.
  2. Go to Spend > Expenses and tap one expense.
  3. Verify it opens in the RHP.
  4. Go back, select another expense and open the bulk actions menu.
  5. Verify Delete is available, and that deleting removes the expense.
  6. Tap one of your regular unreported expenses and verify it still opens as before.
  7. As a workspace admin, tap a member's unreported company card expense (not legacy one) in Spend > Expenses and verify it still opens as before.
  • Verify that no errors appear in the JS console

Before (staging):

before.mp4

After (current branch):

after.mp4

Offline tests

Same as tests.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari
after.mp4
web_not_legacy_expances.mp4

@melvin-bot

melvin-bot Bot commented Nov 19, 2026

Copy link
Copy Markdown

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@codecov

codecov Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/hooks/useSelectedTransactionsActions.ts 80.14% <ø> (ø)
src/libs/ReportUtils.ts 91.12% <100.00%> (-0.02%) ⬇️
src/libs/SearchUIUtils.ts 79.85% <100.00%> (+0.01%) ⬆️
src/libs/TransactionUtils/index.ts 95.55% <100.00%> (+0.01%) ⬆️
src/libs/actions/Report/index.ts 76.79% <100.00%> (+0.17%) ⬆️
... and 9 files with indirect coverage changes

@VickyStash
VickyStash force-pushed the VickyStash/bugfix/106850-legacy-expense-fail-to-open branch from 85d452f to a1a30ed Compare November 19, 2026 10:18
…-to-open

# Conflicts:
#	src/libs/TransactionUtils/index.ts
@VickyStash
VickyStash marked this pull request as ready for review November 19, 2026 11:14
@VickyStash
VickyStash requested review from a team as code owners November 19, 2026 11:14
@expensify-chore-bot
expensify-chore-bot Bot requested review from ZhenjaHorbach and removed request for a team November 19, 2026 11:15
@expensify-chore-bot

Copy link
Copy Markdown

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@expensify-chore-bot
expensify-chore-bot Bot requested review from garrettmknight and removed request for a team November 19, 2026 11:15
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T11:29:40.026938Z f512b1d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

Comment thread src/libs/SearchUIUtils.ts
const ownerAction = ownSelfDMAction ?? item.reportAction;

// A legacy unreported expense can have no IOU action at all. With no action and no report, `from` holds only the card holder.
const isOwnExpense = ownerAction

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but one case is still not covered: a legacy unreported Expensify Card expense on the user's own card still won't open if that card was deactivated (for example, replaced after it was lost, or deactivated by an admin).

Why: with no IOU action, ownership depends on from, and from comes from the card list. A deactivated Expensify Card is removed from the holder's cardList and from the workspace card lists, and later API responses leave out deactivated virtual cards and older deactivated physical cards. So from is empty, isOwnExpense is false, and tapping the expense still does nothing. Delete is not affected, because Expensify Card expenses can't be deleted anyway. Closed company cards are not affected either, because unassigning a company card deletes its unreported expenses.

A frontend fallback that treats an unknown card as the user's own card isn't safe. The admin's workspace card list drops the deactivated card too, so a member's expense would then look like the admin's own.

Suggestion: add this case to https://github.com/Expensify/Expensify/issues/705811, so the backend fix covers it too, either by returning the owner's accountID on the Search transaction or by creating the missing IOU action. Either one would fix the admin case and this case together. It would also help to say in the comment above isOwnExpense that an unknown card fails closed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: add this case to https://github.com/Expensify/Expensify/issues/705811, so the backend fix covers it too, either by returning the owner's accountID on the Search transaction or by creating the missing IOU action. Either one would fix the admin case and this case together. It would also help to say in the comment above isOwnExpense that an unknown card fails closed.

@mountiny @mollfpr Is it possible to return owner's accountID on the Search transaction?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mollfpr what do you think? the transaaction's owner is derived value that is not saved on the transactions table, but technically if it simlifies things a lot we could return that

@github-actions

This comment has been minimized.

@ZhenjaHorbach

ZhenjaHorbach commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-11-20.at.14.45.20.mov
Android: mWeb Chrome
Screen.Recording.2026-11-20.at.14.47.51.mov
iOS: HybridApp
Screen.Recording.2026-11-20.at.14.45.20.mov
iOS: mWeb Safari
Screen.Recording.2026-11-20.at.14.47.51.mov
MacOS: Chrome / Safari
Screen.Recording.2026-11-20.at.14.41.49.mov
Screen.Recording.2026-11-20.at.14.42.18.mov

@melvin-bot
melvin-bot Bot requested a review from mountiny November 20, 2026 13:49
@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

Changes look good!

@garrettmknight garrettmknight left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a product perspective.

@mountiny
mountiny merged commit 906133a into Expensify:main Nov 21, 2026
48 of 55 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.52-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this bug fix restores expected opening and deletion of legacy unreported expenses without adding a new workflow or making existing guidance incorrect.


view run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants