Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contributingGuides/LINTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -185,5 +185,6 @@ The env-var names and TSV format are unchanged from the previous `eslint-seatbel
- [Ratcheting errors](https://www.notion.com/blog/how-we-evolved-our-code-notions-ratcheting-system-using-custom-eslint-rules).
- [`CONSISTENCY-5`: Justify lint rule disables](../.claude/skills/app-coding-standards/rules/consistency-5-justify-eslint-disable.md) — when `eslint-disable` is acceptable, and how to document it.
- `rulesdir/no-manual-memoization` forbids `React.memo`, `useMemo`, and `useCallback` when React Compiler memoizes the file. Callbacks passed to `useFocusEffect` may retain `useCallback`, which React Navigation requires.
- `rulesdir/no-opaque-namespace-usage` forbids the `import * as NS` usages of an internal module that knip cannot track: a computed key (`NS[key]`), enumeration (`Object.keys(NS)`, `for...in`, `for...of`), rest destructuring (`const {a, ...rest} = NS`), a destructuring default (`const {a = NS} = obj`) and a namespace assigned to a variable that is never member-accessed (`const alias = NS`, `const x = cond ? NS : other`). Knip then treats every export of the module as used, so unused exports stay hidden. Import the members by name, or access them as `NS.member`.
- [`STYLE.md`](./STYLE.md) — the coding style rules many of our ESLint rules enforce.
- [`REACT_COMPILER.md`](./REACT_COMPILER.md) — separate compiler-compliance CI check that runs alongside lint.
296 changes: 296 additions & 0 deletions eslint-plugin-local-rules/no-opaque-namespace-usage.js

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions oxlint.config.mts
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ export default await buildOxlintConfig({
'rulesdir/no-layout-spacing-conditional': 'error',
'rulesdir/no-onyx-get-snapshot-key': 'error',
'rulesdir/no-onyx-loading-status': 'error',
'rulesdir/no-opaque-namespace-usage': 'error',
'rulesdir/no-raw-typography': 'error',
'rulesdir/no-unsafe-onyx-read': 'error',
'rulesdir/prefer-type-fest': 'error',
Expand Down
23 changes: 22 additions & 1 deletion src/components/Icon/GroupDefaultAvatars.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,25 @@ import Avatar16 from '@assets/images/avatars/group/default-avatar_16.svg';
import Avatar17 from '@assets/images/avatars/group/default-avatar_17.svg';
import Avatar18 from '@assets/images/avatars/group/default-avatar_18.svg';

export {Avatar1, Avatar2, Avatar3, Avatar4, Avatar5, Avatar6, Avatar7, Avatar8, Avatar9, Avatar10, Avatar11, Avatar12, Avatar13, Avatar14, Avatar15, Avatar16, Avatar17, Avatar18};
const groupDefaultAvatars = {
Avatar1,
Avatar2,
Avatar3,
Avatar4,
Avatar5,
Avatar6,
Avatar7,
Avatar8,
Avatar9,
Avatar10,
Avatar11,
Avatar12,
Avatar13,
Avatar14,
Avatar15,
Avatar16,
Avatar17,
Avatar18,
};

export default groupDefaultAvatars;
4 changes: 3 additions & 1 deletion src/components/Icon/MCCIcons.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,6 @@ import Services from '@assets/images/MCCGroupIcons/MCC-Services.svg';
import Taxi from '@assets/images/MCCGroupIcons/MCC-Taxi.svg';
import Utilities from '@assets/images/MCCGroupIcons/MCC-Utilities.svg';

export {Airlines, Commuter, Gas, Goods, Groceries, Hotel, Mail, Meals, Rental, Services, Taxi, Miscellaneous, Utilities};
const mccIcons = {Airlines, Commuter, Gas, Goods, Groceries, Hotel, Mail, Meals, Rental, Services, Taxi, Miscellaneous, Utilities};

export default mccIcons;
4 changes: 3 additions & 1 deletion src/components/Icon/WorkspaceDefaultAvatars.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import WorkspaceX from '@assets/images/avatars/workspace/default-avatar_x.svg';
import WorkspaceY from '@assets/images/avatars/workspace/default-avatar_y.svg';
import WorkspaceZ from '@assets/images/avatars/workspace/default-avatar_z.svg';

export {
const workspaceDefaultAvatars = {
Workspace0,
Workspace1,
Workspace2,
Expand Down Expand Up @@ -75,3 +75,5 @@ export {
WorkspaceZ,
WorkspaceBuilding,
};

export default workspaceDefaultAvatars;
4 changes: 2 additions & 2 deletions src/hooks/useEReceipt.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as eReceiptBGs from '@components/Icon/EReceiptBGs';
import * as MCCIcons from '@components/Icon/MCCIcons';
import MCCIcons from '@components/Icon/MCCIcons';
import type {TransactionListItemType} from '@components/Search/SearchList/ListItem/types';

import {getTransactionDetails} from '@libs/ReportUtils';
Expand Down Expand Up @@ -31,7 +31,7 @@ export default function useEReceipt(transactionData: Transaction | TransactionLi
const titleColor = colorStyles?.titleColor;
const transactionDetails = getTransactionDetails(transactionData);
const transactionMCCGroup = transactionDetails?.mccGroup;
const MCCIcon = transactionMCCGroup ? MCCIcons[`${transactionMCCGroup}`] : undefined;
const MCCIcon = transactionMCCGroup ? MCCIcons[transactionMCCGroup] : undefined;
const tripIcon = getTripEReceiptIcon(expensifyIcons, transactionData);

const backgroundImage = backgroundImages[colorCode];
Expand Down
4 changes: 2 additions & 2 deletions src/libs/ReportUtils.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import FallbackAvatar from '@assets/images/avatars/fallback-avatar.svg';

import * as defaultGroupAvatars from '@components/Icon/GroupDefaultAvatars';
import * as defaultWorkspaceAvatars from '@components/Icon/WorkspaceDefaultAvatars';
import defaultGroupAvatars from '@components/Icon/GroupDefaultAvatars';
import defaultWorkspaceAvatars from '@components/Icon/WorkspaceDefaultAvatars';
import type {LocaleContextProps, LocalizedTranslate} from '@components/LocaleContextProvider';
import type {MoneyRequestAmountInputProps} from '@components/MoneyRequestAmountInput';
import type {PersonalDetailsByLogin} from '@components/PersonalDetailsByLoginProvider';
Expand Down
4 changes: 2 additions & 2 deletions tests/tooling/noManualMemoization.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {Linter} from 'eslint';
import type {LintMessage} from '../../scripts/lint/types';

import checkReactCompilerWithOxc from '../../config/reactCompiler/checkWithOxc.mjs';
import * as rule from '../../eslint-plugin-local-rules/no-manual-memoization';
import {create, meta} from '../../eslint-plugin-local-rules/no-manual-memoization';
import {filterReactCompilerMessages} from '../../scripts/lint/processors/ReactCompilerFilter';
import {LINT_SEVERITY} from '../../scripts/lint/types';

Expand All @@ -16,7 +16,7 @@ function isRuleModule(value: unknown): value is Rule.RuleModule {
}

function lint(code: string) {
const ruleModule: unknown = rule;
const ruleModule: unknown = {create, meta};
if (!isRuleModule(ruleModule)) {
throw new TypeError('Expected a local ESLint rule module');
}
Expand Down
Loading
Loading