Skip to content

[HOLD] Use shouldShow from Auth to hide NewDot payment actions - #107147

Merged
deetergp merged 2 commits into
mainfrom
carlos-invoice-payment-shouldshow
Nov 19, 2026
Merged

deetergp merged 2 commits into
mainfrom
carlos-invoice-payment-shouldshow

Conversation

@cead22

@cead22 cead22 commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

This PR removes the App workarounds from #105968 for payment actions on invoices, as asked in this review. It must wait for Auth https://github.com/Expensify/Auth/pull/26804 to deploy. It's built on #105968, so its diff includes #105968 until that merges.

NewDot hides REIMBURSED and MARKED_REIMBURSED actions created from NewDot, because it shows an IOU PAY action instead. Paying a bill adds a payment action to its linked invoice, but no IOU PAY action. #105968 made App show these actions on invoices by checking the report type. Auth now sets shouldShow with the report type, so App only reads shouldShow:

  • shouldReportActionBeVisible no longer checks isNewDot or the report type, and no longer takes isInvoice.
  • Search no longer passes isInvoice.
  • The visibility cache stores payment actions again, except MARKED_REIMBURSED, whose visibility depends on its IOU PAY action as before.

App still hides a MARKED_REIMBURSED action that has an IOU PAY action next to it. That keeps the PayInvoice MARKED_REIMBURSED action hidden.

Payment actions that App saved before the Auth deploy keep their old shouldShow until Auth sends them again, for example when the report is opened. A NewDot REIMBURSED action saved that way could show next to its IOU PAY action until then.

Fixed Issues

For https://github.com/Expensify/Expensify/issues/684654
PROPOSAL: N/A

Tests

  1. Sign in as a policy admin who can pay expense reports with a bank account.
  2. Pay an expense report with the bank account. Verify the report shows one payment message, from the IOU PAY action.
  3. Mark another expense report as paid outside Expensify. Verify it shows one payment message.
  4. Send an invoice to another account, and pay it as the receiver. Verify the invoice shows one payment message.
  5. Sign in as a vendor with an invoice linked to a bill that was paid. Open the invoice. Verify it shows the payment message.
  6. Go to Search > Chats, and search for the invoice from step 5. Verify the payment message appears in the results.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests. Payment actions come from Auth, so their visibility doesn't change offline.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@cead22
cead22 requested review from a team as code owners November 17, 2026 17:49
@expensify-chore-bot
expensify-chore-bot Bot requested review from twisterdotcom and removed request for a team November 17, 2026 17:49
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T17:56:39.662245Z 19c6074 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@expensify-chore-bot
expensify-chore-bot Bot requested review from deetergp and removed request for a team November 17, 2026 17:50
@expensify-chore-bot

Copy link
Copy Markdown

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@twisterdotcom

Copy link
Copy Markdown
Contributor

No product review required. This moves payment message visibility to Auth.

@twisterdotcom
twisterdotcom removed their request for review November 18, 2026 11:10
…t-shouldshow

# Conflicts:
#	src/libs/ReportActionsUtils.ts
#	src/libs/actions/OnyxDerived/configs/visibleReportActions.ts
#	tests/unit/OnyxDerived/visibleReportActionsTest.ts
@codecov

codecov Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/libs/ReportActionsUtils.ts 86.80% <100.00%> (-0.06%) ⬇️
src/libs/SearchUIUtils.ts 80.02% <100.00%> (ø)
...ctions/OnyxDerived/configs/visibleReportActions.ts 92.77% <66.66%> (-0.34%) ⬇️
... and 8 files with indirect coverage changes

@deetergp

Copy link
Copy Markdown
Contributor

@MelvinBot review

@MelvinBot

Copy link
Copy Markdown
Contributor

No actionable code-review findings.

  • Focused visibility, Search, and derived-value unit tests: 1,433 passed.
  • Keep the deployment hold: I couldn’t access the Auth prerequisite to verify its status.
  • Rollout caveat: stale cached flags can also hide previously visible invoice payment messages until refetch—not only introduce duplicates. Offline upgrade coverage would be useful.

No browser verification performed.


view run

@deetergp deetergp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deetergp
deetergp merged commit 0442fa6 into main Nov 19, 2026
44 of 45 checks passed
@deetergp
deetergp deleted the carlos-invoice-payment-shouldshow branch November 19, 2026 23:54
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 deetergp has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/deetergp in version: 9.5.52-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR moves existing payment-message visibility logic to Auth without introducing a new workflow or making an existing article factually incorrect.


view run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants