Repository navigation
[HOLD] Use shouldShow from Auth to hide NewDot payment actions - #107147
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No product review required. This moves payment message visibility to Auth. |
…t-shouldshow # Conflicts: # src/libs/ReportActionsUtils.ts # src/libs/actions/OnyxDerived/configs/visibleReportActions.ts # tests/unit/OnyxDerived/visibleReportActionsTest.ts
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@MelvinBot review |
|
No actionable code-review findings.
No browser verification performed. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 deetergp has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/deetergp in version: 9.5.52-1 🚀
|
|
No help site update needed — this PR moves existing payment-message visibility logic to Auth without introducing a new workflow or making an existing article factually incorrect. |
Explanation of Change
This PR removes the App workarounds from #105968 for payment actions on invoices, as asked in this review. It must wait for Auth https://github.com/Expensify/Auth/pull/26804 to deploy. It's built on #105968, so its diff includes #105968 until that merges.
NewDot hides REIMBURSED and MARKED_REIMBURSED actions created from NewDot, because it shows an IOU PAY action instead. Paying a bill adds a payment action to its linked invoice, but no IOU PAY action. #105968 made App show these actions on invoices by checking the report type. Auth now sets
shouldShowwith the report type, so App only readsshouldShow:shouldReportActionBeVisibleno longer checksisNewDotor the report type, and no longer takesisInvoice.isInvoice.App still hides a MARKED_REIMBURSED action that has an IOU PAY action next to it. That keeps the
PayInvoiceMARKED_REIMBURSED action hidden.Payment actions that App saved before the Auth deploy keep their old
shouldShowuntil Auth sends them again, for example when the report is opened. A NewDot REIMBURSED action saved that way could show next to its IOU PAY action until then.Fixed Issues
For https://github.com/Expensify/Expensify/issues/684654
PROPOSAL: N/A
Tests
Offline tests
Same as tests. Payment actions come from Auth, so their visibility doesn't change offline.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari