Repository navigation
Show the column menu on icon-only Spend headings, swapping the icon for the caret on hover - #107261
Conversation
…he icon for the caret on hover
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Krishna2323
left a comment
There was a problem hiding this comment.
Heads-up: once #106750 lands, the report table will pass children here as well. Its Comments heading has neither a label nor an icon, so it would end up with a blank menu. That PR relied on !!label to skip it, and Git won't flag this as a conflict.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMonosnap.screencast.2026-11-18.22-52-50.mp4 |
|
@war-in conflicts |
…n-caret # Conflicts: # src/components/Search/SearchColumnMenu.tsx
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.43-0 🚀
|
|
No help site update needed — this fixes existing column-menu behavior for icon-only headings behind the |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.47-0 🚀
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.51-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.51-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Icon-only Spend headings (Avatar) never got the column menu, because
SortableTableHeaderonly built it for headings with text. Now every heading gets the menu, and icon-only ones are named like on the Columns page for screen readers. Those headings are too narrow for a caret beside the icon, so on hover the caret replaces the icon, as agreed with design in the issue.Fixed Issues
$ #106707
PROPOSAL:
Tests
Prerequisite: account with the
pinnableTableColumnsbeta and at least one expense report. Wide layout (desktop).Offline tests
N/A, UI only. Hiding the column works the same as it does from any other column's menu.
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari