Repository navigation
Conversation
|
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer Checklist
Screenshots/VideosiOS: HybridAppScreen.Recording.2026-11-19.at.01.41.42.mov |
|
@war-in We have conflicts |
…bubble-flash # Conflicts: # patches/react-native-screens/details.md
|
conflicts resolved, @mountiny it's all yours |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.52-1 🚀
|
Explanation of Change
On first mount react-native-screens selects the restored tab with animation before the tab bar is in a window. On iPhone Duo the bar then moves into the vertical column, so that animation morphed the bubble from the bottom bar's shape. New RNS patch 009 selects without animation while off screen. The vertical bar module also reads the edge at creation, so the first render is already vertical.
Fixed Issues
$ #107266
$ #107267
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
duo-bubble-before-after.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari