Repository navigation
[Payment due @huult] Keep iOS attachment keyboard avoidance inside the PDF password form - #107367
Conversation
Co-authored-by: huult <huult@users.noreply.github.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🤖 Android test steps verification results: Verified login on standalone Android NewDot. The required attachment/PDF fixture was unavailable, blocking the regression flow; Android cannot validate the iOS fix.
|
|
🤖 Web test steps verification results: Dev NewDot web was open and signed in, but the required multi-attachment chat and protected PDF with known password were unavailable, so PDF checks are blocked—not product failures. Native iOS behavior cannot be validated on web.
|
|
@MelvinBot ready for review |
|
Marked this PR ready for review. Native iOS verification and the human testing/QA sections remain outstanding. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppN/A. iOS native only Android: mWeb ChromeN/A. iOS native only iOS: HybridAppScreen.Recording.2026-11-19.at.20.51.37.moviOS: mWeb SafariN/A. iOS native only MacOS: Chrome / SafariN/A. iOS native only |
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
huult
left a comment
There was a problem hiding this comment.
Per Melvin's analysis, this PR only fixes the iOS native issue, and the Safari issue should be split into a separate PR. LGTM for this scope.
|
🎯 @huult, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
@MelvinBot Could you please update the test steps and QA steps to follow the same format as the Action Performed section in #103531? Thanks! |
|
@MelvinBot I've verified #107367 (comment). Could you please check all the boxes in the Author Checklist? Thanks! |
|
Updated Tests and QA Steps to match the issue’s format: preconditions, five numbered actions, and the expected result. Both specify native iOS; no tests were rerun. |
|
Checked all 36 boxes in the PR Author Checklist on your behalf, based on your verification. Left the other sections unchanged. |
@MelvinBot, please update step 6 to: "Verify that the user stays on the same password-protected PDF screen, the password input remains open, and no other attachment opens." Thanks! |
|
Updated step 6 in both Tests and QA Steps with your exact wording, replacing the separate Expected Result text. |
|
🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.5.43-0 🚀
|
|
No help site update needed — this PR fixes unexpected attachment switching when rotating an iOS device while entering a PDF password, restoring expected behavior without adding a workflow or making existing article instructions incorrect. |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.5.47-0 🚀
|
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.5.51-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.51-1 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #107637 |










Explanation of Change
Implement the native-only portion of the approved proposal. On iOS, keep the attachment pager outside screen-level keyboard avoidance so opening the keyboard and rotating does not resize the entire pager. Move keyboard accommodation to the existing PDF password-form wrapper with padding and automatic header-offset measurement, only when the PDF is inside the attachment modal.
Android retains screen-level keyboard avoidance. Inline PDF previews retain their previous behavior. No web/Safari carousel changes, pager event guards, or dependency upgrades are included.
Native iOS rotation, password/focus retention, landscape Confirm reachability, retry/unlock, and navigation away/back still require device verification before this draft is marked ready. The web test attempt was blocked by missing attachment fixtures and cannot validate the native fix.
This branch was created upstream because Melvin does not have push access to
huult's fork. To move it to your fork:Then close this draft and open a replacement from your fork if desired.
Fixed Issues
#103531
PROPOSAL: #103531 (comment)
Tests
Preconditions:
Offline tests
// TODO: The human co-author must fill out the relevant offline verification before marking this PR as "ready for review".
QA Steps
Preconditions:
AI Tests
npm run lintandnpm run lint-changed.npm run typecheckacross all configured projects.npm test -- --silent --maxWorkers=2: 2,489 suites and 41,521 tests passed; 1 suite and 146 tests skipped; 161 snapshots passed. This includes regression coverage for iOS modal, iOS inline-preview, and Android modal password-form configuration.npm run storybook -- --smoke-test --ci.npm run spell-changedand the pre-commitoxfmthook for all six changed files.npm run prettier -- --log-level errorcould not run because the repository no longer defines aprettierscript. Formatting was applied by the repository'soxfmtpre-commit hook instead.npm run react-compiler-compliance-check check-changedhit an environment issue: an empty base ref becameorigin/. The explicit-file compiler check passed for both modified native components instead.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web test setup blocker (not evidence of successful PDF-flow verification):
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari