Repository navigation
[Payment due @Krishna2323] [No QA][Fullstory] Mask the magic code modal and secret inputs - #107378
Conversation
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Krishna2323
left a comment
There was a problem hiding this comment.
The Sage Intacct, Business Central, Rillet, Campfire, and DualEntry inputs already pass forwardedFSClass={CONST.FULLSTORY.CLASS.MASK} on main (introduced in dabe0dc6832), so they were already masked before this PR. Step 2 therefore passes on main as well.
Currently, the BaseTextInput default only changes the PDF password input. Could you update the explanation to reflect this and make the PDF password input the primary test step?
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppMonosnap.screencast.2026-11-20.03-52-35.mp4Android: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMonosnap.screencast.2026-11-20.03-45-02.mp4 |
|
🎯 @Krishna2323, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
…c-code-secret-inputs
…c-code-secret-inputs
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.52-1 🚀
|
|
No help site update needed — this PR only masks sensitive values in Fullstory recordings; it adds no user-facing workflow and does not make existing help instructions incorrect. |
Explanation of Change
Masks two more values in Fullstory recordings, as part of the masking work that started with #105601.
ValidateCodeModal. When a browser that's already signed in opens a magic link, the modal shows the code as plain text, and it was recorded unmasked.secureTextEntry. Once the eye toggle reveals the value, it's plain text, soBaseTextInputnow defaults these inputs tofs-maskfrom the declared prop: thesecureTextEntryit passes down follows the toggle and isfalseexactly when the value is visible. A class passed by the caller still wins. Today this only changes the PDF password input, since the accounting credential inputs (Sage Intacct, Business Central, Campfire, DualEntry, Rillet) already pass the mask since dabe0dc. It also makes any future secret input masked without the call site having to opt in.The revealed physical card PIN is masked by #107159.
Fullstory test sessions:
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/693315
PROPOSAL:
Tests
How to check
Web: check the DOM
npm run weband open the screen.<input>itself, or thedivrendering the text.fs-maskclass, or no class of its own under an ancestor withfs-mask. If the element itself hasfs-unmask, it gets recorded.Native: check the component tree
jin the bundler terminal, or use the dev menu › Open DevTools.TextInputthat holds the value.fsClassprop must befs-mask.Prerequisites: a validated account, admin of a Collect or Control workspace.
https://dev.new.expensify.com:8082/v/<yourAccountID>/123456.123456carriesfs-mask.fs-mask. Before this PR it carriedfs-unmask.fs-mask.https://dev.new.expensify.com:8082/workspaces/<policyID>/accounting/sage-intacct/enter-credentials.fs-mask, before and after revealing it. These pages already passed the mask, so nothing changes here.fs-unmask.Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari