Repository navigation
fix: end the Spend sidebar peek once a saved search menu closes off the sidebar - #107400
Conversation
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16bf4b5030
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Other than the comments above, this looks good to me. |
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safariweb_chrome.mp4 |
| // The menu calls this once it is gone, and the pointer is read against the sidebar instead. | ||
| // Keyboard focus holds the peek too: Escape returns focus to the menu's button, and collapsing would unmount it and drop focus. | ||
| // Only keyboard focus counts, because a row clicked with the mouse keeps focus too and must not hold the peek after the pointer leaves. | ||
| const endPeekIfPointerLeft = () => { |
There was a problem hiding this comment.
NAB: This duplicates the hover and keyboard focus checks in FlatNavigationBar (hasKeyboardFocusInside and endPeekIfPointerAndFocusLeft). R2.2b will need the same logic for the bar's saved search menu, so it might be worth extracting a shared helper for both peek surfaces. isElementHovered in receiptHoverUtils already covers the hover check.
Krishna2323
left a comment
There was a problem hiding this comment.
LGTM! Left one NAB above if we want to address it before merging. Otherwise, we can handle it in R2.2b.
mountiny
left a comment
There was a problem hiding this comment.
Thanks for testing and review
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.52-1 🚀
|
|
No help site update needed — this PR fixes the navigation menu staying expanded after a saved-search menu closes, restoring expected behavior without adding a workflow or making existing instructions incorrect. |
Explanation of Change
Share closes the saved search menu by itself, and the portaled popover sends no hover-out, so the Spend sidebar kept peeking.
ThreeDotsMenugainsonModalHide, andSearchSidebarexposesendPeekIfPointerLeftthroughPeekSurfaceContext. Once the menu is gone, it ends the peek unless the pointer is over the sidebar. The flat nav bar follows in R2.2b.Fixed Issues
$ #107306
PROPOSAL:
Tests
Precondition: wide layout (desktop web), account with at least one saved search (Spend > set filters > Save search).
Test 1: Sidebar collapses after Share with the pointer outside it (the fix)
Test 2: Sidebar keeps peeking while the pointer is inside it
Test 3: Other ways of closing the menu
Offline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
web.mov