Skip to content

[No QA] Redact Expensify Card PIN and card details in logs - #107402

Merged
deetergp merged 1 commit into
mainfrom
flo-redactCardSecretsInLogs
Nov 19, 2026
Merged

deetergp merged 1 commit into
mainfrom
flo-redactCardSecretsInLogs

Conversation

@flodnv

@flodnv flodnv commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

The API logs every request's parameters and failed responses, and the log sanitizer had no entry for pin, pan, cvv or expiration. So App sent the Expensify Card PIN unredacted to the Log command, where Web-Expensify redacted it before writing the log. App also showed the PIN, card number, expiry and CVV from the card reveal responses in the browser console. This adds those keys to the sanitizer so App redacts them itself.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/704595
PROPOSAL: N/A

Tests

  1. Run npx jest tests/unit/sanitizeLogParamsTest.ts.
  2. Confirm all tests pass, including the two new tests for card PIN parameters and card reveal responses.
  • Verify that no errors appear in the JS console

Offline tests

None. The change only affects what gets logged.

QA Steps

None. QA can't see the server logs this changes.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A, no UI change.

Android: mWeb Chrome

N/A, no UI change.

iOS: Native

N/A, no UI change.

iOS: mWeb Safari

N/A, no UI change.

MacOS: Chrome / Safari

N/A, no UI change.

AI-assisted draft, reviewed and approved by @flodnv

@flodnv
flodnv requested review from a team as code owners November 19, 2026 13:30
@expensify-chore-bot
expensify-chore-bot Bot requested review from hoangzinh and removed request for a team November 19, 2026 13:30
@expensify-chore-bot

This comment has been minimized.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T13:33:34.228483Z 4efcbc4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@expensify-chore-bot
expensify-chore-bot Bot requested review from heyjennahay and removed request for a team November 19, 2026 13:30
@flodnv

flodnv commented Nov 19, 2026

Copy link
Copy Markdown
Contributor Author

C+ review not needed

@flodnv
flodnv requested a review from a team November 19, 2026 13:52
@expensify-chore-bot
expensify-chore-bot Bot requested review from truph01 and removed request for a team November 19, 2026 13:52
@expensify-chore-bot

This comment has been minimized.

@flodnv
flodnv requested review from a team and removed request for truph01 November 19, 2026 13:53
@expensify-chore-bot
expensify-chore-bot Bot requested review from deetergp and removed request for a team November 19, 2026 13:56
@expensify-chore-bot

Copy link
Copy Markdown

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@deetergp deetergp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@deetergp
deetergp merged commit 6e36edd into main Nov 19, 2026
49 of 50 checks passed
@deetergp
deetergp deleted the flo-redactCardSecretsInLogs branch November 19, 2026 23:24
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 deetergp has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/deetergp in version: 9.5.52-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR only redacts sensitive card details from logs, without changing user-facing features, workflows, or documented behavior.


view run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants