Skip to content

Fix Invalid URL error on the held expenses report link after a native cold start - #107441

Merged
lakchote merged 3 commits into
Expensify:mainfrom
David-2002065:fix/107179-cached-environment-url
Nov 20, 2026
Merged

lakchote merged 3 commits into
Expensify:mainfrom
David-2002065:fix/107179-cached-environment-url

Conversation

@David-2002065

@David-2002065 David-2002065 commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

On native, after a partial approval moves the held expense to a new report, reopening the app on that report logs Error parsing URL(s): TypeError: Invalid URL: undefined/r/<reportID>.

The "created this report for any held expenses from " message builds its href with getReportURLForCurrentContext, which read a module-level environmentURL that was only filled by a getEnvironmentURL().then(...) scheduled when the module was evaluated. On native, the inline-requires loader turns every import into a require() at its first use, and this helper is only called from a few rare messages, so after a cold start it gets evaluated inside its very first call, during render. The .then can only run on a later microtask, so that first call returns undefined/r/<reportID>, and AnchorRenderer throws while classifying it with new URL(...). React Compiler then keeps the memoized output, so the broken link stays.

This PR fixes it at the source for every caller of the helper (held expenses, moved report, unreported/self DM and harvest messages):

  • getEnvironment (native and web) exposes a sync getCachedEnvironment(). On native it returns the value getEnvironment already cached, which is resolved long before any report renders since the API root waits on it. Dev/adhoc builds come straight from the config.
  • Environment.ts exposes getCachedEnvironmentURL() built from it.
  • getReportURLForCurrentContext reads getCachedEnvironmentURL() on each call instead of its own async copy, so the very first call already has the real origin.

Tests:

  • tests/unit/getReportURLForCurrentContextTest.ts loads the native getEnvironment and a freshly evaluated helper, then calls it synchronously, the same as a cold start. On main both cases return undefined/r/123, with this change they return the dev and staging URLs.
  • tests/unit/GetEnvironmentNativeTest.ts covers getCachedEnvironment() returning the environment resolved by the beta check.

Fixed Issues

$ #107179
PROPOSAL: #107179 (comment)

Tests

Precondition: User A invites User B to a workspace and sets User B as the approver.

  1. As User A, submit two expenses on the same workspace report
  2. Log in as User B and open that report
  3. Hold one of the expenses
  4. Go back and approve, choosing to approve only the unheld expense
  5. Open the new report that has the held expense
  6. Verify the message "created this report for any held expenses from " shows
  7. Kill and reopen the app (refresh on web) while on that report
  8. Verify no Error parsing URL / Invalid URL error is logged in the console
  9. Tap the report link in that message and verify it opens the approved report inside the app
  • Verify that no errors appear in the JS console

Offline tests

  1. Do steps 1-6 above
  2. Go offline and reopen the app on the held expense report
  3. Verify the message shows and no Invalid URL error is logged

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android_native_after_107179.mp4
Android: mWeb Chrome
mweb_chrome_after_107179.mp4
iOS: Native
107179-after-ios.mp4
iOS: mWeb Safari
mweb_after_107179.mp4
MacOS: Chrome / Safari
web_chrome_after_107179.mp4

On native the report link helper is evaluated lazily on its first call, during render, so its async copy of the environment URL was still unset and links came out as undefined/r/<reportID>.
@codecov

codecov Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/libs/Environment/Environment.ts 100.00% <100.00%> (ø)
...rc/libs/Environment/getEnvironment/index.native.ts 100.00% <100.00%> (+14.28%) ⬆️
...avigation/helpers/getReportURLForCurrentContext.ts 100.00% <100.00%> (ø)
src/libs/Environment/getEnvironment/index.ts 0.00% <0.00%> (ø)
... and 143 files with indirect coverage changes

@David-2002065
David-2002065 marked this pull request as ready for review November 19, 2026 19:24
@David-2002065
David-2002065 requested review from a team as code owners November 19, 2026 19:24
@expensify-chore-bot
expensify-chore-bot Bot requested review from mukhrr and removed request for a team November 19, 2026 19:24
@expensify-chore-bot

Copy link
Copy Markdown

@mukhrr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@expensify-chore-bot
expensify-chore-bot Bot requested review from JmillsExpensify and removed request for a team November 19, 2026 19:24
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T19:42:43.505395Z b0e1b15 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No product review required.

@mukhrr

mukhrr commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
107441-after-android-native.mp4
Android: mWeb Chrome web cannot have this bug since it loads every module at startup.
iOS: HybridApp
107441-after-ios-native.mp4
iOS: mWeb Safari web cannot have this bug since it loads every module at startup.
MacOS: Chrome / Safari web cannot have this bug since it loads every module at startup.

Comment thread tests/unit/GetEnvironmentNativeTest.ts Resolved
Comment thread tests/unit/GetEnvironmentNativeTest.ts Resolved

@mukhrr mukhrr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@melvin-bot
melvin-bot Bot requested a review from lakchote November 20, 2026 07:24

@lakchote lakchote left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @David-2002065, looks good.

@lakchote lakchote left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@lakchote
lakchote merged commit 25e77ae into Expensify:main Nov 20, 2026
37 of 38 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 lakchote has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/lakchote in version: 9.5.52-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR restores expected behavior for existing report links after reopening the app, without adding a workflow or making existing help instructions incorrect.


view run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants