Repository navigation
Remove unused MenuItemGroup - #107502
Remove unused MenuItemGroup#107502
Conversation
Co-authored-by: Pujan Shah <Pujan92@users.noreply.github.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
I created this PR from an upstream branch because I do not have push access to the contributor fork. To copy it to your fork and push updates there: git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-removeMenuItemGroup-Pujan92
git checkout -b claude-removeMenuItemGroup-Pujan92 upstream/claude-removeMenuItemGroup-Pujan92
git push -u origin claude-removeMenuItemGroup-Pujan92You can then open a replacement PR from your fork and close this one. |
|
|
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
🤖 Android test steps verification results: Profile layout and navigation worked in the existing Android app, but its inclusion of this PR was not confirmed. Account-specific, keyboard, offline, and console checks remain incomplete; recording capture was not confirmed.
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppp1.webmAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-11-20.at.10.46.20.mov |
|
🤖 Web test steps verification results: Core Profile navigation worked in dev NewDot web, but inclusion of this PR’s head was not confirmed. Production comparison, several account-specific checks, keyboard/offline testing, and console inspection remain unverified.
view run · no recording available |
|
@MelvinBot as MenuItemGroup is primarily used to prevent fast double taps in native. Let's add only this flow in QA steps |
|
Updated QA Steps to focus only on native rapid-tap protection: double-tapping Profile rows or rapidly tapping different rows should open one destination, with a single Back returning to Profile. Removed the broader regression flows. |
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.52-1 🚀
|
|
No help site update needed — this PR removes unused internal menu-handling code without adding a feature, changing user-facing labels or workflows, or making existing article instructions incorrect. |




Explanation of Change
Remove the obsolete menu-item execution group now that Profile uses compound menu rows, which do not consume its contexts. Render the existing Profile children directly and remove the dead context-dependent execution and disabled handling from legacy MenuItem. Existing private-details navigation guards, delegate restrictions, layout, and accessibility props remain unchanged.
AI Tests
Fixed Issues
$ #107467
PROPOSAL:
Tests
// TODO: The human co-author must fill out the manual tests performed. Automated results and browser verification limitations are recorded under AI Tests above.
Offline tests
QA Steps
These are QA instructions, not claims of completed manual testing.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari