Skip to content

Remove unused MenuItemGroup - #107502

Merged
roryabraham merged 1 commit into
mainfrom
claude-removeMenuItemGroup-Pujan92
Nov 20, 2026
Merged

roryabraham merged 1 commit into
mainfrom
claude-removeMenuItemGroup-Pujan92

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Remove the obsolete menu-item execution group now that Profile uses compound menu rows, which do not consume its contexts. Render the existing Profile children directly and remove the dead context-dependent execution and disabled handling from legacy MenuItem. Existing private-details navigation guards, delegate restrictions, layout, and accessibility props remain unchanged.

AI Tests

  • Passed: full lint, changed-file lint, typecheck, spelling, Oxfmt, Storybook smoke test, and React Compiler checks for both modified components.
  • Passed: 6 focused Jest suites, 75 tests, covering Profile, legacy menu items, accessibility, copying, vacation delegates, and native single-execution protection.
  • Confirmed no remaining references to the removed component. Automated code review found no violations.
  • Incomplete: the full Jest run exceeded 20 minutes without a final summary. The changed-file React Compiler gate remains unverified; direct checks of both modified components passed.
  • Browser QA is blocked: the available dev browser rendered no app nodes and had no usable app session. No visual or interaction result is claimed; manual QA remains required.

Browser state blocking Profile verification

Fixed Issues

$ #107467
PROPOSAL:

Tests

// TODO: The human co-author must fill out the manual tests performed. Automated results and browser verification limitations are recorded under AI Tests above.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  1. On the native iOS or Android app, sign in and open Settings > Profile.
  2. Rapidly double-tap a profile row that opens an editor. Verify only one editor opens, then tap Back once and verify you return directly to Profile without another copy of the editor underneath.
  3. Repeat for each navigating public and private profile row. Also rapidly tap two different rows in succession and verify only one destination opens and a single Back returns to Profile.

These are QA instructions, not claims of completed manual testing.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: Pujan Shah <Pujan92@users.noreply.github.com>
@MelvinBot
MelvinBot requested review from a team as code owners November 20, 2026 03:49
@melvin-bot melvin-bot Bot added Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web labels Nov 20, 2026
@expensify-chore-bot
expensify-chore-bot Bot requested review from Pujan92 and removed request for a team November 20, 2026 03:49
@expensify-chore-bot

Copy link
Copy Markdown

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T03:51:24.548941Z a5c9df0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@expensify-chore-bot
expensify-chore-bot Bot requested review from dylanexpensify and removed request for a team November 20, 2026 03:49
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch because I do not have push access to the contributor fork. To copy it to your fork and push updates there:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-removeMenuItemGroup-Pujan92
git checkout -b claude-removeMenuItemGroup-Pujan92 upstream/claude-removeMenuItemGroup-Pujan92
git push -u origin claude-removeMenuItemGroup-Pujan92

You can then open a replacement PR from your fork and close this one.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

⚠️ The model API is currently overloaded. This is a temporary issue on the model provider's side. Try again in a few minutes, or check status.openai.com.

Run details

@codecov

codecov Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/MenuItem/MenuItem.tsx 93.14% <100.00%> (+0.56%) ⬆️
src/pages/settings/Profile/ProfilePage.tsx 94.31% <90.00%> (-0.07%) ⬇️
... and 8 files with indirect coverage changes

@MelvinBot

MelvinBot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Android test steps verification results: ⚠️ partial

Profile layout and navigation worked in the existing Android app, but its inclusion of this PR was not confirmed. Account-specific, keyboard, offline, and console checks remain incomplete; recording capture was not confirmed.

Profile private section with four navigating fields

Step Status
1. Profile layoutPublic/private sections, avatar, labels, supporting values, and chevrons displayed. Existing session was signed in; wide/narrow web comparison was outside Android scope.
Profile public section with avatar, details, and chevrons
Profile private section with four navigating fields
✅
2. Public-row navigationDisplay name, pronouns, timezone, contact methods, and status opened expected editors. Back returned to Profile after each.
✅
3. Private fields and rapid activationLegal name, birth date, phone, and address opened Basic details. Double-tapping each row followed by one Back returned directly to Profile; no stacked editor was observed.
✅
4. Avatar editor and ShareAvatar selection and profile QR sharing opened successfully. Back returned to Profile.
✅
5. Vacation delegateUnconfigured row opened delegate selection. Configured-delegate and acting-as-delegate accounts were unavailable, leaving access restrictions unverified.
⚠️
6. Accessibility and keyboard navigationRows exposed button roles and descriptive labels. Tab/Enter activation and focus order were not verified.
⚠️
7. Offline and reconnectNetwork controls were unavailable under tester restrictions. Offline caching, editor return, and reconnect were not verified.
⚠️
8. Agent-account AI promptNo agent-account fixture was available. Display, saving, and pending/error feedback were not verified.
⚠️
9. JavaScript console errorsNo visible error screen appeared, but diagnostic logs were inaccessible; absence of console errors could not be confirmed.
⚠️

view run · view recording

@Pujan92

Pujan92 commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
p1.webm
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-11-20.at.10.46.20.mov

@MelvinBot

MelvinBot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Web test steps verification results: ⚠️ partial

Core Profile navigation worked in dev NewDot web, but inclusion of this PR’s head was not confirmed. Production comparison, several account-specific checks, keyboard/offline testing, and console inspection remain unverified.

Narrow web Profile layout

Step Status
1. Profile appearance on wide and narrow webPublic/private sections, avatar control, labels, values, and descriptions were present at 1920×1080 and 390×844 using the existing signed-in session. Production parity was not verified.
Wide web Profile sections and rows
Narrow web Profile layout
⚠️
2. Public editors and BackDisplay name, pronouns, timezone, contact methods, and status opened their corresponding editors and returned to Profile. Display-name Back required one retry.
✅
3. Private editors and duplicate-stack preventionAll four private rows opened Personal details and returned. Repeated Legal name activation returned with one Back, but subsequent repeated presses reached form validation; rapid-activation protection remains unverified.
⚠️
4. Avatar editor and ShareAvatar opened Edit profile picture; Share opened the QR code and Copy URL controls. Both returned to Profile.
✅
5. Vacation delegate states and restrictionsUnconfigured delegate navigation worked. Configured-delegate and acting-as-delegate fixtures were unavailable.
⚠️
6. Keyboard navigation and accessibilityLabeled row buttons and current values were exposed. Available tooling could not verify Tab/Enter activation or focus order.
⚠️
7. Offline and reconnectionAvailable tooling could not control connectivity; cached details, offline editor return, and reconnect behavior were not verified.
⚠️
8. Agent-account AI promptThe supplied normal-user account had no AI prompt section. Agent-account display, saving, and pending/error feedback were not verified.
⚠️
9. JavaScript console errorsConsole inspection was unavailable; absence of JavaScript errors could not be confirmed.
⚠️

view run · no recording available

@Pujan92

Pujan92 commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot as MenuItemGroup is primarily used to prevent fast double taps in native. Let's add only this flow in QA steps

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Updated QA Steps to focus only on native rapid-tap protection: double-tapping Profile rows or rapidly tapping different rows should open one destination, with a single Back returning to Profile. Removed the broader regression flows.


view run

@Pujan92 Pujan92 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melvin-bot
melvin-bot Bot requested a review from roryabraham November 20, 2026 05:16
@roryabraham
roryabraham merged commit 5d761f7 into main Nov 20, 2026
50 of 54 checks passed
@roryabraham
roryabraham deleted the claude-removeMenuItemGroup-Pujan92 branch November 20, 2026 07:07
@github-actions

Copy link
Copy Markdown
Contributor

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.52-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor Author

No help site update needed — this PR removes unused internal menu-handling code without adding a feature, changing user-facing labels or workflows, or making existing article instructions incorrect.


view run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants