Skip to content

Remove unnecessary wheel event handler from Composer #12918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roryabraham wants to merge 1 commit into from
Closed

Remove unnecessary wheel event handler from Composer #12918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions src/components/Composer/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,6 @@ class Composer extends React.Component {
this.paste = this.paste.bind(this);
this.handlePaste = this.handlePaste.bind(this);
this.handlePastedHTML = this.handlePastedHTML.bind(this);
this.handleWheel = this.handleWheel.bind(this);
this.shouldCallUpdateNumberOfLines = this.shouldCallUpdateNumberOfLines.bind(this);
}

Expand All @@ -163,7 +162,6 @@ class Composer extends React.Component {
document.addEventListener('dragleave', this.dragNDropListener);
document.addEventListener('drop', this.dragNDropListener);
this.textInput.addEventListener('paste', this.handlePaste);
this.textInput.addEventListener('wheel', this.handleWheel);
}
}

Expand Down Expand Up @@ -197,7 +195,6 @@ class Composer extends React.Component {
document.removeEventListener('dragleave', this.dragNDropListener);
document.removeEventListener('drop', this.dragNDropListener);
this.textInput.removeEventListener('paste', this.handlePaste);
this.textInput.removeEventListener('wheel', this.handleWheel);
}

/**
Expand Down Expand Up @@ -332,20 +329,6 @@ class Composer extends React.Component {
this.paste(Str.htmlDecode(plainText));
}

/**
* Manually scrolls the text input, then prevents the event from being passed up to the parent.
* @param {Object} event native Event
*/
handleWheel(event) {
if (event.target !== document.activeElement) {
return;
}

this.textInput.scrollTop += event.deltaY;
event.preventDefault();
event.stopPropagation();
}

/**
* We want to call updateNumberOfLines only when the parent doesn't provide value in props
* as updateNumberOfLines is already being called when value changes in componentDidUpdate
Expand Down