Repository navigation
fix: get last actor details from last report action if not present in personal details - #15895
Conversation
… personal details
|
@mountiny @parasharrajat One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| // then we need to get them from the last report info | ||
| let lastActorDetails = personalDetails[report.lastActorEmail] || null; | ||
| if (!lastActorDetails && lastReportActions[report.reportID]) { | ||
| const lastActorDisplayName = lodashGet(lastReportActions[report.reportID], 'person[0].text'); |
There was a problem hiding this comment.
Question to me: Are we sure that lastReport action and lastActorEmail from reportData are in sync at all times? Is there any possibility that report action is not yet synced but report data is updated?
There was a problem hiding this comment.
Started digging this info.
There was a problem hiding this comment.
I think this should be fine, the last report message is whats in the LHN, the data should be there.
There was a problem hiding this comment.
It also seems like they are synced, but we could check if the report.lastActorEmail and lastReportActions actorEmail are the same and only use the display name of it if true. Perhaps it's worth the effort, please let me know the resolution to this doubt
|
Updated |
mountiny
left a comment
There was a problem hiding this comment.
The code looks good to me, @BeeMargarida could you also include some notes about what the PR accomplishes in the details section, very briefly. Thanks!
@parasharrajat do you still have any concerns?
|
I am going to run the checklist in some time. |
My bad, i though I had done it. Should be fixed now |
|
Couldn't get to it today. It will be tested by the CST morning tomorrow. |
|
Doing the checklist now. |
I could replicate. Hum, it seems that perhaps we could ignore the last actor fallback the if the |
|
I think you can also have an IOU action, can you skip it if the action type is not CREATED and also check how this behaves when you request money or send money? |
There's also no actor in the |
|
FYI, I am not well-versed in the types of actions and their payloads. Vit might help with this. But I think we just need to filter a few actions. A list from CONST file. |
mountiny
left a comment
There was a problem hiding this comment.
I think this is looking good now, @parasharrajat can you test this again for the regression you found?
|
Sure, give me an hour. |
|
Retesting in 15 mins. |
Screenshots🔲 MacOS / Chromescreen-2023-03-20_21.26.48.mp4🔲 Android / nativescreen-2023-03-20_22.31.00.mp4🔲 Android / mWEb Chromescreen-2023-03-20_22.42.39.mp4 |
parasharrajat
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
cc: @mountiny
🎀 👀 🎀 C+ reviewed
mountiny
left a comment
There was a problem hiding this comment.
Thank you all very much!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 1.2.88-0 🚀
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 1.2.88-0 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.2.88-2 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.2.88-2 🚀
|

Details
There are instances* where users in a group/channel do not have information about each other saved in the Onyx collection. When that happens, the last message in a chat from those users will not appear in LHN with the user name, only the content.
The fix for this problem was adding a fallback to the last actor email in the
lastReportActions. ThelastReportActionwas already used below to get a possible archive reason, so it's available and contains the necessary info without having to refetch the data for that specific user.* The instances consists for example of inviting to a workspace 2 users who never spoken before. When one of these users talk in the
#announcechat, the other user will not get the preview with the user name.Fixed Issues
$ #15711
#15711 (comment)
Tests
#announcechannelOffline tests
Should work as before, so not applicable in this case.
QA Steps
#announcechannelPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
output_1.mp4
Mobile Web - Chrome
output_3.mp4
Mobile Web - Safari
output_3.mp4
Desktop
output_2.mp4
iOS
output_1.mp4
Android