Skip to content

[HOLD for payment 2023-11-30] Manually manage tags in bumpVersion action - #1612

Merged
AndrewGable merged 7 commits into
masterfrom
Rory-ManuallyManageTags
Mar 3, 2021
Merged

AndrewGable merged 7 commits into
masterfrom
Rory-ManuallyManageTags

Conversation

@roryabraham

Copy link
Copy Markdown
Contributor

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/155197

Tests

None yet, test by merging

Tested On

  • Github

@roryabraham
roryabraham requested a review from AndrewGable March 3, 2021 18:11
@roryabraham
roryabraham requested a review from a team as a code owner March 3, 2021 18:11
@roryabraham roryabraham self-assigned this Mar 3, 2021
@botify
botify requested review from nickmurray47 and removed request for a team March 3, 2021 18:11
Comment on lines +102 to +107
const addCommand = `git add ${
[PACKAGE_JSON_PATH, PACKAGE_LOCK_PATH, BUILD_GRADLE_PATH, PLIST_PATH, PLIST_PATH_TEST].join(' ')
}`;
const commitCommand = `git commit -m "Update version to ${newVersion}`;
const tagCommand = `git tag ${newVersion} && git push --tags`;
return exec(`${[addCommand, commitCommand, tagCommand].join(' && ')}`);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I have an opinion either way, but is there a reason for doing this in JS as opposed to in the action?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only reason would be to use the new version in the commit message and tag. However, one of the things on our project roadmap is having this action output the new version, so we could just output the new version from JS then do the git stuff in the workflow.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline and I think we both agreed that moving this out of JS will make our lives and code easier in the long run

Comment thread .github/workflows/version.yml Outdated
./android/app/build.gradle \
./ios/ExpensifyCash/Info.plist \
./ios/ExpensifyCashTests/Info.plist
git cm -m "Update version to ${{ steps.bumpVersion.outputs.newVersion }}"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is cm a local shortcut you have installed locally?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 is git commit even a command?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I honestly forgot that git cm is just an alias

@AndrewGable
AndrewGable merged commit f4f1e5f into master Mar 3, 2021
@AndrewGable
AndrewGable deleted the Rory-ManuallyManageTags branch March 3, 2021 21:05
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 3, 2021
@marcaaron marcaaron mentioned this pull request Nov 20, 2023
45 of 47 tasks
@melvin-bot melvin-bot Bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 20, 2023
@melvin-bot melvin-bot Bot changed the title Manually manage tags in bumpVersion action [HOLD for payment 2023-11-30] Manually manage tags in bumpVersion action Nov 23, 2023
@melvin-bot melvin-bot Bot unlocked this conversation Nov 23, 2023
@melvin-bot

melvin-bot Bot commented Nov 23, 2023

Copy link
Copy Markdown

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot Bot removed the Reviewing Has a PR in review label Nov 23, 2023
@melvin-bot

melvin-bot Bot commented Nov 23, 2023

Copy link
Copy Markdown

❗ Please, do not use Github auto-linking keywords such as these: close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved.

For more details, see the Contributing Guidelines, specifically Submit your pull request for a final review 📖.

@melvin-bot

melvin-bot Bot commented Nov 23, 2023

Copy link
Copy Markdown

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

sajal101agrawal pushed a commit to sajal101agrawal/expensify-app that referenced this pull request Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting Payment Auto-added when associated PR is deployed to production Weekly KSv2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants