Tasks Detailed View by thienlnam · Pull Request #17940 · Expensify/App

thienlnam · 2023-04-24T21:59:35Z

Details

Fixed Issues

This sets up routing for the tasks detailed view - there is no functionality implemented here as those will be added in future PRS.

Part of #17468
PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

[DEV] Override isTaskReport to return true.
Open any chat report, and notice that you see these task title and description headers under the header

Click on the title, verify you are taken to another page to edit the title
Click on the description, verify you are taken to another page to edit the description
Click on the three buttons on the top right of the chat. Verify you see these options

Verify that no errors appear in the JS console

Offline tests

Same as online tests

QA Steps

No QA
Can't test this bc task reports don't exist yet

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-04-26.at.4.35.00.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-04-26.at.4.42.17.PM.mov

Mobile Web - Safari

Screen.Recording.2023-04-26.at.4.50.42.PM.mov

Desktop

Screen.Recording.2023-04-26.at.4.40.40.PM.mov

iOS

Screen.Recording.2023-04-26.at.4.49.48.PM.mov

Android

MelvinBot · 2023-04-26T23:52:18Z

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2023-04-26T23:53:50Z

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

thienlnam · 2023-05-02T16:14:53Z

Merged!

0xmiroslav · 2023-05-02T16:55:38Z

@thienlnam there's space while showing skeleton because of TaskHeader. can we avoid this?

skeleton.mov

thienlnam · 2023-05-02T17:04:32Z

I think that's just because we're returning true that it's a task report for all chat reports. It shouldn't happen for regular chat reports since it won't exist. Please let me know if that's an incorrect assumption though

0xmiroslav · 2023-05-02T17:26:21Z

It shouldn't happen for regular chat reports since it won't exist.

Correct.

Not sure how task report will look finally but I think we can tackle skeleton part for task report after that page is fully implemented, so out of scope for this PR.

thienlnam · 2023-05-02T17:27:18Z

For sure! Agreed 👍

0xmiroslav · 2023-05-02T17:36:15Z

keyboard issue on mSafari:

msafari-bug.mov

I think this can also be out of scope as it's know mSafari issue

0xmiroslav · 2023-05-02T17:42:39Z

Auto focus doesn't work on android. I think this one can be fixed here. Can you please apply same approach as in #17953?

android.mov

thienlnam · 2023-05-02T18:08:35Z

@0xmiroslav Nice catch, thanks - I updated it please let me know. My android emulator is currently broken

0xmiroslav · 2023-05-03T03:24:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

0xmiroslav

Looks great, tests well 🎉
@grgia all yours!

grgia

LGTM

OSBotify · 2023-05-03T16:58:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-04T16:42:25Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.10-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-05-09T04:06:13Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

eVoloshchak · 2023-06-02T16:24:11Z

+        const errors = {};
+
+        if (_.isEmpty(values.title)) {
+            errors.title = props.translate('common.error.fieldRequired');


This introduced a small "regression" in #19023.
This error label should have been Please enter a title instead of This field is required

fedirjh · 2023-06-13T18:31:59Z

+        if (_.isEmpty(values.description)) {
+            errors.description = props.translate('common.error.fieldRequired');
+        }


This introduced a regression in #19022, the description field is optional and should allow empty inputs.

mollfpr · 2023-06-29T06:27:02Z

+                // Implementing in https://github.com/Expensify/App/issues/16858
+                onSelected: () => {},
+            });
+        }


✋ Coming from #19631

This introduces a regression where the user non-assignee, or not owner, can still see the action button and press it.

s77rt · 2023-07-25T21:44:16Z

+        <ScreenWrapper
+            includeSafeAreaPaddingBottom={false}
+            onEntryTransitionEnd={() => inputRef.current && inputRef.current.focus()}
+        >


We should have added shouldEnableMaxHeight here otherwise the submit button would be behind the keyboard (Coming from #22661).

thienlnam added 20 commits April 24, 2023 11:52

Add check if it is a task

e3b8cc0

Update header to show multi select

2f1ac41

add new h1 headline

3d1789f

add it as an option in MenuItem

d807c31

add default / cleanup

822b1be

Add Task report specific methods

190b82d

Move into component

1dbb30a

use the passed in report

af5351e

Add routing for title page

b40ae92

Update ModalStackNavigators.js

a4876a0

add new push to page title

30a8b3d

update title to pass in task route

8bffea3

navigation for push to page for description

5d83a7b

Add description page

a23136b

Clean up TaskHeaderView

65f7e6b

update to use ref

2d6e0c6

Merge branch 'main' into jack-DetailedView

8d05766

style / cleanup

9f45a62

update options shown in header

34a9c79

revert shouldShowCallButton changes

2ebebb4

thienlnam self-assigned this Apr 26, 2023

clean up

8b583ba

thienlnam marked this pull request as ready for review April 26, 2023 23:51

thienlnam requested a review from a team as a code owner April 26, 2023 23:51

melvin-bot Bot requested review from grgia and removed request for a team April 26, 2023 23:52

thienlnam requested a review from a team April 26, 2023 23:53

melvin-bot Bot removed the request for review from a team April 26, 2023 23:53

add ref

20bcf89

0xmiroslav reviewed May 2, 2023

View reviewed changes

Comment thread src/pages/tasks/TaskDescriptionPage.js Resolved

Comment thread src/pages/tasks/TaskDescriptionPage.js Resolved

Comment thread src/pages/tasks/TaskTitlePage.js Resolved

Comment thread src/pages/tasks/TaskTitlePage.js Resolved

thienlnam added 2 commits May 2, 2023 14:15

autofocus

dd8ef23

Update TaskDescriptionPage.js

4e0b418

0xmiroslav approved these changes May 3, 2023

View reviewed changes

grgia approved these changes May 3, 2023

View reviewed changes

thienlnam merged commit 5e01406 into main May 3, 2023

thienlnam deleted the jack-DetailedView branch May 3, 2023 16:52

OSBotify mentioned this pull request May 4, 2023

Deploy Checklist: New Expensify 2023-05-04 #18411

Closed

32 tasks done

0xmiroslav mentioned this pull request May 4, 2023

[HOLD FOR PAYMENT 05-16-23] Task Details View #17468

Closed

eVoloshchak reviewed Jun 2, 2023

View reviewed changes

eVoloshchak mentioned this pull request Jun 2, 2023

[HOLD for payment 2023-06-02] [$1000] On task title editing page when title field is empty than error message is This field is required instead of please enter a title #19023

Closed

6 tasks done

fedirjh reviewed Jun 13, 2023

View reviewed changes

fedirjh mentioned this pull request Jun 13, 2023

[HOLD for payment 2023-06-13] [$1000] On task description editing page field is showing mandatory when editing an existing task where by actually field should be optional #19022

Closed

6 tasks done

mollfpr reviewed Jun 29, 2023

View reviewed changes

mollfpr mentioned this pull request Jun 29, 2023

[HOLD for payment 2023-06-29] [$1000] Strange UX when creating tasks in a DM #19631

Closed

1 of 6 tasks

s77rt reviewed Jul 25, 2023

View reviewed changes

s77rt mentioned this pull request Jul 25, 2023

[HOLD for payment 2023-08-01] [$1000] mWeb - Next button is hidden behind the keyboard #22661

Closed

1 of 6 tasks

Conversation

thienlnam commented Apr 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Apr 26, 2023

Uh oh!

MelvinBot commented Apr 26, 2023

Uh oh!

thienlnam commented May 2, 2023

Uh oh!

0xmiroslav commented May 2, 2023

Uh oh!

thienlnam commented May 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xmiroslav commented May 2, 2023

Uh oh!

thienlnam commented May 2, 2023

Uh oh!

0xmiroslav commented May 2, 2023

Uh oh!

0xmiroslav commented May 2, 2023

Uh oh!

thienlnam commented May 2, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0xmiroslav commented May 3, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

0xmiroslav left a comment

Choose a reason for hiding this comment

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 3, 2023

Uh oh!

OSBotify commented May 4, 2023

Uh oh!

OSBotify commented May 9, 2023

Uh oh!

eVoloshchak Jun 2, 2023

Choose a reason for hiding this comment

Uh oh!

fedirjh Jun 13, 2023

Choose a reason for hiding this comment

Uh oh!

mollfpr Jun 29, 2023

Choose a reason for hiding this comment

Uh oh!

s77rt Jul 25, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

thienlnam commented Apr 24, 2023 •

edited

Loading

thienlnam commented May 2, 2023 •

edited

Loading